From: Kevin Tian <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Ashok Raj <ashok.raj@intel.com>,
Chris Wright <chrisw@sous-sol.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Asit Mallick <asit.k.mallick@intel.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 8/9] iommu/vt-d: Remove dmar_disabled
Date: Thu, 2 Jul 2026 06:12:15 +0000 [thread overview]
Message-ID: <20260702061216.388743-9-kevin.tian@intel.com> (raw)
In-Reply-To: <20260702061216.388743-1-kevin.tian@intel.com>
It's replaced by dmar_policy_off() now, covering both "iommu=off"
and "intel_iommu=off". Also remove unnecessary checks on no_iommu,
leaving only one exception in intel_iommu_init() which skips debugfs
init for "iommu=off" but not "intel_iommu=off". Keep it to avoid
surprise for now.
Signed-off-by: Kevin Tian <kevin.tian@intel.com>
---
drivers/iommu/intel/iommu.c | 9 ++-------
drivers/iommu/intel/iommu.h | 1 -
drivers/iommu/intel/svm.c | 2 +-
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 50dfe426322f..3312ee28db11 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -202,7 +202,6 @@ int dmar_policy = DMAR_ON;
#else
int dmar_policy = DMAR_DEFAULT_OFF;
#endif
-int dmar_disabled = !IS_ENABLED(CONFIG_INTEL_IOMMU_DEFAULT_ON);
int intel_iommu_sm = IS_ENABLED(CONFIG_INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON);
int intel_iommu_enabled = 0;
@@ -244,11 +243,9 @@ static int __init intel_iommu_setup(char *str)
while (*str) {
if (!strncmp(str, "on", 2)) {
dmar_policy = DMAR_ON;
- dmar_disabled = 0;
pr_info("IOMMU enabled\n");
} else if (!strncmp(str, "off", 3)) {
dmar_policy = DMAR_USER_OFF;
- dmar_disabled = 1;
pr_info("IOMMU disabled\n");
} else if (!strncmp(str, "igfx_off", 8)) {
disable_igfx_iommu = 1;
@@ -2369,7 +2366,7 @@ void intel_iommu_shutdown(void)
struct dmar_drhd_unit *drhd;
struct intel_iommu *iommu = NULL;
- if (no_iommu || dmar_disabled)
+ if (dmar_policy_off())
return;
/*
@@ -2503,7 +2500,6 @@ static void __init platform_optin_force_iommu(void)
/* No concurrent access to dmar_policy at this point. */
dmar_policy = DMAR_FORCE_ON;
- dmar_disabled = 0;
}
static int __init probe_acpi_namespace_devices(void)
@@ -2556,7 +2552,6 @@ static __init void tboot_force_iommu(void)
/* No concurrent access to dmar_policy at this point. */
dmar_policy = DMAR_FORCE_ON;
- dmar_disabled = 0;
no_iommu = 0;
}
@@ -2600,7 +2595,7 @@ int __init intel_iommu_init(void)
if (!no_iommu)
intel_iommu_debugfs_init();
- if (no_iommu || dmar_disabled) {
+ if (dmar_policy_off()) {
/*
* We exit the function here to ensure IOMMU's remapping and
* mempool aren't setup, which means that the IOMMU's PMRs
diff --git a/drivers/iommu/intel/iommu.h b/drivers/iommu/intel/iommu.h
index 95962a45ac36..ad4d1aafd12c 100644
--- a/drivers/iommu/intel/iommu.h
+++ b/drivers/iommu/intel/iommu.h
@@ -1401,7 +1401,6 @@ static inline bool dmar_policy_force_on(void)
bool dmar_can_force_on(enum dmar_force_on force_on);
-extern int dmar_disabled;
extern int intel_iommu_enabled;
extern int intel_iommu_tboot_noforce;
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index fea10acd4f02..0636987f03c8 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -115,7 +115,7 @@ static int intel_iommu_sva_supported(struct device *dev)
struct device_domain_info *info = dev_iommu_priv_get(dev);
struct intel_iommu *iommu;
- if (!info || dmar_disabled)
+ if (!info || dmar_policy_off())
return -EINVAL;
iommu = info->iommu;
--
2.43.0
next prev parent reply other threads:[~2026-07-02 6:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 6:12 [PATCH v2 0/9] iommu/vt-d: Support a new DMAR flag Kevin Tian
2026-07-02 6:12 ` [PATCH v2 1/9] iommu/vt-d: Fix no_iommu to disable platform optin Kevin Tian
2026-07-02 6:12 ` [PATCH v2 2/9] iommu/vt-d: Force requesting ACS when tboot is enabled Kevin Tian
2026-07-02 6:50 ` Tian, Kevin
2026-07-02 6:12 ` [PATCH v2 3/9] iommu/vt-d: Remove dead code when CONFIG_INTEL_IOMMU is not set Kevin Tian
2026-07-02 6:12 ` [PATCH v2 4/9] iommu/vt-d: Consolidate dmar policy management and force_on logic Kevin Tian
2026-07-02 6:12 ` [PATCH v2 5/9] iommu/vt-d: Use dmar_can_force_on() for platform optin Kevin Tian
2026-07-02 6:12 ` [PATCH v2 6/9] iommu/vt-d: Call dmar_can_force_on() for tboot optin Kevin Tian
2026-07-02 6:12 ` [PATCH v2 7/9] iommu/vt-d: Remove the 'force_on' variable Kevin Tian
2026-07-02 6:12 ` Kevin Tian [this message]
2026-07-02 6:12 ` [PATCH v2 9/9] iommu/vt-d: Support the new DMA_REMAP_OPT_OUT flag bit Kevin Tian
2026-07-27 3:04 ` [PATCH v2 0/9] iommu/vt-d: Support a new DMAR flag Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702061216.388743-9-kevin.tian@intel.com \
--to=kevin.tian@intel.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=chrisw@sous-sol.org \
--cc=iommu@lists.linux.dev \
--cc=jbarnes@virtuousgeek.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®