From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC65F385516 for ; Thu, 2 Jul 2026 06:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782973320; cv=none; b=E1wammGb82IaMmiy6Hys4unuwl3HDVE3Brx8OrWeN+f7idZsc/B49vAYg//UimSkiRIhz+D5tFUJgdw0f3zhOJM5hRULbWekQI3NXgkFTBlSddYQrmLFyp81+7sk2Pu+9vjM8wRvR6W9txcQBeaDdCbPkzrAc17WlW7LLVRrDi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782973320; c=relaxed/simple; bh=Xz1wb76anL5E5ME/dtrL8oHkFhMXv3brH7Mycv91DBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QTgaFkz5LLdf/izFwh7WiDvkyNA/Tk54x4GOxNkVYucQ1tqTnbwd2e8uGJV40ylkLznUD5bJD2oONYNWemCsET/lmGxEFpnGjQt0ZbkO0jakg1rW6WB/s+XXYfNuCKGswrIC7ZdI6bzQqeoGmfgHmWwKi5NkHpEYRqsLmvIGALE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LyTMJKPD; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LyTMJKPD" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ca64c3ce5fso13317825ad.3 for ; Wed, 01 Jul 2026 23:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782973318; x=1783578118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p+AybXHCcO4BnLqFoauWvt1KwEn7CeMrNml46vf7sfE=; b=LyTMJKPDd9og/E13MDsh3ENnkIDwMeOKzw6jG4Jj7TYDr2XRO2kTbEU3n8yPWNRcei HPbES4ohp1delPdO4k3PPEvV/cTZFx8U8wiKV/yi9fEcnd09928PqkcF1ELhnuj/gjmx 0yBITzT52K9WWDD4HPw7+uJWOXUYjLZBkW+OvaOuxupCTAM/DusJ1NkBnWuLRE/NdnlK YzrEUP0SQ11/3/hHINA7vDIMYg4G0uIx+0Q+RujQftafHXrwwuLKufttzo9IYtomWp6Y aeUMhQSTIQgrTpg4XFKkzRR4rU02Iiw0JUkTYDdGNdD80anWffpXHngDs2JFtAE8VOBh 9kpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782973318; x=1783578118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p+AybXHCcO4BnLqFoauWvt1KwEn7CeMrNml46vf7sfE=; b=ErPLd69AVznDI6DstBEC8C8C2Sf5n601H9PIQk5e1XlhACFR+epKTkbrKnW6NzlTp2 xmFM3Et/4gJHHCH/qEB/d2+8zBaSBX8MgNiBCoR1cXdKj4Af9h+ic6A2PVecjWT6aM1G 49GChIzhxLJLLu7gILWGdDCbWsEcrc2So68NcvQElFUT2d0eFyf9f1v2PmJAkxjw7Hwp beE3/8R19QdK46nlktVR9Fwm2Q9JCnIAA+MQ/VJsiKrD80paqgWpFgRw+Ii53ulTeyXE ds/lHokO/ui64NkXSIG1HzhZ8PdWFv0EnmhlF0oa/SKyc5WP1C2cG2OHlk22JOUoT9e8 TwWQ== X-Forwarded-Encrypted: i=1; AHgh+RoE6xQqH4qwFetIJ1RUs7ZgmiWEo0Ou2aNGtpiebyBuJzM4CNKWqZbBZPS+n1g06j1OaoOjSTNr2nz3Db0=@vger.kernel.org X-Gm-Message-State: AOJu0YzVp4S3Oi1keJlqJGA/d7AxSwS4vIcBRmM70EixNqslCicdJQg6 qBKuLWnti8JLVAWfD2Aft5dDdZDH82PDnurt1RMSdmLG9UvuC4LIZsi2 X-Gm-Gg: AfdE7clxlNO8SuhbGoQ8LHuCMQk6DFWzDPvz6OEl0MLqeoKq/RDZAGnn+yyFCQrCi3H JJtv/EeXGGGYdyr2m+19uf8ubD/l+E6eZ9V3eEaLniuJi6g+/oQ7mWIO9dUvcvPEiVeV4HBo6WZ i/m0+GLfaf+1TmakpHQxv+AYLEsmMzIYxEB0lEpFqzZ9PgTGf/zmbt3vZDyymVbTCF/8H/EXYoT 6U9HzmSXR9ypXhXlXbF33vYFAwIo10vJpnUwG+bl2GmIvDJJYw+xqz1n4MsN85bzAK+iAf4Zn69 kOjYyaVvb9St5JcRX+1aHIX0BwViqWIwZtvXpwbls7U5eeWFN3lS0+zseoWL/GhnKLSQO/fzpUF t4UOYaahP2+cC2Wdz/F1HsycOhkET7ebvNV3P+v5cAC3MymkUyz336PrNIbtBxPjcBJ3IbBlzeS aFYAgdCb8lF+0CreX/uWNIQNVCEqsWphlXWg== X-Received: by 2002:a17:903:41c7:b0:2c9:c46b:129b with SMTP id d9443c01a7336-2ca7e67c028mr50539785ad.5.1782973317756; Wed, 01 Jul 2026 23:21:57 -0700 (PDT) Received: from nbai25050028.. ([2403:8600:2090:6f:cce5:6a06:d746:c95f]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c7fa65asm5296145c88.6.2026.07.01.23.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 23:21:57 -0700 (PDT) From: Aniket Negi To: Lorenzo Bianconi Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, aniket.negi@airoha.com Subject: Re: [PATCH net v2] net: airoha: fix MIB stats collection to be lossless Date: Thu, 2 Jul 2026 11:51:47 +0530 Message-ID: <20260702062150.8291-1-aniket.negi03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > > Signed-off-by: Aniket Negi > > Hi Aniket, > > just few nits inline. Fixing them: > > Acked-by: Lorenzo Bianconi > Ok sure. I'll update. > > + dev->stats.mib_prev.tx_runt_cnt = val; > > + > > + /* tx_len[0]: RUNT (32-bit, delta) + E64 (64-bit, absolute) → {0, 64} bucket. > > + * Accumulate RUNT delta in tx_runt_accum64, then assign tx_len[0] as > > + * accum + E64_abs so each call gives the correct combined total. > > + */ > > no new-line here. > > > + > > + dev->stats.tx_len[i] = dev->stats.mib_prev.tx_runt_accum64; > Sure, You are reffering to both the spaces above and below comment section?. Same for rx_runt and rx_long/tx_long. I'll update as following: + dev->stats.mib_prev.tx_runt_cnt = val; + /* tx_len[0]: RUNT (32-bit, delta) + E64 (64-bit, absolute) → {0, 64} bucket. + * Accumulate RUNT delta in tx_runt_accum64, then assign tx_len[0] as + * accum + E64_abs so each call gives the correct combined total. + */ + dev->stats.tx_len[i] = dev->stats.mib_prev.tx_runt_accum64; > > + u32 tx_drops; > > + u32 tx_broadcast; > > + u32 tx_multicast; > > + u32 tx_runt_cnt; > > u32 tx_runt; > > > + u32 tx_long_cnt; > > u32 tx_long; > > > + u64 tx_runt_accum64; > > 64 tx_runt64; > > > + u32 rx_drops; > > + u32 rx_broadcast; > > + u32 rx_multicast; > > + u32 rx_errors; > > + u32 rx_crc_error; > > + u32 rx_over_errors; > > + u32 rx_fragment; > > + u32 rx_jabber; > > + u32 rx_runt_cnt; > > u32 rx_runt; > > > + u32 rx_long_cnt; > > u32 rx_long; > > > + u64 rx_runt_accum64; > > u64 rx_runt64; > > > + } mib_prev; > > }; Acked the change name from tx_runt_cnt to tx_run, tx_long_cnt to tx_long, tx_runt_accum64 to tx_runt64. Same for rx counters. Best Regards, Aniket Negi