From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BD8C38F24C for ; Thu, 2 Jul 2026 07:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782977148; cv=none; b=NB6JXf5kVXIIhaz95u8aDW64KMupYSMIzxAAsvvZgkMT5BdU/U0+mTcHtIUibxwUgbVLpJ5xOS7E87Lplip+NlfzJozqoLNmwvzOa00+oAjwEnSz7/Zu47KaKi4VSUDQeVORkYccG8l9U+nYjajMiwNmcf5RybQTsCEfBVaBW6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782977148; c=relaxed/simple; bh=vLLYGnxRBnhnDuZQlInlNw7YhEkAAJD7JBKNgNyELE8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W7nI+40w0kLTz1A93/lSK+O4XWrDBxedChZjAuHxcoVqt4a765Qw1VUvjnvCpYUxTfETkAh10tfiL2JD+WJ0yfaqC8fDcjcPvuuRwQQQzgdMio9Iugw6PMvsxSzLbG5NU03Pzg6xbo8K1f9Y7PuLzd9QfTIOgGJ9LmEzJu7guwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VlClClwN; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VlClClwN" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-847a5528b33so790301b3a.3 for ; Thu, 02 Jul 2026 00:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782977146; x=1783581946; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FCmxnXldFzmagzY4ubPmQ/onPJKAAsxLFT7eh00Vk4s=; b=VlClClwNy6zStaz4vxh2eosczUUzqsLejqvreN0GW3hh+ubq+227dqBXotNT9RHGrv U0vxqphMZ61asCDZ0IDL4ENAP1Asy/TltFiNCE8DY2tjFxHwIIveNLT6qxvyk6HqEBuy 4NRWpCG7o4QKNgT/OOHmeCKGFRnH1tOMSUTaMtPayl7/Sy+AShvbmgQusfRD3kZbJs+o n3O36iemLdM/4/Vm0f9Z7ttErBm18Ok0hgktRHNJmVj2njVe69AFCJAF84jGhb68jIVH sDcy8G6dVYlnhpBEM7ZMfCSme0RMWXppV6SxaW4rItc7hgWa9nSln/Uh1x7mnnm9SyW4 tT6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782977146; x=1783581946; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FCmxnXldFzmagzY4ubPmQ/onPJKAAsxLFT7eh00Vk4s=; b=fD8MD558xguubTZdtLlp5xsnLLw4S6tlNfOgc7wrwZKmVlEjosb02On0BjWA7IyPaN M09W69r4yCCDJN64/qsyR1pBLEML4oddBI87qLD9p6olmuMEBOL6ohk9tbCAZ+8RHWor 9I33ywp2iF/V+gvuqgrcI1UvXk9bAvBNC6swpvmDQlXXUcmV17b4k8wJwsyZYgRQgub2 4LTASzkLEgf8f3B56pjbH76Jnyni0rdIcAT+VeUJvtGuWopF0zEHCz035kXTt1IiiuR/ pj5B08mjuQ4OjhflVm3eSrkLFb6L43l79YboYw838O0qpg32NHtnfzyhcLnOVlFtIDJi 74tQ== X-Forwarded-Encrypted: i=1; AFNElJ8j0AdqGtTkQIfTAvFuTeI5eyXLNBSVM+i5z7VvtMFvZmPAdPqNyZZiYmDIvryYJ8PxV2bB+rSVsICtI3M=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8Zpegw5PlErQLqQlG7LVMlrsVuvfaT+N4LA9W9YFy4JxuJl+V lTOUOGJyRYSBuDJuasUm08P9uV2Oe1lCYr6/jWZrR9UnFWdUsHHbD44a X-Gm-Gg: AfdE7cmJuHQI+cFHVlTzeKxfvXcnO2vx6sj/psGtHu1NmxRV0HAE5DMWiR3f4SAhFTJ L0oZOILi51V//SDhImDlnRoyMDIGwvtKMdhaXcBgu2yEEb9L3N8lD/WTRPuBsH8EbPD0W/LPdY0 0XxeObtSL/14fhh7NXKDXExPdRZsNCZtxH3fWdBwY7YH5moieEdwgkzovAMwk9X0r5wxGKbnFaA LwKfYwP/l9Y0P/65y+PiKj4Lt9y59Oy2AEb8c6cuugrwazpn43WgCo8dPg75IQiaFRDQeMbrSAV fbLGw9xonjI3tU9yXAqHs3QRR9G0fqcXaagFlc5+Clk9udZ8OniFIdVJoXCMBEK2XINCefShnts 1s7KDt51BhLEUM3WLgN+ADSISI//BTPmlb+PYuyuurctfIhflJd8G5ZjPjnLYTBxN93ICyIGYfg p4RPEOEqXuRBhxQzUTd1o+lX11qQ== X-Received: by 2002:a05:6a20:b786:b0:3b5:489c:7bb5 with SMTP id adf61e73a8af0-3bff422d1cbmr5285217637.28.1782977146282; Thu, 02 Jul 2026 00:25:46 -0700 (PDT) Received: from lenovo-thinkbook.. ([114.143.209.22]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c7fa33asm6415252c88.5.2026.07.02.00.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 00:25:45 -0700 (PDT) From: Jhonraushan To: Min Ma , Lizhi Hou , Oded Gabbay Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jhonraushan Subject: [PATCH] accel/amdxdna: Fix double drm_gem_object_put() in dma-buf mmap error path Date: Thu, 2 Jul 2026 12:55:40 +0530 Message-ID: <20260702072540.2183601-1-raushan.jhon@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit amdxdna_gem_dmabuf_mmap() takes a reference with drm_gem_object_get() and, on the vm_insert_pages() failure path, jumps to close_vma which calls vma->vm_ops->close(). For a shmem GEM object vm_ops is drm_gem_shmem_vm_ops, whose .close (drm_gem_shmem_vm_close -> drm_gem_vm_close) already drops that reference. Execution then falls through to put_obj and drops it a second time. This underflows the GEM object refcount and frees it prematurely while the dma-buf still references it, leading to a use-after-free. Return directly after vm_ops->close() instead of falling through to the extra drm_gem_object_put(), matching the sibling amdxdna_insert_pages() error path. Fixes: e486147c912f ("accel/amdxdna: Add BO import and export") Cc: stable@vger.kernel.org Signed-off-by: Jhonraushan --- drivers/accel/amdxdna/amdxdna_gem.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c index 891112c2cddf..3ac8c345b25b 100644 --- a/drivers/accel/amdxdna/amdxdna_gem.c +++ b/drivers/accel/amdxdna/amdxdna_gem.c @@ -526,7 +526,12 @@ static int amdxdna_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struc return 0; close_vma: + /* vm_ops->close() drops the reference taken by drm_gem_object_get() + * above, so return directly instead of falling through to put_obj + * and dropping it a second time. + */ vma->vm_ops->close(vma); + return ret; put_obj: drm_gem_object_put(gobj); return ret; -- 2.43.0