From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66E9E35F165 for ; Thu, 2 Jul 2026 10:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782988763; cv=none; b=QnIlMgxShA0IKEwcQxYMfjK4ee8TexsLCiSRXBkYRNRLiliYXPk7gXuNJa5dfo6+2qsYGkl0AaHIm9/Ttf8TjRRBXqA9G1esVoVy0vKZL15KEYHAk1GxollybboQDdeAq3eg0dRc+11alOf/hjiT1XQc+iY9YxxXtrjITXMEXqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782988763; c=relaxed/simple; bh=mZQwFtKmuv9JtN9Z5Z7PUOwhh+Ry/isHxQ86Gbb1Aoc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=kHgAQWeBX7q2TYhnurzsVCGgFQgXst8ZI7gzyBeYas28HiH+LjHttmqK8u1BejdGI38IZLRFmxlB5AgNSF4o0xkz7r8mFj3cNl2Sk4GYst9HVikrgQnkpHkHshfIX7OED3W+gv6+KkpmFFDxrSPbB5JSQTXYadxCvwMJC4q3t4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--sebastianene.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rdXOhaz4; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--sebastianene.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rdXOhaz4" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-49244130073so12882355e9.1 for ; Thu, 02 Jul 2026 03:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782988761; x=1783593561; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Un4RsCE8ClG46waU3EoWIfi0gOM5MfO/J2aFh49A2VQ=; b=rdXOhaz4boRmlny3yTa/ZS6B0pBMZm5F0JOy2lZim4aQSr0crRpWvfHcC5SSJJgbuP VxeKHXyJCjDNGrhyO52l+6YijdrG2+IVKTet82YJK5HZ+a4hNS0cOZYrHO4Xm3enFtoP Zq9GCzThe5QQwM1D4SUao2RBeoJBvvwOIKIpSXMDOwNnTV58KoTZQ4ADEye6TK0lMZbi xIaHP5buQWWv6nVaQCc/VfeO5chIBUdrW0CTjQL+fJOX4/YZetwTjmCHhpjBVoVvzaTa ubFq3hmbWQF4tdr2f0MTKT/k9XVG3R0GQJa4t+GiuVdfq6Vf13AsBqLI3PzmB1tU6X4B RlAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782988761; x=1783593561; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Un4RsCE8ClG46waU3EoWIfi0gOM5MfO/J2aFh49A2VQ=; b=gvyAGSZjPicXEByKmk/pjkwchb55hyoEohAZaqBqNDKHxTD0RPweB2aZyuzoZDBBH6 s2887HGIJyxhRimeZ56YQ7N/bb5cv3K3CPUoOp3vKphnlyjTIOXt2cIVSTgvBp8wFl2G Wa3l+zDP5f6btmoHovq/phF8iXOi9WtyjVY6lcwGo78cvEzv2eJeiKU5vmlvzluyJK4l UlHUMojsIwI7N8jB5tWWVC5UUBFRfKhva5Nn1zFdMXwz+ZE5Q8qeyrpT+wvYGWCc4x2C IRfkW6TwPqUsewwdYs0+YlSTjTIIyEN0/W/u+Wn8T9qcu8hS2w3vUwNKrn/AR132wflY fBmg== X-Forwarded-Encrypted: i=1; AFNElJ+YuI5DrTTuTNB8rd2D6b2SwCe2zD+yu9mJaaDM7XZpP+sSgQaWMxNqNY+KVYyVcGvkD9vIDiYB0cWh6G8=@vger.kernel.org X-Gm-Message-State: AOJu0YzybK6o6+XpPG5XcVvRlEyOSbOP1WOzDOqSFwXPHxzKmnoeJCmL lOGl6cnRWJZMLcv3wH8YH+F3MSPxKMRihWoq45xv16/n//w4yeZvpOFACQQwUO3T3kR6BIU0BFN ydFEgT0353PvQ0HRjBMcuHqS3brQDpg== X-Received: from wmbjp19.prod.google.com ([2002:a05:600c:5593:b0:493:c562:3fc6]) (user=sebastianene job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1594:b0:493:bcba:46a4 with SMTP id 5b1f17b1804b1-493c2b7dc45mr45687565e9.20.1782988760577; Thu, 02 Jul 2026 03:39:20 -0700 (PDT) Date: Thu, 2 Jul 2026 10:38:43 +0000 In-Reply-To: <20260702103848.1647249-1-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260702103848.1647249-1-sebastianene@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260702103848.1647249-7-sebastianene@google.com> Subject: [PATCH v9 6/6] KVM: arm64: Zero out the stack initialized data in the FFA handler From: Sebastian Ene To: catalin.marinas@arm.com, oupton@kernel.org, sudeep.holla@kernel.org, will@kernel.org Cc: jens.wiklander@linaro.org, joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, maz@kernel.org, mrigendra.chaubey@gmail.com, op-tee@lists.trustedfirmware.org, perlarsen@google.com, sebastianene@google.com, seiden@linux.ibm.com, smostafa@google.com, sumit.garg@kernel.org, suzuki.poulose@arm.com, vdonnefort@google.com, yuzenghui@huawei.com, Sashiko AI Content-Type: text/plain; charset="UTF-8" Don't leak hypervisor stack data when using the FFA_VERSION call. When the compiler doesn't support -ftrivial-auto-var-init=zero option we need to zero out the stack initialized variable before returning data to the host caller. Closes: https://lore.kernel.org/all/20260616160016.C62C81F000E9@smtp.kernel.org/ Reported-by: Sashiko AI Fixes: c9c012625e12 ("KVM: arm64: Trap FFA_VERSION host call in pKVM") Reviewed-by: Vincent Donnefort Link: https://lore.kernel.org/all/20260616160016.C62C81F000E9@smtp.kernel.org/ Signed-off-by: Sebastian Ene --- arch/arm64/kvm/hyp/nvhe/ffa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c index 9c96e72e522e..a327c2bbb6b6 100644 --- a/arch/arm64/kvm/hyp/nvhe/ffa.c +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c @@ -880,7 +880,7 @@ static void do_ffa_part_get(struct arm_smccc_1_2_regs *res, bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) { - struct arm_smccc_1_2_regs res; + struct arm_smccc_1_2_regs res = {0}; /* * There's no way we can tell what a non-standard SMC call might -- 2.55.0.rc0.799.gd6f94ed593-goog