From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17004318BB8 for ; Thu, 2 Jul 2026 16:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783008314; cv=none; b=NLY6KH9ndtw0vpRnmKF3m4Nilo9sSuT6D8kMp1s4yU6Wtoc03vbxoiLTtFd9DO4sah9xFz3OTv6m8mabxB33gN2lInJ0d3J3MKivJBhhwH3ynPjfbgkHZFcMC6bXpvRyhKI7wTK5q/wYn+qBe9NZy+qIsojnf35guneXDpWaWpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783008314; c=relaxed/simple; bh=nDJAbJCFuUB7OnJXjKjnKvBkXflAc5qn8SUxoJPyYn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nwKuxJBbjLkASs0Hv8NvQ3FrKmi88NpJ/f1aZj/3peY64QqovGRBPhEofgO4h9+ldHxTOBzojCkP3dfjHMrPogbqdC0W9RLvTveMxhVYrJVsRD1kqKVoYGb2drjwPvmK3QIyUFcauFFuLRv+YxksZVQ1h/qxSJBsx5CEEmm/FOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pwEAZgGo; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pwEAZgGo" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493c733f15aso5799225e9.0 for ; Thu, 02 Jul 2026 09:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783008312; x=1783613112; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2Av9KMOeHNoLZjJvkQ1HtWMUmgg+DhH4RllPkn9qKDs=; b=pwEAZgGo+aJVKaOMSA+BI4DL7U/LgVBrDmWkbU8sQZovQb6Ush0lx/LVr9x56ga4Xi +hwyMWunrGoXPa4IdXMWhrBAIIOtgN2qn4URSG/b8sJe1F/2Ux9iw6BEK1P3fzUeXLkG PBVVHyXPSzPAF1IZgEPn073HBqWr9EXUlm1CMsz2nTVyEfvbByE5IBD8rrMuCGsG3qCn TSJTDB/nVWmVoZc95CmE+8uvkvdrVpPJyVKdnHux/2WhBWe2r/dlJGTg9w/HppENtoYP onUPd89pIycPbe+y004uKJdJnbkTz2RcaVKaDGKfAZW8j38iOI2Flm2J677mVf6ShEH4 IeBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783008312; x=1783613112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2Av9KMOeHNoLZjJvkQ1HtWMUmgg+DhH4RllPkn9qKDs=; b=ahvdU+LiGKda2qFJBx2RGXhGBwO6XBrC/0u3ClElsCBQnk2rR2lRK/mc9qoLhQNcaH a9auc+UCqrAVK1qWzKZCyWjcV1eFPB4lpzM7erVSi81Zq1HOWFjjp+74wOyodCr0x4F/ cn8CS51Bem/CLA27TPCoyaH/L6ZagwPXrQeGcFkd+sTs7C+MkyCC3pfjl6Jd1J+b67RN +ZaJ+8ZMDkMTAp3r29BQRrHOPpgnt55hs4Xkbx9sF915LwEK+mg6e2J0dfaHi7emE/ue TUlr+iOT2DOiK66yUVfApyhUE2kC1v/IgWBcRieBIYXHaCxIl1svoallDPttka5EL5Y6 xGaw== X-Forwarded-Encrypted: i=1; AFNElJ/6qwsL54BHY5BQAC9CnjID3ijk3lINea604phQjxWLoDCSOEiUtw124LgvvFCeXKh/VOZdyUs+AJoMxr4=@vger.kernel.org X-Gm-Message-State: AOJu0YwzsNkzi52mKfqBUtZR2iwQsGZ+HZ5b2ctAOMxrsK8J1eX6WhrN X637eaHIjrzmOZruq6YsqiK90O+GCKvbe5eLfgZlxGOdCcjsoHojnuMu X-Gm-Gg: AfdE7cm5cEae7o9tgBWwsVn11XVLx1PvN9Yd/HgLEXTmAsO4/bTXTbdEHTzRoud2GVt KsS3AuYyS/GqSbiCaT0KtrqgHXURrJuLv1Wau5uNRKgiIDJ8Hbm1Wr2u7j84s/VUoo7xC+fj+co OpwomVb7G+fxP9Zj/iPCViuAV6q/ROieGEXxTGC/9DKnv+lsok3IXfFj5F1aYYNjDVHffNU4L3i RAe+b5SPV+cIbeSykkIzATwVv/Fm4VBG1IANeG6rxTiFKlkyPMWlmcyQuV2/tbC2Sh7n2yzmlaU ld3meyh4mMpJcbl1uCAIykh0z/rIYefPfFUpXzySKfL320DN4oSnS0+cF8E4y4o/Hy1j3ZHlMJt FLEJPDSFhUFbq+Xq2aaNwIDQ+yz3pNCoFnVY1eBUye0+/wZFTqpBS1u8ulXcvmJvc/367Ytrugv 96R0dr8UngrXHapfcdmknSGQQhdfB0kNi37f4NhQ4ZfnWYGZ7HxEzCKGLo1f3xsfjR1tGPqCzop H6gFYBjbzEY/7w6nf4xK6Bbsr4= X-Received: by 2002:a05:600c:524d:b0:493:c82d:f3fb with SMTP id 5b1f17b1804b1-493c82df4e8mr25197755e9.28.1783008311282; Thu, 02 Jul 2026 09:05:11 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:7a4b:58b4:175e:8c2d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c637bc21sm85444715e9.7.2026.07.02.09.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 09:05:10 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Wim Van Sebroeck , Guenter Roeck , Philipp Zabel , Geert Uytterhoeven Cc: linux-watchdog@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 1/3] watchdog: rzv2h: Refactor WDTDCR start/stop handling Date: Thu, 2 Jul 2026 17:04:55 +0100 Message-ID: <20260702160457.1884345-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260702160457.1884345-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260702160457.1884345-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lad Prabhakar Refactor the WDTDCR start/stop helpers by introducing a common rzt2h_wdt_wdtdcr_count_ctrl() function that controls the WDTSTOPCTRL bit based on a boolean parameter. This is in preparation for switching WDTDCR access to regmap-based handling, where consolidating the control path simplifies the conversion. Signed-off-by: Lad Prabhakar --- drivers/watchdog/rzv2h_wdt.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c index 3b6abb66a1da..e9545b8f5fd0 100644 --- a/drivers/watchdog/rzv2h_wdt.c +++ b/drivers/watchdog/rzv2h_wdt.c @@ -89,18 +89,26 @@ static int rzv2h_wdt_ping(struct watchdog_device *wdev) return 0; } -static void rzt2h_wdt_wdtdcr_count_stop(struct rzv2h_wdt_priv *priv) +static void rzt2h_wdt_wdtdcr_count_ctrl(struct rzv2h_wdt_priv *priv, bool start) { u32 reg = readl(priv->wdtdcr + WDTDCR); - writel(reg | WDTDCR_WDTSTOPCTRL, priv->wdtdcr + WDTDCR); + if (start) + reg &= ~WDTDCR_WDTSTOPCTRL; + else + reg |= WDTDCR_WDTSTOPCTRL; + + writel(reg, priv->wdtdcr + WDTDCR); } -static void rzt2h_wdt_wdtdcr_count_start(struct rzv2h_wdt_priv *priv) +static void rzt2h_wdt_wdtdcr_count_stop(struct rzv2h_wdt_priv *priv) { - u32 reg = readl(priv->wdtdcr + WDTDCR); + rzt2h_wdt_wdtdcr_count_ctrl(priv, false); +} - writel(reg & ~WDTDCR_WDTSTOPCTRL, priv->wdtdcr + WDTDCR); +static void rzt2h_wdt_wdtdcr_count_start(struct rzv2h_wdt_priv *priv) +{ + rzt2h_wdt_wdtdcr_count_ctrl(priv, true); } static void rzv2h_wdt_setup(struct watchdog_device *wdev, u16 wdtcr) -- 2.54.0