From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECCE638B143 for ; Thu, 2 Jul 2026 19:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783019810; cv=none; b=hZMg8PIV9KM9gIRN3olKSryrhP2yP3aldMd5RaYilnH4lBSG6IZcdC7yoW05PqBcD8z7YybBCPD5Cgna1WeGNuGBeYi2CCrLRo6/T5rKRAAIRvq+0HtFgLcb9MnMa71e7kSSL6hxQIxPnpUOf3XeWMFPqm3wFxplyas1WHR5LhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783019810; c=relaxed/simple; bh=3CxbwPqElrVMY3KQORr6t7Khky1SWALXlptjv7aCvrk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WVVBnl94i8q2WOP/86+mzprCZxZ0wI58ENDr917SmWkifrvrpDUJQpesU0Ur4wQnqp5G1GtbvrM8kcF6VuVarWUhBRAn3cn94VPr2Sdapc1AqKU/7iDRuKJsKb6RVSZhEfHFy5sOGaoptiHwAGiDB5vzIL7mKJ9EoxLPQM/zXCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=4PeiryTs; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="4PeiryTs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Subject:Cc:To:From:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=vnKcB5Qc5uYgBIQJbJyNv68MQyNqvImhS2o+Y5iALao=; t=1783019809; x=1784229409; b=4PeiryTsO1SncxQAUz6GTByXLVxSt7KX6mzfelgAnFyHsSg7tmsKh5NX4cic02DnmLHGqyzER1g AngtaXP4D8njt++WDoHLJrf0ySGBc9lHT+5mVPFGBaiHfQLE0BDHsSK5d1BHywM/kmCtPkHDR4W2P R4hsziTI/cFNs9Y1OWw7GNTPcryh7kjtVr+OQ6KTkBA2QK/Atk9C+G7SY80/MaHcz1oL0SEGtgOr1 Bx9nbIgaPtKKTCmHfMf7EaxusMlPtV4c0ab+GEa7UnPTHaJSrm3Jha2usNFxvEDoFaUErrjyJ9DwN hFbbXhGoWEO8YRA2RUgIg7Qi9KBmlIzv01EQ==; From: Andreas Kemnade To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, lumag@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Andreas Kemnade Subject: [PATCH RESEND] drm/connector: check if destroy function exist Date: Thu, 2 Jul 2026 21:14:53 +0200 Message-ID: <20260702191453.611070-1-andreas@kemnade.info> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Connectors might have not resources needed to be manually freed. E.g. the drm_bridge_connector does not have such a callback. Fixes: c12907be57b1 ("drm/bridge-connector: switch to using drmm allocations") Signed-off-by: Andreas Kemnade --- drivers/gpu/drm/drm_connector.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 47dc53c4a738..d2dfc6e8f7d0 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -198,7 +198,9 @@ static void drm_connector_free(struct kref *kref) struct drm_device *dev = connector->dev; drm_mode_object_unregister(dev, &connector->base); - connector->funcs->destroy(connector); + + if (connector->funcs->destroy) + connector->funcs->destroy(connector); } void drm_connector_free_work_fn(struct work_struct *work) @@ -216,7 +218,9 @@ void drm_connector_free_work_fn(struct work_struct *work) llist_for_each_entry_safe(connector, n, freed, free_node) { drm_mode_object_unregister(dev, &connector->base); - connector->funcs->destroy(connector); + + if (connector->funcs->destroy) + connector->funcs->destroy(connector); } } -- 2.47.3