From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C800835E952 for ; Thu, 2 Jul 2026 19:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783021548; cv=none; b=rQ+G3NEBTLfm9pWBTBpcbYx+Mj/0czdYdiDDaKn9MpQtL/st1uVq3VUXCe8k/SM0gdw65nxth+QLoudrRF9h75tchh1dP1DEIBrZh2jg3NKNE8OFTZmddmhTzpc+UfGw+mamV2NIJFpBArpKgZsWMEOOVjO3IJMWVyQPUKgI1Jk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783021548; c=relaxed/simple; bh=erupZ8uIlU5nK3JFOVw48Ex7nyIuC22Kq8w7OHo+wls=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QbFILzzBqqH39QVBEcNX1IuFylIG59FTiF9110RmNcEQNmVgST4+KGiGJJnaZ9TE5N+aRpmtKuqbmQxNx1TQobBZ8+gXzuqSi4JSUpqh+qjWm2oML4zVwDaWZJ40bA2GZdORTfndurilxYX/87D2sCebzdEhiQY3KqAl9DmI0VM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JIXJh56N; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JIXJh56N" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c8639a27b8dso184828a12.1 for ; Thu, 02 Jul 2026 12:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783021547; x=1783626347; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cly/nd+WtRjsO5TA3lU7g6oCqpic1LOhtM2jPoyTuQk=; b=JIXJh56NUiDbtt6i2WlI4DYWJDrm4rXVbL/KMSOXRD/IjgKtwBtfBaMBvPi8z8/u1B EiKdSg7bUfz6FRhGVXlLu3K+sVpngTxY0BSr4G0wgw18GdxzxpatQ6U0W9Z/iYqu9mb+ +6Kvl0TACj+mxerVy/Nw3vTRsoyWk/AV0xz7+EWWXEmIATauZOGJ7G3WCEvFlurGlFj8 pzTYKKE9bXxMftweHe2Jm02E2vMWJO+PryCmsbQoYqNrY6H6Ti7BIBz0TXgr1ORi2k6J /iGuu3rjvvNDWKKDlrv4cac2ZkdA2ybG76fVcKLGHVuzw+PNbviJItHwbZBWm/0SpPoT PoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783021547; x=1783626347; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cly/nd+WtRjsO5TA3lU7g6oCqpic1LOhtM2jPoyTuQk=; b=JvzTchN4bo8q6yM0/UC2In8RZUNhbsBLNJKkzYM+cU+GFZnWxQ69ojbjWRV9xPAxdb hiV/SjQZNRCb+DccIobEZbhCVk1kUrwkFp6/SqZcMMC5BIevQ92g5hthXQLuwXM7Srnh pfeVY95DGwTZjk7FIMabrDSOkt3crskzQJBjb/RsjERSzRh2NHJCr4XZxQNactLasSsv 1Mzr4XYPMSSyKpnxl/loD4OS8vJ7xYauM02+9Ro5OtvsenUrtUI+gdMIomP8z2MVqrrg 86r/D9raK+Ec0m1cOMqPRwhKYKqBi1OQHGINePMAfpNLNkksOFeUq2Qmp5IOXkS9C4xi qLfQ== X-Forwarded-Encrypted: i=1; AHgh+RpMImcrSF84rfdkoZCdY6b5Jr0/DGAGTPgWnmKsrnmc4NgVPoCN1kTJ1jY+IPk+89+0Zn45DhWmLF8+txo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt0jUj3seiiU0cj+9MQSc4HwUe1qMmNrkfh3aRbWKDY80JEf4o ftvke/DRKETVl9pzAIaaTBd/794Hg81TWAtbilU02+gLYgb+4G8Yp/b6wbGuDgY+22Q= X-Gm-Gg: AfdE7cngsXPNXX9gPT7Z0Mdyd+f7cz14GZIiXCVBbuZ5h+vJ1uIAf6UEFbZsZ54dzq9 bgX4SkjqnUvNLYfObFyCq9bCZ9AFXYhWKqVoNkUa96EkltAoriuEkFg7ng5CvGtNQr4+DZjG4fS buDxI2gVBJ9LUx0w3QUxG7nQmk7EwaQjRARGbW2m+3XegLlUh0SeWeD8jval1kKxOxspuoGVaoq pWet9+ys4v1QjsWWUmvcKHVzA7ftXAPdHr7mKdSoVjpPEjKAkgbH3cPH/C+GMATjmp0uvwzKL/9 3rmfmLHXPylUrMH0DaEgfmsz1UL4IlNMyjh72E/X4/tIN0DWwutp+L3OWv3MSGrQO7b9Qpd1F4j yaPwtwNT1xT0IXfItug/IYVU01PcizMYBYCiEjNj551XAi21mdIRaDY138DeP34heulEAnVymKC o/SCf6IuUAhn+n5CP2kNXuyU7NF2WHB3DtA2TFWim7+afWQSOBQZbgtgOjeRMwqbi1cSVFDaKa0 ly0oUSYBMOhpSEUfG8N4G0u5ef6glmVDTuK20MN2LRD67KAkhakGLu8BHYnK1z1jAvMwI4SL3ni ArkXlk7AkQCbtHWPneRJLRi36azFXibJsC1fr4w5MY50DIP7 X-Received: by 2002:a17:90b:2791:b0:36d:de94:f31 with SMTP id 98e67ed59e1d1-380aa1f87b9mr4934895a91.7.1783021546906; Thu, 02 Jul 2026 12:45:46 -0700 (PDT) Received: from midnightair ([2401:4900:1c94:62e8:bc10:77d0:2fda:415d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b85de12sm12578844eec.12.2026.07.02.12.45.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Jul 2026 12:45:46 -0700 (PDT) From: Anas Khan To: Lyude Paul , Danilo Krummrich Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anas Khan Subject: [PATCH] drm/nouveau/therm: remove unreachable fan update branch Date: Fri, 3 Jul 2026 01:15:40 +0530 Message-ID: <20260702194540.65127-1-anxkhn28@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fan re-scheduling logic sits inside an "if (target != duty)" block, so by the time the inner if/else-if chain runs, duty can never equal target. The "else if (duty == target)" branch is therefore dead code and has been since it was introduced. Drop it; the two reachable cases (duty > target and duty < target) are unchanged, so behaviour is identical. Signed-off-by: Anas Khan --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c index f8fa43c8a7d2..c4aaf7473065 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c @@ -90,8 +90,6 @@ nvkm_fan_update(struct nvkm_fan *fan, bool immediate, int target) if (duty > target) delay = slow_down_period; - else if (duty == target) - delay = min(bump_period, slow_down_period) ; else delay = bump_period; -- 2.54.0