From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3971A381E9E for ; Thu, 2 Jul 2026 19:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783021554; cv=none; b=cFO6m0+LQZ8ZAw5NXiteOgV0qrN+s/05R4gDiJBdnuoAkJM4eA0dQZhf6FS+0XyseckVyFK3ZvAOr55FdNRJux+Lo+1fa3Y6NMXO+urcPV52KXXzCvJ6W7z1SKvL7SD4/WMJQseAsg/T/a3h3JD8YVZ1fCSAdqf10c1V+lScA5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783021554; c=relaxed/simple; bh=96R+dqTFUhu0YQqrwTO0lWE2ZIKS8EoxJG1QDxaRHPQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uZ+3csPpPHtWCJVP2Whw/MOhU9BQwtEYa+13ZBhjpNU6dKzIdH7hfGhjiQL5y0PpN2bxjN6io3WZhF3NJQ1YODFwTKSgf9q7Zx3qhKMdWidRnWNkcE22AybLUI/89n+Jvl8L5+8r7oUnJfWR5jNXO2ap4RLdZVDXmvNEBCc1L/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pd7Vy0P6; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pd7Vy0P6" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-37fa897003bso261594a91.0 for ; Thu, 02 Jul 2026 12:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783021552; x=1783626352; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HmFAvR8guIfdAWaMYmy29nfa5JiNK3bajaG4EyInvGM=; b=pd7Vy0P6KggSuyN+aDr6JsaxGOCv1PzzgTkuI0KUk2sSLKF4G9bTgEoSGgOFLxcjth v6TCX/I1Ef0KTPTV2CrRdLPt06XxONx/m9DjawVMYZ8Fc+m2cc/R/vDPsmULi1OVVJGx yFv+mygfY1414VTmzu/zWl1WkMDFa56ZGG6uWs5FDKM+s08KeaIWepFTC5/3zEdij2+r sJLx9GrkcFDbM1Z9laHvnY7nGAssLplnfs/qmGTyo/W7fvpwR/MpzSqiw3f1+UA3A4hq wV0e6i6HFTDT/3YVVfuidFhgjMCpA89nAhCQq2zJA3ChA/iL3OdipPccKwZcf08L74xT Cg4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783021552; x=1783626352; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HmFAvR8guIfdAWaMYmy29nfa5JiNK3bajaG4EyInvGM=; b=lf9/++9Q6CKf6aOYQ0jcKuucLuaAXjP66Vn0Dnh1Y8QZ7pHPLeZVpAWDJmti8SpVu2 aEKlVWfECZp2wMhF2/V3Ytsu0HV/6z3mSu6N1UoY8jSflH0H7vdTz+PGmiAMxhO6rdJ+ Gh+TgNPr07gK1SV1JLMTlJ0PM7fZfgE+EwFtooncIX9PWoi+wdWmovMnZTPRyGmW5t75 GGtN4jbk4bITf1guIGHffL/su6YKs8SsL2To94HNYAcNvYS3JAeW3z5PN74J54YjKGZN wmxE88lyKcfR4geBh9l5yvrW8rmh0TG3ZrnziZ8RTSw04+tcYgkl5uxRFR7J0HrqDAXx vi6A== X-Forwarded-Encrypted: i=1; AHgh+Rrd+loqSQAdrehGaSGMV7enCIqA3BuWITGPn3zjfUOWbcbHEcs+FRtxGOb1bKXNYigwp1qFvVpX0loH4qw=@vger.kernel.org X-Gm-Message-State: AOJu0YxL+Z2HmQJfXIb/AN4jlu8nu0aTHH1UGymbr8be6ch+UWsjyRNW lKbye04TfJdktmQlOk+2Hh5jsJKVgIdc1EsHHEoOx4E1KWh97dtfOLyc X-Gm-Gg: AfdE7cnJ7ummnNmmf4DZXBvyi/SxqS4NSB8dEVH30HG4pvdcbYHghE+1TH1O3zGF5V/ cw4/RRJpMaIqmLnfkHYHonWJq8VJ9TQiwUA9vYJ9Jzhi/aSzyJkZkr0E6xfNVF2v64YSFqBqRm9 5BRKsTJEibpD3j6sX6zG8O8HNpQ2XNF9gBcqApVvArfY0i3tvMnfHaNtaWx5HPuc0+gUagUZ3Fm 4ZDuE/QOr+ZVfVEG6WQqCOpR3USCX7u3zwRehkXCkE0kDX6omoQmEysAnvRvXaMpjFhfy75+PVH CFkl6MwdUKkcdGG36jrUOLJP4zz/5vUisuVrXviZUlCZ36/0I5o+FP5EVVb3lWhBOK57jjPfLg1 bMZVWD2gmL9QFyzObpX1xgbaDjCxVwOGw5C1M4NfuNAJ31fWN0rEQmwqXmfYuKu37NP5VBjHj5l J1Dd9dXQ8N3/6/nu/cYvTH9pokQXiXo/IvnmeWex4KmWlp6KoQV3gZkg/vrXJ8ctLB/zdNwEw6w J51aePenDADNYf15I2idQr82MK5dAPa8aRNbAZ4UlUvdJs4z9shM94PRttK6G2qsItgLpbYfVFU vnZjf2bVbJ7VsNNz8ehM7ZHddFN7G+zjnVcRaA== X-Received: by 2002:a17:90b:258c:b0:37d:f70f:fbf8 with SMTP id 98e67ed59e1d1-380a9e471dcmr5048021a91.0.1783021552332; Thu, 02 Jul 2026 12:45:52 -0700 (PDT) Received: from midnightair ([2401:4900:1c94:62e8:bc10:77d0:2fda:415d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bbd2362sm12951932eec.20.2026.07.02.12.45.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Jul 2026 12:45:52 -0700 (PDT) From: Anas Khan To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Anas Khan Subject: [PATCH] power: supply: bq256xx: drop always-true inner condition Date: Fri, 3 Jul 2026 01:15:47 +0530 Message-ID: <20260702194547.65209-1-anxkhn28@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In bq256xx_array_parse() the inner "if (val < array[i])" repeats the second half of the enclosing "if (val > array[i - 1] && val < array[i])", so it is always true and the "else return i" arm is dead code. The function performs a round-down table lookup, so returning i - 1 for a value that falls strictly between two entries is the intended result. Collapse the redundant branch into a single "return i - 1;"; no functional change. Signed-off-by: Anas Khan --- drivers/power/supply/bq256xx_charger.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c index 5a6634fde837..e5042582da16 100644 --- a/drivers/power/supply/bq256xx_charger.c +++ b/drivers/power/supply/bq256xx_charger.c @@ -347,12 +347,8 @@ static int bq256xx_array_parse(int array_size, int val, const int array[]) if (val == array[i]) return i; - if (val > array[i - 1] && val < array[i]) { - if (val < array[i]) - return i - 1; - else - return i; - } + if (val > array[i - 1] && val < array[i]) + return i - 1; } return -EINVAL; } -- 2.54.0