From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F153380FE0 for ; Thu, 2 Jul 2026 21:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783029479; cv=none; b=JHy/iXxcSdEUr13hub+0W/PlZ4tVqfWb9QkqalalTTlAI5MKCX/DNXSXqszr6vELOxnDTg+q58CdQYTVqwZuzJOQOD5smddsA7AoGBhCsJ0+2Bm6Nh4oFiANUmh4GYnbEAcQ/uOtB9qUkNJu6/4nUCRkgYMYuj6oAmbGQXMyLlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783029479; c=relaxed/simple; bh=+VmbVWrwyPkN3Aij1Wcnx0t8r4sOdPlsrLlelAP65Mg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jXll3RO9OcsHk+cAktuJlGAtDnXomHRfaSwjzF58zgII/oZyMikRoPrUPBihTQ6Iv9yVAEmeghaRBUn2hT/jOtY9soXJYiaBO+lz7mOc1CGJrrNdc6tpjRuGJVR6JZW5ZGTu+F5dTtFGNibU6eLsTcFaUlyfdqHaF92GZUnnbyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YwCOGpb+; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YwCOGpb+" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8f186025973so22143536d6.0 for ; Thu, 02 Jul 2026 14:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783029477; x=1783634277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sfTpGCk66nEi+jBlcUzhvnJn+dQL+K/hjUh9Dv7Y1Vw=; b=YwCOGpb+P+KXwNpmEncZ44B35B0AWWeo/zzU6N+xVP5CNAyCMn1fW9QDI9MaZPZUmF bhZtPcCXN1hdMNFxXmMBHSBRBxuwbhYRB41Y3MjGz2DuuBDnMPIkKgpJlJa9KbKpWISk ncknkQHFzAlrukYfPckztAWCZe99fiIg8/JQY7qYnltS6D5VwKd3jBbuihVOUM0WMbzx FYbTlweRHQdeHx/jCRAk+CQXDdNklqsZNf5U6r0N5QHe4B9Mp3co5Ut1mwcCZcuGhJ1x Oebh/7gvjXlLCxaB2Gbo8k3OgdXxwVruExdOBkZ4+2gt8+/qGcZ5IvZt/ZBpoPq8zpmF wGcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783029477; x=1783634277; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sfTpGCk66nEi+jBlcUzhvnJn+dQL+K/hjUh9Dv7Y1Vw=; b=LAHA5aEndVyQ+T61qdmXmMYo6vRziA16AO5DmMLC6tLMqFgvG5JeyA1CfIQaKwUMgj uC8OTIVYHzucbWc2nN3dXO3S35Vg5JVPHaRkQYMYWnBe81cSmgiNm5e18rV3zEME+Ruj Yuow56gNsodSYrb12HLzLFVVtLzbCR/LMvGcKXdYJ2sbmpIXOZtEG6BJT+uoziTlfLOX g4jrNjwr44z78xZ0KP99gxUGREKZ+qK1xJwZV3cvrUe5J5xPu02StztBUwe5kvunDiI0 gx7Y1YFi48wabseR1uMAoQUuSCL7SvJ/YpwHIXCp+SArZTLla505Dp8GmiX2sfLNP65N aHlA== X-Forwarded-Encrypted: i=1; AHgh+RqvlLTTLEOg9NiiwaB0TbP9VZ3lYrq16B3qo18Li333MXWDUh6+3qX49wHp0foaEUka0w0uKjTwgNkpdP8=@vger.kernel.org X-Gm-Message-State: AOJu0YxuGY54hkNKpH1zxdH1zVlCUa+owaZp6QjvQyiNkQpL8CfOfjw1 O9TJ4rKJvfgcD2UN0XJ85bMndxDyJEDvtmz0QVBWEhhjyDeA+jzS93tuGwlw9vvnqAQ= X-Gm-Gg: AfdE7cl0cvGCzjgErzJom2OvUMtXb0CvnszjN1TsISMBF5jciS7BglTS2wOtAeDnNtU Zvc5hRhUDiPmQ41zHd52fdmkcMt032xiCiODIXFC4LJgA9fxSyiSuMp6QNSrVFX0i+yLuXPUE2C fkXjIVA1vcGO+F3UnQ3Mbi1Ua1DC1RRVVUOxufaX1LLqr7LgQHs5OwZRa1c9S35suh8BAsXIMb3 JbX1ak/CLEbyCyid4He/73u9Vazv2QuUTXBLNleFyKg28EnxRu9UxjTBkVyqUIxNdSjnANJ5+uN CvvkpmSBB5jVikYw3foU7wVHvC4EVHcoTjQugOgA6sa3LweEi0LvZW4cS8U8eUpMvfYMenM7qj5 N3DxqVxtWmEiwU6xMdy8MvM8Ua07s+Ni3nQ7UYMInQXtK8nbSvIbphtK7yc8rxqUDQ1gqjASKIl AaSu8lJYGC5p7hmroauzp/oPAZBRTlb5zwgEVrkgncvUnoU/ombay+RwXla8u8dNPO9XnBlFYDf oeUCVfE9Yb6dNRAyj1h+iFayw== X-Received: by 2002:a05:6214:d87:b0:8f4:b652:6642 with SMTP id 6a1803df08f44-8f4b6526772mr64026586d6.46.1783029477240; Thu, 02 Jul 2026 14:57:57 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f46ea3ff80sm37863396d6.15.2026.07.02.14.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 14:57:36 -0700 (PDT) From: Yuho Choi To: John Stultz , Thomas Gleixner Cc: Stephen Boyd , linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] clocksource: Unregister subsystem on device registration failure Date: Thu, 2 Jul 2026 17:57:33 -0400 Message-ID: <20260702215733.84588-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit init_clocksource_sysfs() registers the clocksource subsystem before registering the clocksource device. If device_register() fails, the function returns the error while leaving the subsystem registered. Unregister the clocksource subsystem on that failure path so the successful subsystem registration is unwound before returning. Fixes: d369a5d8fc70 ("clocksource: convert sysdev_class to a regular subsystem") Signed-off-by: Yuho Choi --- kernel/time/clocksource.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index e48c4d379a7c..5a786b3c778c 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -1566,8 +1566,12 @@ static int __init init_clocksource_sysfs(void) { int error = subsys_system_register(&clocksource_subsys, NULL); - if (!error) - error = device_register(&device_clocksource); + if (error) + return error; + + error = device_register(&device_clocksource); + if (error) + bus_unregister(&clocksource_subsys); return error; } -- 2.43.0