From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FCA39F19F for ; Thu, 2 Jul 2026 23:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783035571; cv=none; b=IVpq7ByFHhMm5rTPCMcNRYwGQHh/D3+7aHQQYPiCW0CzZErPk9Kt6Bu3yAPNGu/euF/QAPCjE6kmhfcz6djrqMIaoghHBi4aa6vqPkMx7liCO9Yf6KmJ7j2KARzulWzo4j1Ly7stMv/diDnGjGp9NfZj6QgHGmkO17ZMS1siDtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783035571; c=relaxed/simple; bh=RMNYY3fjjV69/m+j/rX8VNshnfJkZr46jhy+RJtWjw4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OFBvBlvwy39sTnnP28m0PSTZbUSKw/+oSHSziufUle4aLhQZAkXaC0zFEnMbzM2O3fqdAWHfMWgDMhjzanxkT4++BhALAGvFILT6sZd0trpIBMDfhouZ7dZH/RFKqLUFED+GnpR8PWuLzgZrccm/meFJNdIb5PelrXWHrnFNNZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XxdsEtnh; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XxdsEtnh" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-92e85499ffbso377985a.0 for ; Thu, 02 Jul 2026 16:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783035568; x=1783640368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=WNKDryeWnXSKKY8fUHk6zFjL8w+dDzKefQJ/uzoOjJU=; b=XxdsEtnh7Twxz798rYThkEQGzUeQ+dfJZenTFyKgm0ZuClEDdwTOVNzR8PcjgX4H5c ny8udbwDVeAFeY+tT2I9soLbsAB4cqmGaDaaTR54i7BnM93GKGJRVT32p7euwbfivGVl x0IDmBtDe9p103y5ZWBorI1b52Nkm5fpBijKpslht5HLNdTurQzZJ9+4TCyYRBLS/z75 r9pMSn26JoX0Ls4TiAsiOZ/2I9YEk78IqnAUxlHDy6bFGw/eH+owtsmTY4n6vVFv2z0b zPqlU3nxd6xxcCn9ag9PnHfrM39KEDpDOATPMYpD3ZJxvWSKzRyweNdG48PkVER/6cuq mJpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783035568; x=1783640368; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WNKDryeWnXSKKY8fUHk6zFjL8w+dDzKefQJ/uzoOjJU=; b=gd1BCvn7M1sosNtY31zzXlkXXfr4MHkjkkyS+AeZDzTUMUKWdrTMpnVtuZxKzySY4W B27b5qnw4HrirYPqUBr+1kkoKGTSnk7HsMW0UNY4G0Z8alkYG+vZnZaSL0xnUrwsoXRM NYHcSgwO1eTUTorssUSiZc8yja44guLrb6B7vC/z8/5iskxeOGmuUJBj3P2EeALcNWyS +br1Sf2aE3L8HMpqRDm2VGQ0ZD6W3asfw6GNC6Fo8BrO8VX5lqbAUZEp2EKWnnMaBhLt qboIFWsOd+XaX+BxTp4WciXChZin4dC8cf6UAK+emr4NIrzp4ExCGdNwOLbnvmWFChMU iPSA== X-Forwarded-Encrypted: i=1; AFNElJ/UHyI1QQfAX6vO+6XbTbGWgoyQIvuZ71X6anUreHa9oAJVC9RKpmmXefEUXPdxb+adnahB5YlDuX9lLGQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzTOZZOjswXdwi4jAMBj4LLxXRTDRpT3kAzHtA6zwQcf11sI03b u+Ttq8nxkW8Yy4+tAhCBpBbbbT0K2ICv4guYZI24wIIntoh84T0L023Z X-Gm-Gg: AfdE7ckEYnZ8jNivdFeaaOH1wajqkPT6ufwXnh/iqEViocyOEp9YKHFZMaTz8oB/FpF VnI5LywrxSszN1L2ZardMaWc6+rjKiYD1Y62MeeEh9Od5MKW+YW00hSK8IPAT31n7qF49/qZxfo G1JBhhKV16L+cVkPkh0cZ2QKCL/tul24Rpfut75w0Z9sC/An2xRM589Mj3GxVRaDo6EA4yVhzFB NNeD92dpAFAX//wEK1KkYTRXlG4HKRNdrFh+kmj53zvQ41/umzHG0in7LreqyZeZEQsgTk4OFdG XZGsV8b/PpHAYZFGgiqKNe07ipoyOpP/r7/6v7qq9n4o8p4N5G2MMv/mbahZXL5k58ThLWPU0gE +kx0/xukFmVtRCyl8mrKLTVyJCh5PaSsnK/82uG9x7r7yiNtIFx1lufzgSnuGP0ZPDYeSVTRZl1 MDHlR1xjSljb1M7+jniWtCVWCm5G9cXRmL+UjlJorcbjpUDUdrPhMvPSuB1seskRqN9ND4cU/bT hPyhzo3q69TGJw= X-Received: by 2002:a05:620a:4628:b0:92e:5cfd:154e with SMTP id af79cd13be357-92e7afb156emr1054949485a.14.1783035567540; Thu, 02 Jul 2026 16:39:27 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f46e84e1casm42310676d6.11.2026.07.02.16.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 16:39:27 -0700 (PDT) From: Yuho Choi To: Olivia Mackall , Herbert Xu Cc: Alexander Sverdlin , Nishanth Menon , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] hwrng: ks-sa: Fix runtime PM cleanup on registration failure Date: Thu, 2 Jul 2026 19:39:21 -0400 Message-ID: <20260702233921.100478-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ks_sa_rng_probe() enables runtime PM and resumes the device before registering the hwrng. If devm_hwrng_register() fails, probe returns without dropping the runtime PM usage count or disabling runtime PM. Unwind the runtime PM state on the registration failure path, matching the cleanup done by remove(). Fixes: e9009fb227fa ("hwrng: ks-sa - Use pm_runtime_resume_and_get() to replace open coding") Signed-off-by: Yuho Choi --- drivers/char/hw_random/ks-sa-rng.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c index 9e408144a10c..4494f1e4ab4d 100644 --- a/drivers/char/hw_random/ks-sa-rng.c +++ b/drivers/char/hw_random/ks-sa-rng.c @@ -242,7 +242,14 @@ static int ks_sa_rng_probe(struct platform_device *pdev) return dev_err_probe(dev, ret, "Failed to enable SA power-domain\n"); } - return devm_hwrng_register(&pdev->dev, &ks_sa_rng->rng); + ret = devm_hwrng_register(dev, &ks_sa_rng->rng); + if (ret) { + pm_runtime_put_sync(dev); + pm_runtime_disable(dev); + return ret; + } + + return 0; } static void ks_sa_rng_remove(struct platform_device *pdev) -- 2.43.0