From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46FED3921CD for ; Sat, 4 Jul 2026 05:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144688; cv=none; b=ujMJNy/1b6H6922LG3wwzxw36kZ1BrNIc4u3BZMxDuXy24snPyL2AZesi8HB9ctqeUdQnxzzKCejn3kJDof8kcYoU2GgmaASETDBww4Rlm+7NoQ3yKEERrT1Xkm7xy52nXLf/0V9GtCwWYOih+WdKcOa43OKvB2UVZsUy0Qx2wA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144688; c=relaxed/simple; bh=apjEFUKjRBYrK4iX2Kg45dCDEie0ZHB8HqcgRhupms0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cnpAqveuNgXbtyz2gH0i8puyvOwIyMQTKa5k0NE1gC/GxPq8Yg+oNyOF9PXh1BNdtIiuj0zX+yBOr8QRc90jOjR+ckP5YvBz06FU76rC0/+1vSYolj6UnuvQB/gKhmMpJRh445LfTCKz3dA1KMKxJSq9xG1w4MDClbHFB6l3MYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YKlPgZ6c; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YKlPgZ6c" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-37f816d01e3so1293215a91.2 for ; Fri, 03 Jul 2026 22:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783144686; x=1783749486; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EtRA/Iz7xW+gdF1+FPWoWbYlNNq+Ml51Iu6T+Ii+D0A=; b=YKlPgZ6cqpF8rzc1ezjm8eCWjHv7dbCEE300+iGaKGf2bbUCAgMWGgLoZOuLC611St ySAvyK1Xp3d2uMntCSaTvP0YtTf3E68gvnMoy7542rBk/33z1iod0yQFGp25YPhwZVZQ a/lYFH+ZwSCkF3+3idAr/bQ99wEK0/XL4pCyl875uqy6bSQ19ZoCOKzcTMmGcroz+QV6 dAyNqZfvi8DSCx6mkcso29iMt/U1fPr1t2QQqMo/k1rQEUS3peguPLDTkra13H45Mskv g6cf/UMmXw1Qe9ZcrODcZA/o3srioIJrV200a1ZQBPt5+bVf77CQ8EDC0UyDlV3wXmaR 69Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783144686; x=1783749486; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EtRA/Iz7xW+gdF1+FPWoWbYlNNq+Ml51Iu6T+Ii+D0A=; b=YG3AXqiZsz3WTTxPLhMGhxS4VGNvTiqPoiFoXjAobNuE9zBsP+q5Qqs+SUdAqjpPy5 fLJpK7bh2EplCl1FHwLGkdu8VbFUmyuL0UYiulTbjlS3mUXQdBDjylsVNDj9qKr76PtU SbvPz2f24XL6ZXlLby+MbuAXhhE44grus3zqtjM7FfF+dm6o79jiQWM6iYamLBvQ+rF1 BRq3JV+XH5mm7b+UJfP+ADJdUARFn7qHHKsnNDSCZHG/0l0NjGTfhXEMLlpR0BiE+DP7 irdcSAtohSCmhyuCHAP6E0mVJ2o7/6cBxpXqmxpkgFy5B8gdi59QiWn/zgPErzFZak0T /3Zw== X-Forwarded-Encrypted: i=1; AHgh+Rr5yCnETszdEs6/KSdQbS09RHd1LrcbmxSFkWUf8Ha4NKH47PpQBJyQ/yl9tO160PXt6juBrEwyTsKABMc=@vger.kernel.org X-Gm-Message-State: AOJu0YxgTtzYED9jxG1rQo/HlxtUj3NDZxddVqYsaX2xrd3BPKiSGo9j 7nfEYNJu/dn69qBMM1UJQFuORzPhkd+Tp6I+ENe/iH8p3wUh058v94+zV+KeSQ== X-Gm-Gg: AfdE7cm+60Atg88H/bwIPMUDoKyxbNXLZFZICpMsKzk5SFok7EIzh8ySWdQyI6Ig7oT GU28aKDTDKxPjhbWjVKOygfewwh3CHX/rH54JmCwmvS93e+05raFLLfn/NA9816ya6swcicS5ts Tj9y9B0xQDOtxdt0WM+O4mb8sgwNF1hBMByBq+zj8CqO+OyPR81Q/oAGcIUUIPUMKIx8IDlwOT9 DfRoVlQP8i05djlDCXyMxegArqrL9VGCBPazjOhutpYjhpmsjXQ717TXKzbKJb5QoFZYKFCpFFL zz4LKdh7mZaqHkoZDx0G1QCqFKmRQCBClKAkVml7tLz3WeZcYZrVOcDLbPtpFpMPFuDBz+P73y+ 8QZW5wn7ISYDe+KzfeB4fd+vPs838bc28yElebzttYd6FDFr7PH7mHNPDoDZLhoL70rNWR5r+hK BnJmZZgvkcS3KNBenUzpv1jc2aV35E+J9VAmABimBV3/Vvw0gCgpAXQWm+D+2dFyMrUoVS41YnT DU= X-Received: by 2002:a17:90b:3f8b:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-38281185463mr2376208a91.14.1783144686491; Fri, 03 Jul 2026 22:58:06 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:880:86f9:3b00:6746]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b813cd9sm26262412eec.8.2026.07.03.22.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 22:58:05 -0700 (PDT) From: Dmitry Torokhov Date: Fri, 03 Jul 2026 22:57:43 -0700 Subject: [PATCH 20/26] Input: maple_keyb - convert to devm Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260703-b4-maple-cleanup-v1-20-41e424964da5@gmail.com> References: <20260703-b4-maple-cleanup-v1-0-41e424964da5@gmail.com> In-Reply-To: <20260703-b4-maple-cleanup-v1-0-41e424964da5@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz Cc: Florian Fuchs , Adrian McMenamin , linux-kernel@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org, linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org X-Mailer: b4 0.16-dev-6911d Convert the driver to use managed resources to simplify resource lifecycle management. This eliminates manual error handling in probe() and removes manual input device unregistration and memory freeing from remove(). Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/maple_keyb.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_keyb.c index aa9a4a80e26f..bd4ce803a13e 100644 --- a/drivers/input/keyboard/maple_keyb.c +++ b/drivers/input/keyboard/maple_keyb.c @@ -155,17 +155,13 @@ static int probe_maple_kbd(struct maple_device *mdev) struct dc_kbd *kbd; struct input_dev *idev; - kbd = kzalloc_obj(*kbd); - if (!kbd) { - error = -ENOMEM; - goto fail; - } + kbd = devm_kzalloc(&mdev->dev, sizeof(*kbd), GFP_KERNEL); + if (!kbd) + return -ENOMEM; - idev = input_allocate_device(); - if (!idev) { - error = -ENOMEM; - goto fail_idev_alloc; - } + idev = devm_input_allocate_device(&mdev->dev); + if (!idev) + return -ENOMEM; kbd->dev = idev; memcpy(kbd->keycode, dc_kbd_keycode, sizeof(kbd->keycode)); @@ -179,7 +175,6 @@ static int probe_maple_kbd(struct maple_device *mdev) idev->keycodesize = sizeof(unsigned short); idev->keycodemax = ARRAY_SIZE(kbd->keycode); idev->id.bustype = BUS_HOST; - idev->dev.parent = &mdev->dev; idev->open = dc_kbd_open; idev->close = dc_kbd_close; @@ -191,15 +186,9 @@ static int probe_maple_kbd(struct maple_device *mdev) error = input_register_device(idev); if (error) - goto fail_register; - return error; - -fail_register: - input_free_device(idev); -fail_idev_alloc: - kfree(kbd); -fail: - return error; + return error; + + return 0; } -- 2.55.0.rc0.799.gd6f94ed593-goog