From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F32FD3939DA for ; Sat, 4 Jul 2026 05:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144690; cv=none; b=GdbrrPVmDcKmtEEdknvNHfbrOcdzi3JgtLxpUN+9WBsj7GIv48NY0I6D7qGVAUBN1hRT+JpzB78YLvprp1YQVWg+TE0l644SGVGiGr4z4T62Ffm4RCdIGZ52VaI9qmNBDN/WTj5wjobCc8ISLvrcZ1H4FCuNgn+ktaPuvpvkX0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144690; c=relaxed/simple; bh=x+qjLATprHWVETyBtguIFSzJzAIa57zeTCo+KlBh1GU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Vq+fOW1v4xU6y8Wdc0lLTeXmMr4WSSPp0AjMj+qmGRDxCbUKh2x51KnPTy4IYitPhPGiJgUT3UB8uHXWgfUWEs/7VLvKktSx6CYVhLdFOInghWmbiBUOF+eDcJxi06x0HLNHxd+bWE5eaHz7HY58/DAyuzci0nWoaMbjDLKZCGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hqUKsabw; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hqUKsabw" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3811074a8c5so885776a91.1 for ; Fri, 03 Jul 2026 22:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783144688; x=1783749488; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LjRXENzhFdJSLRiM6d5V3++2rjRXfCmisZIqwmSzJyg=; b=hqUKsabwulssajAcE2+cEgHwYIE9nSin9/+Mx+zD85wAbYUVWWRN3V0unhVqiK3Lds QNSulPD8BsFnXyk86M8gYLWW8udBnWTTvLbCLAgZHuoksGqQR0op0/PRuiUB4A11Q5MV FywMe/8EHZmlpS57EtE7s013BfqjCnZBggCu8nB54mdza/D0eqbjf4DCRiBlNW4B1mpo GcejxH3HnLzGmqEd5LC18flJDrm13TPl0mTzi5WjOGjXvvx9jUMsmt6y9VRWDaCJwhfW IKiPtiglm4W/uTnVXRVrirOlROQ0Fy8zRZ8krNSSMLdG+rWEVxLpXuM5+m3kM2+OtQr5 87hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783144688; x=1783749488; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LjRXENzhFdJSLRiM6d5V3++2rjRXfCmisZIqwmSzJyg=; b=paSD/thCBkptDAE3CIeoPocuqlR9337stYgmubQ6YztcLgfdv3T2n29i58/jh9H6az 4KuvmvZmUuX1RBrXMGKnYCqOmCyvHP3BATPyjFBaUlNNJ4v8xl8sPEOg2DAzvmK+oXnY T6cdasM395uBrCjIFT4g6MADrlJMSvo3IaHY8HEjfpWEeT+UDm9pjm2Nq3K7qgJuRRmm Y+DETHC91ukJUNhEqdKZz9prlxVh74wKQpL5aq0LHg0pRD78x/sgaFZqbvQGODbdMbAQ XKgdvY1hyyBXQx/f58PT6qMyZtOhSQBFxCGWnPVBETFA5hKet4Iy1UJ9I99St4YcRbAd 0EAw== X-Forwarded-Encrypted: i=1; AHgh+RocNiKlUNgZSgv0qL3yiuEnNEm2Is/7WrFvx0akDGdKrxAxSERZXWk2rJmbN1DW6Vu/MfY9PtlbFCK336c=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ1BaESDdQekP/XAyxlFp/XSb9YDPvU0l4JYBWEs5D10AFOAMR u6lFGGxB6Rq4tZH8PMdDq6Fu0sVd538mxdypuQvuyxfUK9ewDmXm8jLCEIrXUQ== X-Gm-Gg: AfdE7ckd5D10BwlotixFSCesNmsJhbgf6fB0WSgSK8yvLoaXTjd0S25V/ZZytejBFiJ VI/osgErwoXWzql6thnb18RNuVJbhGsq8qhLL6iZ8WS0+2foWKM60bmAH4dIDt1pqpJ+CL6N3UD Ie8T1Y1w2muM2356y5PPotADxPiTcNf9mt5eEnT0/8+rRv/qwInaH0xVV9pUAQ51a4ORrSWaFEF qq77vNreUh4ffFfnoaXBN5Vj4UMVI3Nh1h2sBA873NNxyPRLGnU2gEKjg+aN6hER1FrvAVv/R7b EKpQEEHsIML2VqKXzTeIMBoRS5aZXZ5X4JTEGyOocqZViYY+MXJpzF+ihAGLImgY0pyJFFqt3sE k9KLZsF8Z04/rTkqA8TYH4m6zPgnrUDj612ZaWa3D70OrWaaF0HuEQyj/me+UvHZ3xniTs/zxuR IGdzUgemfAa4z9FgZwoCurHHGJNZH9BeVki5zQyypK49WwVPkesQoFRJXvI1OMsrvtaQDXsX6oa tA= X-Received: by 2002:a17:90b:2c8e:b0:37f:464d:ea38 with SMTP id 98e67ed59e1d1-3825c50c2ccmr2400537a91.0.1783144688130; Fri, 03 Jul 2026 22:58:08 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:880:86f9:3b00:6746]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b813cd9sm26262412eec.8.2026.07.03.22.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 22:58:07 -0700 (PDT) From: Dmitry Torokhov Date: Fri, 03 Jul 2026 22:57:44 -0700 Subject: [PATCH 21/26] Input: maplemouse - convert to devm Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260703-b4-maple-cleanup-v1-21-41e424964da5@gmail.com> References: <20260703-b4-maple-cleanup-v1-0-41e424964da5@gmail.com> In-Reply-To: <20260703-b4-maple-cleanup-v1-0-41e424964da5@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz Cc: Florian Fuchs , Adrian McMenamin , linux-kernel@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org, linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org X-Mailer: b4 0.16-dev-6911d Convert the driver to use managed resources to simplify resource lifecycle management. This eliminates manual error handling in probe() and allows removing the remove() callback entirely, as all cleanup is handled automatically. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- drivers/input/mouse/maplemouse.c | 37 +++++++++---------------------------- 1 file changed, 9 insertions(+), 28 deletions(-) diff --git a/drivers/input/mouse/maplemouse.c b/drivers/input/mouse/maplemouse.c index 03cb666d278d..7842bd46c9a1 100644 --- a/drivers/input/mouse/maplemouse.c +++ b/drivers/input/mouse/maplemouse.c @@ -70,17 +70,13 @@ static int probe_maple_mouse(struct maple_device *mdev) struct input_dev *input_dev; struct dc_mouse *mse; - mse = kzalloc_obj(*mse); - if (!mse) { - error = -ENOMEM; - goto fail; - } - - input_dev = input_allocate_device(); - if (!input_dev) { - error = -ENOMEM; - goto fail_nomem; - } + mse = devm_kzalloc(&mdev->dev, sizeof(*mse), GFP_KERNEL); + if (!mse) + return -ENOMEM; + + input_dev = devm_input_allocate_device(&mdev->dev); + if (!input_dev) + return -ENOMEM; mse->dev = input_dev; mse->mdev = mdev; @@ -99,29 +95,14 @@ static int probe_maple_mouse(struct maple_device *mdev) input_dev->id.bustype = BUS_HOST; error = input_register_device(input_dev); if (error) - goto fail_register; - return error; - -fail_register: - input_free_device(input_dev); -fail_nomem: - kfree(mse); -fail: - return error; -} + return error; -static void remove_maple_mouse(struct maple_device *mdev) -{ - struct dc_mouse *mse = maple_get_drvdata(mdev); - - input_unregister_device(mse->dev); - kfree(mse); + return 0; } static struct maple_driver dc_mouse_driver = { .function = MAPLE_FUNC_MOUSE, .probe = probe_maple_mouse, - .remove = remove_maple_mouse, .drv = { .name = "Dreamcast_mouse", }, -- 2.55.0.rc0.799.gd6f94ed593-goog