From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ABEE34403A for ; Fri, 3 Jul 2026 05:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783056672; cv=none; b=jxTPnbsOHeE9dYbOg221CH5tdSapfvzh7cq11ZZwp8v60C/U4Mg6EHxDI5FN/Sq4QcDbON3wkyCyzhxN7O7BNFXXoSIA446+qov0eWwX1+3ZL5/H270VPHHJHLUNtimzAt5WZrNfMl6l3zNe+Aa/KHvRYkX2OhaH5o3nx94oW4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783056672; c=relaxed/simple; bh=EVsd5R4n8qmiKpGB31F1gBRP9ljOAI6TBo2L1w5GtRg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IAq0NZ8BZP7WaMcLv3jnU3tXBSmlPIWCuy9CGcj6mUIaNxi0N1M4JiMu4JhaEjwWzCNLBulvnT+aWDALDaAihAC0ogshYeri8cvlOlFsMu/eHHaC8p5teywWFDK4Rr6SBRJQsbgh7uM4iKfP11FUAJToYJE2QFL1ItqCvF+doI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gm5FA8Dk; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gm5FA8Dk" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-51c2808dbc3so1321151cf.1 for ; Thu, 02 Jul 2026 22:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783056662; x=1783661462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yqInNBGyRxbMZkLQX5g1lE2UKQnsvWWdzJYoQnv3Yuk=; b=Gm5FA8Dkp6Cbg0g1f5JjgBDkzUvMHMg3N1b4I6fLWZb6lAdZe0LGbCY6lHBASGCjRZ GGshIQemOoO6D3wHYrc2BQp44bYb6kbyeXkiPpW8Z2bGNwbCFhr5pz6PdDlC/tEydRQ/ FG+QqC2N9W2KWs5kL2lUnXppjYHCYV6+3mUufR5am0vHzUgSUZTt7ZCKQS5gWBeEDUs3 w0vmxwxknFixY1ZUHu06psq32x7hNBXEH/e/OpqxpPs4NjR5Z5at0xhO8dJmnTYZAOa0 gQTPdzNX07JHXBwiqigfvHHhseurr516PoHCHiwr1yXOsCXvtWyph5+5PiqQTqv2IFDR pazA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783056662; x=1783661462; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yqInNBGyRxbMZkLQX5g1lE2UKQnsvWWdzJYoQnv3Yuk=; b=XyKtWyf90BfmaGdgi6JuxvyPgQWGyJKNeoxBvDPSMf93jVF03lMGc+8aqNn+zy5Ndc Ac05ikbSeKuW3XftOwCtAre6XxL28Th3bTtkuzkWGK9ZDMuLlBFTXp/8FwiK/3BSi3kp s4lR+DUJlH+/sD/6X7Fh5jjZydfyAoysfa9vyyphzhaY90rt/5sDsY5mMdIwL5RKcijG 8WxxH0O9ar2ELvkFGIb+l4cbh+fekwuKDtXsxgcryzbZ144u9P8cjED/BxrR5odHS6ae 3lxGv2ZUXyOtpsbdOYVP3vfYcNBWKTyLaQu08YWbQrBN4SQzA9NgZ2lpiQBvH/aswdi1 uHYw== X-Forwarded-Encrypted: i=1; AFNElJ9eN4Y6iqKTA98BznYAkUVcPVgdW0aFWruk4yj9Xpss6vxRnUe7UyJe3OSoN1B6LhnHwXCsy8MKzTEmDoc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1xjYIuMgoJ2EITB2NHUIfKcleL0davjG57plNuKMMLYmdXgAl JRMok6IQXlfA8KuXthLJ7cmEhDcb/1kR42SjjyoyZ645rhz2wLUYSAIs X-Gm-Gg: AfdE7ckWEzKvhdpgzONPq1PRi2B/2emskeu4h9z3vgg5pwPeeZB8Q/v8d33z0OB4ZOK zhV58jfrZHUiMI0sHUK/uEDSAKIL/QU0+uqJ4RvY+jALWcdaEuAxIz37D6AA6pK9vCatpPQJvOM 0vXzloEgRCv9q+cf6aiyWVfbkRVrf9BYhOEHmfx/HVL1U0QJypFrjTk0DQwOH3u1jTvNXKmJ6gd RnzKU7iN1zYNQPUkQqVIfUW0LtHO0KVJxrKESHvICCqrcmTP8/gTJGAoHU67+tKrUN7ALvF0QnL rTUH2s4hzQdTLIVEwEwUH7OrL1k7df3bgspJwnSdXm31ZVxzBkIpEEg2hCF6JtK3+2jAqA6AFIc A9KpFF3DfD1qp+ZT/wHPaqwxXyMrpskjI8Edch8JkhpGg0CF4xckzA3E7dCFHoTCeC077TS4ikE PWZUhmgraPux6hzeYnXNdFKKj+6JDU6CxQ0vOZFQg9FaaAf+1m7zrSGO1/qtwsZHhgLODnFe9ck 4R5es/BlyLF84U= X-Received: by 2002:a05:622a:1812:b0:51c:1967:5091 with SMTP id d75a77b69052e-51c26b15334mr134510641cf.41.1783056661912; Thu, 02 Jul 2026 22:31:01 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41abe756sm8570361cf.6.2026.07.02.22.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 22:31:01 -0700 (PDT) From: Yuho Choi To: Ketan Mukadam , "James E . J . Bottomley" , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] scsi: be2iscsi: Fix MSI-X IRQ unwind on request failure Date: Fri, 3 Jul 2026 01:30:55 -0400 Message-ID: <20260703053055.141337-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit beiscsi_init_irqs() unwinds previously requested MSI-X IRQs if a later request_irq() call fails. The unwind loop walks index j, but passed the failing index i to pci_irq_vector(), so free_irq() did not use the same IRQ and dev_id pair that was registered. Use j for both the IRQ vector and be_eq entry when freeing previously registered MSI-X IRQs. Fixes: 831488669a33 ("scsi: be2iscsi: switch to pci_alloc_irq_vectors") Signed-off-by: Yuho Choi --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index fd18d4d3d219..9833ab06b299 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -878,7 +878,7 @@ static int beiscsi_init_irqs(struct beiscsi_hba *phba) return 0; free_msix_irqs: for (j = i - 1; j >= 0; j--) { - free_irq(pci_irq_vector(pcidev, i), &phwi_context->be_eq[j]); + free_irq(pci_irq_vector(pcidev, j), &phwi_context->be_eq[j]); kfree(phba->msi_name[j]); } return ret; -- 2.43.0