From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DF6B39FCAE for ; Fri, 3 Jul 2026 10:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783074211; cv=none; b=Uv3d5Lu7fhEdgeKfJshbEgf3hdxrlJTPCTX27HAqBVhJ6yZxtsS8ZdrMym2Dd7uk9AnJyAjbCQcl7EPYFgEFt5qdGyuTZjXaJi7/MWP/M0CgFh6gt57px/t3ln9P+yACwfsRnS883Rer/kAMxJ7wDfQtITXhFBryJIeCkQl8HlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783074211; c=relaxed/simple; bh=N9+QbAUPaPXmQUpTCidHoZEU0HdMC1BH/xbdtpe2YFY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=f/PFAV8eLYrNcNE9y6/4ar1PusM6W9xeyd3xq1P2j3eIXQlodqPkXSGtON+c2kjHuTM9+Pnh6gU29kxpi8C6uWuKd6GECxeVLB5JkrKqdw8Q1m0q8dHUJk3qOlvLsGcWoXsPMG7Q/5ywat9Jh1n347ZimqJ3ow/UkKtA6pXolEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fTtqo1Se; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fTtqo1Se" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-37df416c44bso369780a91.2 for ; Fri, 03 Jul 2026 03:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783074210; x=1783679010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=o2F8eP/jjp9Ke0LSHUP1E0ukxaqDAr6L35/n8rcUGLw=; b=fTtqo1Seyg19DDf2TI5VJzajTz34gxHOCKAZWzCsYmKiWfx6GKHA6GAzXTigmOPxt5 OCgkvK+2i4071PnhvFEYXUQ1rYCiJroZXd2bi9AmU0RILnqxxozV2jrPKKpAKt/NWD48 YO9nwc6+F0LcK4VbdGjPoxCgaspIpHOVGgSbrugaFoEdUQRxb+3FXj5sPnz19mTfn8DY UDfn1daxOKm09AxMZREachvace280NpxOgrh2tnYTUmEv1JY7HdENAwIurXWEniR26pd qYAYqvbArjBmbOvn7G3ejjuliqkCy2pSj5JEsJvkhYUrLET3YlIWqctmnAqpVsgI6ZX/ 7A+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783074210; x=1783679010; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o2F8eP/jjp9Ke0LSHUP1E0ukxaqDAr6L35/n8rcUGLw=; b=amEYznFSTHP5bFauzNXNNfrV0Z0pMIEsu/xub6FIFoHysDI4F2VOBmncpjL7r4zo5W sCxQxj5UXa4ugkZr9kkfyYXNiIE4B9BcKMqiMYwreJLZwpmrPvMplp/EzSpW4MvdkOFJ 4i3uKDshB97F7sEcCmSmLhl1xdmb26LBgGJKIYeoXi41YUNglN6Ni2zZSU+m8ofYOBfy T2mfJcYCD5B+Q1DRQG6hUJSb+dSzqONIqjm7+9RcXUIdHIQAq3Mj3bl8s9rI5bHqzZuL wzBdEoUBLc0v6TnLIouFZKfgBkjpMg5ciIUr67mmeXP8XMQgYAHMby49ijqCzUhBjcAK WDzw== X-Forwarded-Encrypted: i=1; AHgh+RpwQIjtJXrzAY7dczDos/AV1CNH5+Foem3jiOWFLwCAKdOI4n5xKLlmdXNXJHyyVt9+3ggEv45McDDhAtE=@vger.kernel.org X-Gm-Message-State: AOJu0YzOde+gek2am3K0H9hq/DAEVj2ykozchsIYO5pFDx3od3pa0CcP eHyEL1a+m5ndVMW3eBwrFNaekCMUfWMoC3miUUHXtrYph+3cQQ78I4Fp X-Gm-Gg: AfdE7ckbUy2NTCyPFRDHjnpNFJ5QT19xGIs6LjnWF6mHV4xOv1pShT/y2lCNl9K8jxk wotouXKmgwzeSKdTy1EnYXDMZKxUoQXesVHiqsWNxPC97ROaydOqqKkoMaxjO322ftZRIMm/1I7 16lueHII6ZmorZENtsP+en51k1ZxiZR6oLyU0itjp9j+nA59jKmMNnJqsaSX8hpZPEWWH6xWKTB JY5L/hOCLyRE+1GZ3noRixHJYA522KAlUCtCgOw/BkcOomE/hancFhTB6AU4U1l75nx8CyzwmdL xK0hdfkY0Dw40L1SaQlH9LeOJvCDpPDi2ZmOFwzQ+gb9ksD58s9lh71Ob91l9p5ZGJYXshlu/S/ OzLu9d73IMXppb9IjaEGACL2X/Dl5CTkmQRwPI9n/lVF2ioEl1sRN0uiM9q1mVca2waJAbFHZ+z pHdaOo12l3pJXbhC0aWksa/Q== X-Received: by 2002:a17:90b:582c:b0:37d:ac3a:2f4f with SMTP id 98e67ed59e1d1-380ba8d079dmr10435698a91.13.1783074209607; Fri, 03 Jul 2026 03:23:29 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:185d:def2:c823:8e8c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bc27ae7sm17931678eec.26.2026.07.03.03.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 03:23:28 -0700 (PDT) From: mdshahid03@gmail.com To: Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] fs: hfsplus: remove redundant NULL check before kfree() Date: Fri, 3 Jul 2026 15:52:56 +0530 Message-ID: <20260703102256.58959-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid kfree() safely handles NULL pointers, so the explicit NULL check before calling kfree() is unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- fs/hfsplus/unicode_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/hfsplus/unicode_test.c b/fs/hfsplus/unicode_test.c index 83737c9bafa0..7f6b2a3c69d9 100644 --- a/fs/hfsplus/unicode_test.c +++ b/fs/hfsplus/unicode_test.c @@ -39,8 +39,7 @@ static struct test_mock_string_env *setup_mock_str_env(u32 buf_size) static void free_mock_str_env(struct test_mock_string_env *env) { - if (env->buf) - kfree(env->buf); + kfree(env->buf); kfree(env); } -- 2.43.0