From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBC6C10785 for ; Fri, 3 Jul 2026 11:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076406; cv=none; b=GCZX1P4B9Cswv6JVFvS7Bkq/6mreRb0qvKJhV4gZU6UebGhX3iUogLDX81rUI23Dyw+dod9at/L/ISYUmFYnSwgtxmZOaJyNd8i++4aIWmpmEqzB4xZxUP1mAjOo0wTj8vdUIgYMHWZleH/WdjnOp66GoXTaXurEm3MNBxUlL0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076406; c=relaxed/simple; bh=B+esDQOFjtEH40Ir5l1iTJFdJIvYqbu2NvdYyioUCOo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rICkoW0Ivg9aHrr+jzuLMDj7cWm/g5HT/W8qhaKzD1UdjP+8zuOc26A21ZS8tTI8X83+aPc2dA8njqts2mc0jA+ALYjQcB7IQqhH7bf/yMlKG56oMKq00mIUAaEjsZdlMyWaNt2cG8c8MWk1BVA+bEKWQ101WpldyT/KSHzqmVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lN1AuZCH; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lN1AuZCH" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ca7aaa4b85so3606405ad.3 for ; Fri, 03 Jul 2026 04:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783076403; x=1783681203; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7a5zgEqDsjiDOa59/2Euu+6bxEUj9/ITpa3Tg3Tl/HM=; b=lN1AuZCHAUIx06c/YujazgC/Mit+evANGe+9yVimhA1hF7wwI9WdTaqFVULKh6MACc MqxLVDDwqOk5nZjK1FFyUc0pMTT31mN0q7ML2xYZbc0ormvN4l9n+9tL0LWyD3l8j+rI SUShWfrQhBsbBh9521nL6rlfWWuYQMtV7qyRljWCUHzaRQIUF5IC2nmrwhPko+Nla74b 0pjrBQCSamUb5kL/UZ5VfmZslihs/BQjWsLCJjTCbkc4nSJEuJSrUAGPN3XK8t4GY248 TV4lXsjOUtmwhCY088IBlwyjGFZ0MY86xyD6/HL8Nqu7ik/6raN6cS9KxslPQytz+Ywo VjQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783076403; x=1783681203; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7a5zgEqDsjiDOa59/2Euu+6bxEUj9/ITpa3Tg3Tl/HM=; b=haRbOYN1MNMpxMbQIWglmqk7dUB9l6Vrr88MM4f+zyoIeQF8cQCHqpXTXmKNPevOTy 3ckhnRkMOXDwadYvOPKBMSkcMxyd1UxSakhrDyzfIblpmcRlXz6HvS/eTbSh8PzQlN6h 5qL1lu9ilYNI/iC/KhcvrOSgmhTMr0UM3Ym3En+gordS3PbfV5A3k7kFVe0ADYIb/zIe 1CBF1h123fBCrbKwRE+qTVHfbQiubVXrIib/fhGwDMyXJ6uv+csSYvpqUuRl2lO2+Lso aIUCjhXngK7d7AkrKBchRI8V7Y3x3cpYbJTJSjHYXDnwZksaZjYsYPEyQUNUvpfE67cJ DtxQ== X-Forwarded-Encrypted: i=1; AHgh+RqY6LOp5/RvlnaYVAqohsxGhCGAdNvcAhhlhmNMLywb7MCQiDrodwnUzqy1Q/lc1IHlEqoy4t8cYU7ahUo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0I88cCRurgtlL7l6fZtfSttqm4CG/Cd03aNCKayNq1OHFWsWe iqdSQa6+f1pQ/nl5UyofgYfFcaATkPyoxgDwFg3ZvPBIHES5Kl2oDnMD X-Gm-Gg: AfdE7cmhNAjBLvj7d+TySPFZ9sskV5OVNZsflyHD+PVtZyqSAoJLkGCtX7wIjvc12Bw CH7ULvF2BY14UjeNAr08tivfR7qz5ypvrl1Y/elnjRWK/AVhvLqSNykeHgZy9ahqCunNuj9+9HV MvW5nuJlZjnAOU5+RXoGrjD9h4MRHxsJTh8wYsoAnvTAnB6l/nXAtJNAtQ4TIhQCX/OH+AlT3uF KEfh5ycHARjFWFjSzyGSsfRCilVwJlonopoeldnIhhrnca/Zh0sGyC5wWaGWDDRtOVkcN+Gf6B4 LSoiwV31cXOQH71ZHUpsCYAhsZEmkqkzdjRtsgLh0aQqA+//+pm7nulc+3ZzXyQsVFB3cd+AWqB VjJiLSE+11q4Q7dgKgL9SIwFKWPK1YxoNactyyxF4g0Rgcul9C/J7a1ClMLLy6AeVp9lsfc5ffi 7qIoqdl1nSniY= X-Received: by 2002:a17:902:ef08:b0:2c9:c517:d078 with SMTP id d9443c01a7336-2ca91206866mr93090535ad.36.1783076402585; Fri, 03 Jul 2026 04:00:02 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:185d:def2:c823:8e8c]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c7fa566sm17050947c88.4.2026.07.03.03.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 04:00:02 -0700 (PDT) From: mdshahid03@gmail.com To: Lee Jones Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] mfd: viperboard: remove redundant NULL check before kfree() Date: Fri, 3 Jul 2026 16:29:37 +0530 Message-ID: <20260703105937.62541-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid kfree() safely handles NULL pointers, so the explicit NULL check before calling kfree() is unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- drivers/mfd/viperboard.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c index 888737b8e7be..36be8e69f45c 100644 --- a/drivers/mfd/viperboard.c +++ b/drivers/mfd/viperboard.c @@ -96,8 +96,7 @@ static int vprbrd_probe(struct usb_interface *interface, return 0; error: - if (vb) - kfree(vb); + kfree(vb); return ret; } -- 2.43.0