From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D65B3C3456 for ; Fri, 3 Jul 2026 11:03:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076640; cv=none; b=TZxCPFV6Wa7yXMdbE6Y1ho2tWi05K+lFbUDSwGrXHm6Vghz4sgo3zAn3oJxwawo//SovCJgRrxI4Ht6ow8NusG3XbcqNdqOiCT2LdVXldCz5637eJ+xtFVufJXaobhGLNrP8it0b2ps54ujMoweBLn5vfArrtDTXppNH7B3K264= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076640; c=relaxed/simple; bh=KSKcoZhcUNUQt6mbvtajVqwGl+bjGPliu89rdk9IcV4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xu7wmf0wLgnw7Em/8NQe3Nzr6+BifENUenqIh27QVqIUXSqWEvfGmJOJNsa7yL7lXPr+Hzh+VMZy8OdlE3RX6CmQSU7Zr6I8Zua30XB/K+mQK9KkxMmaHG0X+U36nByrzLG5ROjYReKLu/nvkz+1rJtCOOIJflyqBAw7o5gZvxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=KvtWtgZf; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KvtWtgZf" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2c9ed0c7fc7so6005495ad.1 for ; Fri, 03 Jul 2026 04:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1783076635; x=1783681435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yXNEvMizuglXOCjkp4mAG2muXyzVgQAtby1OdmgJjvw=; b=KvtWtgZflkdFyH3Vz8ZXtWc4++GF8XRZ7Rpap/TYpW8PpQ/edQUeloSAQycBcHxSj8 /oe4VgHNNuW6Hl1Vjv+B5Avl5+S4Qkla1OfkXp/Qe4REkztQ1qg2BmFelb4KEtpzZQTs ey9qzpu2t6VX7COz3OHdjyEplNfgjhMIKkhVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783076635; x=1783681435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yXNEvMizuglXOCjkp4mAG2muXyzVgQAtby1OdmgJjvw=; b=NWAt4XnyIUmdcl6m1oGEnekm7hmZp77h6X3ROHHIZIPaaSLzM8VTvDZkTogzbV4qtz ZuZQeOtzXqNhe2s9Krwlk/MsV+zGbu69oTMJ3wY/yGMAL/NKaiuILT4LK/0ZlvqvN0pE Qb8FKkuNzqYEX4jMxNm1rwqI+g2MI//F6AG/ts5NaMMJKcb4PNMB9C6SPiGTbKAbMYzc xmrSg5Lfq8BHiRncaYIB6yaKDLpu2DXhPrc0pDASZaSzKsx6D13v6Hqnwwqz+SHZ7Lyg 0EuN716YxyufkxdwYaww1LUSbOvkpWsqXsoPpvkkP+kphlohUoA8BX0c8RS8DKRKlXIa TlIQ== X-Forwarded-Encrypted: i=1; AHgh+RpEtqestRU4hD4iZgD97Hqd3fePNbi7a3YXMllkvPPK29ej89QlKlQY/Ffz9MvLaXu2KjbCJHn73C7UOGw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7Rh36MdEp5o4yFGZfnrpyg1YNjz70nn30BRtn6T/oI/sOP69f yrxKZFt+49F0j3UYZ2VkeqTJxZHO7aYiyn/iFvt4Mtw0TfHJVWDRs6+IeHdl8IxImw== X-Gm-Gg: AfdE7cksbbHwV+NGBHnOX1gtSYWzCNi5l2XBUIEBJ6TofJ9olBAl8lUvZ2a0pnbmbh5 LISYKNzPOYuZOg4cdIIfOKCM+Z/zzfVnULG3Oe79OxgKJMsjnXoh74YJIDYJN5t30j7y65q4K/l G5UYaU0gXxWD9XPWqfYGoV3FeceEm03VAv9RYnalWkbAmop29iOKuy+JmWUwzzyHGOeOWYOfz7r 1WVb7B3cibwDyQ3cqAj9pUDH07NKXv1cmHpHPH+TVw1B9LGbj7uzAvhxBpOY3kg4gXxfwEEeeqi fQ21wpCOhKdcItYHaXCxDfo77MW+GvST9fz81762eRUFJ8IsmK+aB1SvdpcEAty2mxpUQQ4X2js 9GTBok/JkjQzxRha+whYUnV/RUEF6WApCxpj2XtLaRVZmiY7vI1AVv2mKT/GI9swHAY69+NjZg0 UBVNoRtLEiH3ujVUXduPboYfICrX5bUs7R9PNs+Cylv6Cw5ZPFfuQZGEcKW6oGte5rCyzg+w== X-Received: by 2002:a17:902:ce0e:b0:2c9:b01a:fbd4 with SMTP id d9443c01a7336-2ca7e6c4036mr107709695ad.16.1783076635124; Fri, 03 Jul 2026 04:03:55 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:7bc5:6c83:76cd:cbd6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad6f25e15sm7785315ad.13.2026.07.03.04.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 04:03:54 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v3 04/13] usb: hub: Return actual error from hub_configure() in hub_probe() Date: Fri, 3 Jul 2026 19:03:05 +0800 Message-ID: <20260703110317.1283411-5-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog In-Reply-To: <20260703110317.1283411-1-wenst@chromium.org> References: <20260703110317.1283411-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The addition of power sequencing descriptor handling in the USB hub code requires dealing with deferred probing from pwrseq_get(). The power sequencing provider may not yet be available when the USB hub probes. Return the actual error code from hub_configure() when it fails, so that the driver core can notice the deferred probe request. Also rewrite this section into the standard error handling pattern: if (error) { # handle error return error; } # do more work return 0; Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - Rewrite into standard error handling pattern Changes since v1: - Moved "int ret" declaration in hub_configure() over here from the next patch --- drivers/usb/core/hub.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 13264e86bc6d..fe10d72ef39d 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1874,6 +1874,7 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) struct usb_host_interface *desc; struct usb_device *hdev; struct usb_hub *hub; + int ret; desc = intf->cur_altsetting; hdev = interface_to_usbdev(intf); @@ -2005,14 +2006,15 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) usb_set_interface(hdev, 0, 0); } - if (hub_configure(hub, &desc->endpoint[0].desc) >= 0) { - onboard_dev_create_pdevs(hdev, &hub->onboard_devs); - - return 0; + ret = hub_configure(hub, &desc->endpoint[0].desc); + if (ret < 0) { + hub_disconnect(intf); + return ret; } - hub_disconnect(intf); - return -ENODEV; + onboard_dev_create_pdevs(hdev, &hub->onboard_devs); + + return 0; } static int -- 2.55.0.rc0.799.gd6f94ed593-goog