From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E1B13C3BF3 for ; Fri, 3 Jul 2026 11:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076650; cv=none; b=Gc5TyzWzFvjBl9vtwk/NBDfTm3A19r9tP0Zlwo5hRoxFBLqUEU6w5n5aZHcKdwZrmL0F+ITvpJZ5xzbGWtnkpkDhg5WilT9SVw9JmNzN+0rROYXIAm9OPJ5pGOFSxYGJ2KNm/jDErBbcTj7x15Wyu+meXetRw/6iZrS3kFxLmRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076650; c=relaxed/simple; bh=kfKxqCT0AnFtztM5LFloMbjAp374Nxm9lZYgvpDSr08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DKTi23sAEiPQINihUkNPqSXk2RrVH09eEflYPKyPGvCmNoAjP/vt6wSqrPK9LVpayv1zPIdZlQUN9BQRtuunW5UywOSnELYUEfDRVuBqYjfxPHlObS9tAZ/5DpeyURknF0VUBLkf+smVmRShWd+OHdnLpT8qUYB8125De9xFx4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=O+y53hif; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="O+y53hif" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ca265d6ca1so4872105ad.1 for ; Fri, 03 Jul 2026 04:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1783076647; x=1783681447; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KWC74RHfH35yZoE+4T5JHX8GhXugEkV5aHendXMIUrQ=; b=O+y53hifkvRjzCdB1Ewt4af9ZOm9SggDwvEJcCMPVVHKv1yp8Gbw+cRAFQico/sdvB hNaBm97fEzqrTz3tgnzTaz88hYMd3i0/OXT6/quW1A71tbzXOy7TiyxZx934zPiQhWHA mGEHwld6RTwBIzuxi4JDKIsosRAdGgEZg21LA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783076647; x=1783681447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KWC74RHfH35yZoE+4T5JHX8GhXugEkV5aHendXMIUrQ=; b=DKskoUAxd3cNYPf9O8XuEMCUVEpCSgF6Ob6GAcWDrJHQgACvzjOOQLpuziaECWliF9 cRzDh79e8J6FG/oph3vJgJk7a98r88HbAa3EGstlx9ZRMLId8XVGy3WEERjr6YjNzJgP 1hD9ebIi1Hi+yrsmLF/U0+nmoShOJmF3SgbOYs1K9WNE4Rsgb4J4ZfbdkgZjgYXwX2kY BbAHrARMO1Et8j79Te6x6NR61zsJsacgwjiSzEVI7XE0ZxrfHwYR6//bG85Q4BXRtDYA eeXdq9qeCZUK5YSlE5GEjrVIgpqy5JrX2PvOwukF7nFgTX7HmxHBHtQ+o/ebV/7b5EHo gzdg== X-Forwarded-Encrypted: i=1; AHgh+RqNNE3icUfO16GEB37Bv1ntkwVzo1wlMTXAO0+edLfwuOl6RQ34yflsqn3VbUmL3exaonwg7QRCXV3i2xg=@vger.kernel.org X-Gm-Message-State: AOJu0YzTpAOZ3diKtI1jPN6SJyJ/fw0rQrLDJTuCHaVY9h36nyeSDvsz DQB4ceaCsXWt5EB9y9jxTRtLLcYMas9vBGDj9AtbUXB2nbfSg4mdM2hbVZ6EbW2Lzw== X-Gm-Gg: AfdE7cnkRchemc9MFFSKfv2mUkMEzD2pKyxG2fvvplWU39/lTfQHLozN/dI7HTx9tYv L/ASTx6xnJxh07BW12nP0OfUZToqLQHPmdkVp2SNslchRUppML0bVOs3hKPMxgADWKEtD7YRkvT KDk8YB4QgBNWc7OettWxX8gis444myOZeSb4TEYdA9VRztE5fXO8FkjoW5btoe4VSovhsezp5Ba 9iG2O+yXw9F1ymNmGVGd40VdNnj5ulEeTCeB7CB1XyPtnabEHUIsF+7wVyCcZJLZrFtugT/4ZDk knomwErYdu/KGdGcb4kOY3Ddd6mdkWRmUKiWLgWFV2pnPQjL+KDb3ZKrcS7C1PSY2SMx5FTmqHb xKdSOfaidKwh+d9F8Z0zKBYFSvS2iTjrnrupy7chxmsYsVsXPb3ow0Mlwq7TzA7aTQlZnBTgCxd joEjYPdCY4it39Kahi0tV6Pg/JjcIwfhSd8ryYOdtNFfFu+OrSLMdAsNK1e4AC4qPT6zpQoA== X-Received: by 2002:a17:903:3b88:b0:2c9:d27b:af11 with SMTP id d9443c01a7336-2cacacc3ccamr39740205ad.11.1783076647262; Fri, 03 Jul 2026 04:04:07 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:7bc5:6c83:76cd:cbd6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad6f25e15sm7785315ad.13.2026.07.03.04.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 04:04:06 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern Subject: [PATCH v3 07/13] usb: hub: Use usb_hub_set_port_power() to control port power everywhere Date: Fri, 3 Jul 2026 19:03:08 +0800 Message-ID: <20260703110317.1283411-8-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog In-Reply-To: <20260703110317.1283411-1-wenst@chromium.org> References: <20260703110317.1283411-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are still some instances in the USB hub driver where port power is directly controlled by toggling the USB_PORT_FEAT_POWER feature flag. Switch these instances over to usb_hub_set_port_power() so that only one unified function to do this exists. This makes adding external power control with the power sequencing API easier and consistently applied. Signed-off-by: Chen-Yu Tsai --- Changes since v2: - New patch --- drivers/usb/core/hub.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index da0a4cc8e15a..8ae97e8c26aa 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -975,11 +975,8 @@ static void hub_power_on(struct usb_hub *hub, bool do_delay) dev_dbg(hub->intfdev, "trying to enable port power on " "non-switchable hub\n"); for (port1 = 1; port1 <= hub->hdev->maxchild; port1++) - if (test_bit(port1, hub->power_bits)) - set_port_feature(hub->hdev, port1, USB_PORT_FEAT_POWER); - else - usb_clear_port_feature(hub->hdev, port1, - USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hub->hdev, hub, port1, + test_bit(port1, hub->power_bits)); if (do_delay) msleep(hub_power_on_good_delay(hub)); } @@ -5452,7 +5449,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (hub_is_port_power_switchable(hub) && !usb_port_is_power_on(port_dev, portstatus) && !port_dev->port_owner) - set_port_feature(hdev, port1, USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hdev, hub, port1, true); if (portstatus & USB_PORT_STAT_ENABLE) goto done; -- 2.55.0.rc0.799.gd6f94ed593-goog