From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E8C037EFE3 for ; Fri, 3 Jul 2026 11:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783078035; cv=none; b=S+TF+xA6ILkUvMV/7JYewImaTaXRh5X7DMNCpW3mY/X5mMvEW27sqaEBlQwOnzy9it53034CkKVru6ktyjOiyXs4X+A3IZqChnfvW3AhbLChJs1nsuBcXsZ1dwBEGTNiczn/M7LTHbyBKQQzNFiRM2z8GjGS1OIpAuGSQftajtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783078035; c=relaxed/simple; bh=6Zll6264GRi6SNISDh4WYqON6ASVmasFZBD/szDcPME=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=i4oWPYUUg7V40PMjrpE7E773+SqVHljWo/Ms+l0GCvkPzE8nQQa8furGy3eI5LhboLbNbZMfPxCejJTn1S7kesuVluS54xL6L98cGfFAkg6fLl3Eof+gZ4rBD3KVWp5SISIrdyUSswLffx0xYLU3gSSQE3veLAWRrUP0XU6GQbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pS1B7y+A; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pS1B7y+A" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c9d1fc053e0so354257a12.1 for ; Fri, 03 Jul 2026 04:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783078030; x=1783682830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tQvjlOiW+cm83l6iL+N3Ll3Wujm0kHNaCoPYlrf/mUE=; b=pS1B7y+AOkbRPvFBBjwxlQZfP4MzBPCrwtdkZmm0Z5KXGJWxG7h9LPIeGk4nJ+FuXG B8zMGAQt/fDnnRNlpLyt3NQT67xaZQM+tXWERKWgdEz/BQQ6Kdi3WBk95nSPi14CJimN aJeUtzi/SDHtZ01nNuH20qtnu8QDB0BTgqUjVAvmXF90dVpfJAKBdJcL1a27GgF5ciG8 auR6CoSI19pXhX1Y+zYV96pZJdug7ujjoqnhlROi3YeHQt1fg98uDxnww47dal/GeYGW UcHlIWAR6ibOlC825V3rCbGu5mGFMKdB1WvNM71yaOtz5aJmjdTzuOSa6/rex9knxnyH DOOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783078030; x=1783682830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tQvjlOiW+cm83l6iL+N3Ll3Wujm0kHNaCoPYlrf/mUE=; b=cXX6TAx8ex+g2N4ivA1n6W0Ml9GgvdE/KkOxyu8WxK0vi5sJzQyQEJhk+evuhaLfcz ELUaZS5WyQhooOxyqJFUdy7ZtzABnLVl5uiAKXOcIF6ULWulk9n9TWAhYvJRPZifSU4O UxG3V0b80FIRdfgCyanu21ySGOB2JNgWcDxJKH/xE3xBAUj80+hAQpB8lvIiVIxSao79 lu6GvEZXJkaIs2nM5R10JMkMl+jlkkVJ6vdSllSz3F7ebEmClK9834UjJ9VkHn2L2x5z q8DzifZ3nTZrNiPwOtFt7691lI6uczHVH22z6iOHEUtiV1PYJJYeEULTcSyA44lZQ44p Lf/A== X-Forwarded-Encrypted: i=1; AFNElJ/9fFJGZH1GzITkcHqvvh15hHAstar+AcmVrjfM8hdacfkhlBNwhmnCy+OzzbuE5PKcwEPOdHjV20ahkBU=@vger.kernel.org X-Gm-Message-State: AOJu0YzLS92lydz4BCMqQ1WLdr2p0+kn4TdJH7Fi/2bnNmkqLB3BA0cR szgngFIhR3Cphq7b3J/wGN176/SB5FL6uI6w0J4bDCjUngxxctNSfZ0K X-Gm-Gg: AfdE7cnSGoiBNeHpWa/kqvoH+cdVFeAEpMFmhA4rJaXzUFLQ7M69s0d1wJGluNmGY7o so4Fx/zHUA09lcgiCXXv/nu9j5YBSK49P/gW/RjHFOPyty/k0XgM0wpUcVAa0fcUQm5JPqjyymN rJioqqQXUBpGPTOCkU09Pzqte9vDN/6nH9S92FJhaBqwhpgFvf2dnssOfp/lwOqoORdOpnQ+kA8 Pk0/HTuuZx4XvO0rrjCl8FPa9TwlE/EZXnFMiFdG0ygcTjZZtblFtH5+uzy8TXjiMcTs0nUOQML M1sdNTrPteXU8Lyy9TGoPYrpRnO8VUaY8bG+C9kEzR4p8nj4TKlKKayJFOVe5RQFgWSQiPGEdmg IKBTSWs4vzLi7Pgcmj1iNDVOY96j0mjRvMT0Ahezqya9vQ+bzZ8RweSKGkFAZH9yNLgYYnY/5BV YdhF7m9Yi88Uo= X-Received: by 2002:a05:6a21:9f07:b0:3bf:6c08:2847 with SMTP id adf61e73a8af0-3bff42f825bmr11648934637.54.1783078030485; Fri, 03 Jul 2026 04:27:10 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:185d:def2:c823:8e8c]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c876ea9sm17263039c88.13.2026.07.03.04.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 04:27:09 -0700 (PDT) From: mdshahid03@gmail.com To: Andrew Morton , Baoquan He , Mike Rapoport , Pasha Tatashin , Pratyush Yadav Cc: Dave Young , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] dm: crash dump: remove redundant NULL check before kvfree() Date: Fri, 3 Jul 2026 16:56:42 +0530 Message-ID: <20260703112642.65498-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid kvfree() safely handles NULL pointers, so the explicit NULL check before calling kvfree() is unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- kernel/crash_dump_dm_crypt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c index cb875ddb6ba6..cf4d41fd4d5e 100644 --- a/kernel/crash_dump_dm_crypt.c +++ b/kernel/crash_dump_dm_crypt.c @@ -364,8 +364,7 @@ static int build_keys_header(void) struct config_key *key; int i, r; - if (keys_header != NULL) - kvfree(keys_header); + kvfree(keys_header); keys_header = kzalloc(get_keys_header_size(key_count), GFP_KERNEL); if (!keys_header) -- 2.43.0