mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mert Seftali <mertsftl@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Jelle van der Waa" <jelle@vdwaa.nl>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Mert Seftali" <mertsftl@gmail.com>
Subject: [PATCH] iio: accel: dmard09: Implement IIO_CHAN_INFO_SCALE
Date: Fri,  3 Jul 2026 15:07:50 +0200	[thread overview]
Message-ID: <20260703130750.66549-1-mertseftali@web.de> (raw)

From: Mert Seftali <mertsftl@gmail.com>

in_accel_scale has returned -EINVAL ever since the driver was added.

The channels advertise scale via info_mask_shared_by_type, so the IIO
core exposes in_accel_scale, but dmard09_read_raw() only handles
IIO_CHAN_INFO_RAW; a SCALE read falls through to 'default: return
-EINVAL':

    $ cat .../iio:deviceX/in_accel_scale
    cat: in_accel_scale: Invalid argument

leaving userspace with raw counts it cannot convert to m/s^2.

The driver was written from a vendor source [1] without a datasheet, and
the scale was declared but never implemented. The vendor source carries
the sensitivity: its conversion is

    acc = raw * GRAVITY_EARTH_1000 / sensitivity   (then / 1000 -> m/s^2)

with sensitivity = 32 and GRAVITY_EARTH_1000 = 9807 ("about
(9.80665)*1000"), i.e. 32 counts correspond to 1 g.

That sensitivity applies to the value this driver already reports as raw.
The vendor processes each 16-bit sample as 'data >>= 3; data &= 0x1ff'
plus a sign-extend of bit 8 - a signed 9-bit quantity from register bits
[11:3] - and dmard09_read_raw()'s 'accel <<= 4; accel >>= 7' yields the
same value. It is self-consistent: 256 counts / 32 = 8 g full scale,
matching the part's +/-8g range.

Implement the scale derived from that sensitivity using standard gravity:

    scale = 9.80665 / 32 = 0.3064578125 m/s^2 per LSB

[1] https://github.com/minstrelsy/mediatek/blob/1f49d8c87b839651bc89afc870277e8e0f2e2d55/custom/common/kernel/accelerometer/dmard09/dmard09.c

Fixes: a4fa6509dda4 ("iio: accel: add support for the Domintech DMARD09 3-axis accelerometer")
Signed-off-by: Mert Seftali <mertsftl@gmail.com>
---
 drivers/iio/accel/dmard09.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/accel/dmard09.c b/drivers/iio/accel/dmard09.c
index fe35a1270786..a61943120d07 100644
--- a/drivers/iio/accel/dmard09.c
+++ b/drivers/iio/accel/dmard09.c
@@ -27,6 +27,9 @@
 #define DMARD09_AXIS_Y_OFFSET ((DMARD09_AXIS_Y + 1) * 2)
 #define DMARD09_AXIS_Z_OFFSET ((DMARD09_AXIS_Z + 1) * 2)
 
+/* Sensitivity is 32 LSB/g; scale = 9.80665 / 32 m/s^2 per LSB. */
+#define DMARD09_SCALE_NANO	306457813
+
 struct dmard09_data {
 	struct i2c_client *client;
 };
@@ -79,6 +82,10 @@ static int dmard09_read_raw(struct iio_dev *indio_dev,
 		*val = accel;
 
 		return IIO_VAL_INT;
+	case IIO_CHAN_INFO_SCALE:
+		*val = 0;
+		*val2 = DMARD09_SCALE_NANO;
+		return IIO_VAL_INT_PLUS_NANO;
 	default:
 		return -EINVAL;
 	}
-- 
2.55.0


             reply	other threads:[~2026-07-03 13:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 13:07 Mert Seftali [this message]
2026-07-03 13:30 ` Andy Shevchenko
2026-07-03 13:32 ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703130750.66549-1-mertseftali@web.de \
    --to=mertsftl@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jelle@vdwaa.nl \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®