From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCF693D410E for ; Fri, 3 Jul 2026 13:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783086955; cv=none; b=uJAL43SuWYgM/ph7gBje+v9iE0tpz2HGITDtWujxJYBpY5WCOfeJjTmvmic9MKzktqPGS0zOYGsV56Scn84WAoxzKIhTHUGMBhV5wKQHKBjEvc43dSq4EWUePEfWe5ndXd6k1hxHllAm2mpTXmJ1bvo6GATdSbmCU2I+tuDfWqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783086955; c=relaxed/simple; bh=c7QoemBplk762Mqi9bT4cCZDXxBt2XV+uhwPlOpiVgM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MpKDMYZiuNhAtncM63GQEU8/LD1nAT+dvjlHmDiYyS+JV41JgXUw92oRwZQw1V0U8bk0s7RsCp5/kKrlANVofBBlrP618squweqdt6wM1SpLpjFAmyKCHzrYJJk+rWyMEXlhoZ8ETrpcRRCZmHW1bHf6nXAyLd6NwWE86EoVnCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YClYvYKh; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YClYvYKh" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-381b831d535so216128a91.0 for ; Fri, 03 Jul 2026 06:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783086953; x=1783691753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BJMENLToTUHqriCNJNskYp7DzZMWsbfXaZUpesqSU/U=; b=YClYvYKhjUSBgV4VgiCj3oJD7TjF3wMkDJA0ktsxJlN0cOwODHVJuzZX+ZMYo9wHz8 jxoQdT7UbCuB6qTKZVNsgq870wbvqyWtS9fgDkC1pdPY/w9oafaaSHCzOWjUsrTNtTfc Xpz3eEir9JGfEjnspbQELooE8766M5YsVbcVyGiOemetGAP2QvnYDh64yQLZm95qGJvY JPba2S9oPPJEwH6n57bXIOfX/hA9AGExw5dE6enPbQv6L63hC0uKl/tGcS0yrQcydvx9 PKA0YFVvRDnQ5U0bPBDiDy1PUvlDToBp6TMbqI9/993y4We5VdsXpy7rjMsgI5iYnFxe +wow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783086953; x=1783691753; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BJMENLToTUHqriCNJNskYp7DzZMWsbfXaZUpesqSU/U=; b=ZNDGJx2um4r610HMB5v2NId242kPsMjRhyL+sIEQQy8QtUfjCmZatfqNTwG5rYZzNO NlBrT9dnCzU0q5pGrtKni5k9l8lN5/IxQ9yVVDpeDX5g9qKaHKgSGwEwjEG9w+XPSNiJ schP1eYbX87Bj/H5Mdi1+ziQCprWlMadBE0fRqq3U90zvsXEX6QAtAbNl0XAwSmoZAwW oPTCHMEvJOZJoy13AZn9UapXJddAHBjfuoxn1x5Xn74Zt1zdhVZPqVUUUnMs4e4fw90o WPTqNNSTWxiFzkFx8jXPnRNJWuYN6Vms9MjV7qGi3MHm21iAG6uAE7zmnZJ+dIuzVGcG AQyA== X-Forwarded-Encrypted: i=1; AHgh+RquPKNjkR04Dsnk7Qt3BltQrM4zVw+GqmYidIH8kv5l/U3n/Bcg39Bz9xRB2yRku7m3NV/qtw2Oiz+uYfc=@vger.kernel.org X-Gm-Message-State: AOJu0YxPXgDrKGt5AgLnZ33OOqQUH2/pFRFDdkR3PQU1Di5Rnq7q8PXs +IdnREgBzd1Fves6arju3L5g0jR0vYkBqpfBtn7VcYcXR0bMHiJ6arCQ X-Gm-Gg: AfdE7cko40Adrs0E2uidVUFg55BO15CuawdGC454auaPILLyCtT6kky7NYWj4Fgh4lc 92a3ceNUux5okXTMthOTyzvDlrUE3s+RH/B8Rk0HzLlGfHgjTSH/z6rhQPZWfl4BuKBRqSIPfXt 6ZYKbPuUjZJ+QRuULVnPEmkBaxfL8t1BrdSZxY1RbOdV2nn7XkjA+W74n+ACFO1wqVdGJzA/qdF Cq34XvEBmqfCEWSxGvndTU/IZvM1Kwz0gyfMvP/ECb7ri+kY5Ph3z2K0fD1Ic+eGs5YvkvC0+Qe hskYZlQxXEbEc9RH230/IbHVjLXYraVZNQs4wOMulCwUr947hQyVI5yCIUiVV9rB/E/54AK27iK xBfbL1I/+tA0fbh4XzgBy7xN3cql5zH/14mj3GeN2v+4y+1OjCMsnuOmxhIqxjvxuF0wZI/DlHD alSVwqfPT8Gw== X-Received: by 2002:a17:90a:e7cd:b0:37f:133a:3e02 with SMTP id 98e67ed59e1d1-380ba74883fmr10291045a91.0.1783086953150; Fri, 03 Jul 2026 06:55:53 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:4288:f1d2:acae:80f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bb80f5csm30995649eec.15.2026.07.03.06.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 06:55:52 -0700 (PDT) From: mdshahid03@gmail.com To: Dan Williams , Vishal Verma , Dave Jiang , Alison Schofield , Ira Weiny Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] nvdimm: ndtest: remove redundant NULL check before vfree() Date: Fri, 3 Jul 2026 19:25:13 +0530 Message-ID: <20260703135513.75840-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid vfree() safely handles NULL pointers, so the explicit NULL check before calling vfree() is unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- tools/testing/nvdimm/test/ndtest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c index 8e3b6be53839..2051ad5d4882 100644 --- a/tools/testing/nvdimm/test/ndtest.c +++ b/tools/testing/nvdimm/test/ndtest.c @@ -376,8 +376,7 @@ static void *ndtest_alloc_resource(struct ndtest_priv *p, size_t size, buf_err: if (__dma && size >= DIMM_SIZE) gen_pool_free(ndtest_pool, __dma, size); - if (buf) - vfree(buf); + vfree(buf); kfree(res); return NULL; -- 2.43.0