From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CADC3E4C84 for ; Fri, 3 Jul 2026 14:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783088883; cv=none; b=gptj075bdCIHfLNJmALvUhu91Y1+TqoM6RTHVdauV2QmTplcJI8h+7WSr4nA2bP6OAtVw5fU1WX5/gLhOr/tRAx7Q4mmeT/o4YHgX8ABv5JEacpxOUmftLNMcJBoN3G7bdkbY4PPp9oaZ3rqZwM4DG8qrscS0WYde9lZ5WdJkc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783088883; c=relaxed/simple; bh=kbelsoGEQPAT+SCNNQXyDHY6zjhC5hvzloU6QQffXgQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=HcyPY8Inu1L7IxP7ow5O33AsCOLRsO1AUhAEeZYX17+syrb+xMiuQ0d1Ly6cGUmvhvqzEVnFgcmgi0kXecmqJwzmpkfXljsNCdZY2Hea6Bkbiujnxx168n2sIxZ5Sz1MSSkmGeV8jiGn90ZsE3LWCQZBYIjVHfVE5+fXYSoT3XU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nHqttR4Q; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nHqttR4Q" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47362928f65so627068f8f.2 for ; Fri, 03 Jul 2026 07:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783088877; x=1783693677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kv5yKiNtIV+UqN4ctXabi1ct/jkVoHU5ZKLfAIDfR8w=; b=nHqttR4QWdWYXwIgyML1vMB/tltHa0DwGXEh1tlT/6cIe7kCZzQpfiXr8m7LgIdUFg NnYGwpUQNXB3OoMmKlGcCOR2Nd7BK3T4dmauB6In8RcxMPqF7JNUBm9FFxeDMkFs2PtL XKSC05VOMcC0J38890L+bVDtVBXEQUNf8GL6A8GNtmWNxtp62iVAwQmP4CVdsrhthNC2 y5nrophnlnmEAjsj1GkRuEdYpsWxuAv52CBK8LtrmwVjHT66rYGQfbtuzn4pKhdIZ+6k bM6M1saOChi6fgD9iURNAw0f9fPb+j+oAwSzH23rGEJLjUQQ0FwqvRcNYqtEdURThspi 9JTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783088877; x=1783693677; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kv5yKiNtIV+UqN4ctXabi1ct/jkVoHU5ZKLfAIDfR8w=; b=hco1yRRREDbwX8QIsBNieyYfzt5dsrGvejoxJEj6gP8PmzlGari2IH92yjjWvD4+/q Cg+0dPh/HfEiLRtiN30k9dyTRLtddQ0+zSaVEr+26WVSd6Fvm/nMfCzAdMbXShWPR4N5 hLjh4wti50AR6E1fBYwqJc01Xs2f6Miu9GM8v7OuVAoBOIJecatEb/+fpAfNmj61Rh2G r+EfHfHGzTMZLkKtos1PvSwFEygWEuUfdYPWNJy40VJXTXgPpkFP978gyAC4HsAe7sMH 9XU3GlFw5XF5iLC1Gd/qZDNYf26SEm0WTzMDVIbCAz9/0nDszqCgBtqYjkGj23HRoNvV X9Vg== X-Gm-Message-State: AOJu0Yzx7Yh5F5DHbnEwIioAZWtEJLvHqnZfXXVB3c0qWToMpe0+Yk85 LDi1MOpUmMBkcicmCL+w00J0okYrktor6JdR54fp5fTKdFkBMkooaeT/Rhi/gg== X-Gm-Gg: AfdE7cmF34o4u4UeEkh+iUI/mkWCUpHN4p7cjXMrU0xPFgLAYu3Nn+/phHBmZAZFp43 YIoOdBZNVajbwXuMJHMZis2dPC4ZPuZyzUpeD6DiYl6aEEge5Pg42T+rxR49wSgGXMxgHhW/YcO KvNtq5UEi0uaZ1PvQvIOot4dykGM1+amkd6EIsOdEVu7t5cc9dumH/4oalsN9iuFfXWOQQ6AngJ 6FYVA9MC9DHWIefs4rJVjwDEeaOdJvkBQofZJ8zVKpiacEUncuQAUu3FVaqN5uwYjbiX7wsQRjD h/ynyM8Nk9p+M/Yyd/t/SfSADGvOWZ7e7tFwoehhXGSt9ZzW2lcsVly0Jp4THYbvKVtdE+i7H16 SwWFxL0Pj/Kgs60M1bnzM6BLPi7BH0Y39KLiQUZv4QHaHpWl0zWOpbE9CQM6zSVHrsaypgCJxd+ EJTG/ULER1eks= X-Received: by 2002:a05:6000:430b:b0:472:22b4:fd6c with SMTP id ffacd0b85a97d-47759c268dcmr15656605f8f.8.1783088876733; Fri, 03 Jul 2026 07:27:56 -0700 (PDT) Received: from fedora ([94.73.45.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dbb01sm18601702f8f.1.2026.07.03.07.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 07:27:56 -0700 (PDT) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, boris.brezillon@collabora.com, kees@kernel.org, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v2] drm/tests: shmem: Set DMA mask to 64-bit in drm_gem_shmem Date: Fri, 3 Jul 2026 16:27:23 +0200 Message-ID: <20260703142749.4099-1-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: José Expósito drm_gem_shmem_test_purge [1] and drm_gem_shmem_test_get_pages_sgt [2] intermittently fail on ppc64le and s390x CI systems with a DMA address overflow: DMA addr 0x0000000100307000+4096 overflow (mask ffffffff, bus limit 0) WARNING: kernel/dma/direct.h:114 dma_direct_map_sg+0x778/0x920 drm_gem_shmem_test_purge: ASSERTION FAILED at drivers/gpu/drm/tests/drm_gem_shmem_test.c:330 Expected sgt is not error, but is: -5 The call chain leading to the failure is: drm_gem_shmem_test_purge() / drm_gem_shmem_test_get_pages_sgt() drm_gem_shmem_get_pages_sgt() drm_gem_shmem_get_pages_sgt_locked() [drm_gem_shmem_helper.c] dma_map_sgtable() [mapping.c] __dma_map_sg_attrs() dma_direct_map_sg() [direct.c] dma_direct_map_phys() [kernel/dma/direct.h] dma_capable() Checks addr against DMA mask -> FAILS: addr > 0xFFFFFFFF The root cause is that KUnit devices are initialized with a 32-bit DMA mask (DMA_BIT_MASK(32)) in lib/kunit/device.c. On ppc64le and s390x systems with physical memory above 4GB, page allocations can land at addresses that exceed this mask. When drm_gem_shmem_get_pages_sgt() attempts to DMA-map these pages via dma_map_sgtable(), the DMA layer rejects the mapping because the physical address overflows the 32-bit mask. The failure is intermittent because pages may or may not be allocated above 4GB on any given run depend on memory pressure. Fix by setting a 64-bit DMA mask on the device before calling drm_gem_shmem_get_pages_sgt() for all tests, following the same pattern already used in drm_gem_shmem_test_obj_create_private(). [1] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/2643976103/test_s390x/15128551935/artifacts/jobwatch/logs/recipes/21561049/tasks/220716793/results/1014626315/logs/dmesg.log [2] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/2643976103/test_ppc64le/15128551933/artifacts/jobwatch/logs/recipes/21561041/tasks/220716705/results/1014628163/logs/dmesg.log Fixes: 93032ae634d4 ("drm/test: add a test suite for GEM objects backed by shmem") Closes: https://datawarehouse.cki-project.org/issue/5345 Closes: https://datawarehouse.cki-project.org/issue/3184 Assisted-by: Claude:claude-4.6-opus Signed-off-by: José Expósito --- v2: - Move fix to drm_gem_shmem_test_init() (Thomas Zimmermann) - Link to v1: https://lore.kernel.org/dri-devel/20260703063517.6346-1-jose.exposito89@gmail.com/ --- drivers/gpu/drm/tests/drm_gem_shmem_test.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_gem_shmem_test.c b/drivers/gpu/drm/tests/drm_gem_shmem_test.c index 44a190109249..6e6b4f4902c2 100644 --- a/drivers/gpu/drm/tests/drm_gem_shmem_test.c +++ b/drivers/gpu/drm/tests/drm_gem_shmem_test.c @@ -94,14 +94,6 @@ static void drm_gem_shmem_test_obj_create_private(struct kunit *test) sg_init_one(sgt->sgl, buf, TEST_SIZE); - /* - * Set the DMA mask to 64-bits and map the sgtables - * otherwise drm_gem_shmem_free will cause a warning - * on debug kernels. - */ - ret = dma_set_mask(drm_dev->dev, DMA_BIT_MASK(64)); - KUNIT_ASSERT_EQ(test, ret, 0); - ret = dma_map_sgtable(drm_dev->dev, sgt, DMA_BIDIRECTIONAL, 0); KUNIT_ASSERT_EQ(test, ret, 0); @@ -352,11 +344,20 @@ static int drm_gem_shmem_test_init(struct kunit *test) { struct device *dev; struct drm_device *drm_dev; + int ret; /* Allocate a parent device */ dev = drm_kunit_helper_alloc_device(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev); + /* + * Set the DMA mask to 64-bits and map the sgtables + * otherwise drm_gem_shmem_free will cause a warning + * on debug kernels. + */ + ret = dma_set_mask(dev, DMA_BIT_MASK(64)); + KUNIT_ASSERT_EQ(test, ret, 0); + /* * The DRM core will automatically initialize the GEM core and create * a DRM Memory Manager object which provides an address space pool -- 2.54.0