From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484C83F4DF2 for ; Fri, 3 Jul 2026 14:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090165; cv=none; b=EfDOyzofAxLkW1qW8/l68uaLLWhU252BccQyk6JdLuYOZgMHQm9PWfseGYrq4Y2yBSKaAegQCFwfBo93rp+4a3vkaDcs+3V2gJxOc/EcYmNnKG3Ol7VFo+kfM9dUXNTS4JoDWnqmuD69WfScx+Q6PoCaGL2VGjhPslYgJEw3TcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090165; c=relaxed/simple; bh=uRid3eL/VxSq3eZBqfbHBU9T31HrNfJLPuY0heyVGSs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=L/SdUHkxSB9/YeEroKkeuHofq48UbPYJObAz25IZcFZFexnqVHgmqxhL3eT9kLMSGwEEcmN2gXRyrIhiCCt5IZSo9wYmBdHqwCX8hdbtwMvrUTEVlxK4+Qj/BT5Ym9y7yMKyX5uEr9nlMPvqA2cqQfGFGmY4bnHQKLRiQsehbzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LPQvnJ3m; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LPQvnJ3m" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c9aaa90a791so498261a12.3 for ; Fri, 03 Jul 2026 07:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783090163; x=1783694963; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DbbkU6ft1I7DR2Zuvn/uSRD/TRkfhQXU+lS2f73m8xQ=; b=LPQvnJ3mmfIgvkn6RFJjNoVGYYqkWKpWYqVkqA09wKRE0dnX/qTZyTUYVg8rT2i9OP rRRnhZ9N3LXb7KeDSpHBZBl1Mkfe4K+lCsbpgXbaNBfNn8Sa/4aZDOqc0T1JjBO5quGJ HVUEfVFbnaeE5HpWQTX35yu7Gmf6xzMSg5Yj7ueftBkEhT4TPjLIta+5TxmkZ8jkH/No 1fozZPPy098MMQpjY7rFFWV4oDQ+ljv8GE7xQUlcD5u20aznvETVBdFWRC9kUr1RWHJT lT1lgzRuFwijL1rHeywse5taKAwCoEecDVBjM9tdeqCfHIrkKYdgzpUuaEEWJTV7FOFx drwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783090163; x=1783694963; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DbbkU6ft1I7DR2Zuvn/uSRD/TRkfhQXU+lS2f73m8xQ=; b=Fqj255walduMV5IMEftGc3JCCY4ostDVE7YURsG3tpQpxwNh7y372WQ8yHn+yCa3Ck iNRvpQAAgLHP6vJR0sbQ0l6fNo72aF0SQSvzXjwy153kIt61bwWL6D5R1ixb0oBLJa65 obmwP6jCY3nYzRcUmGaO5r3MfCAz59p5sfub85xZdaYal10J81KGZ+u4QTmS5rT1bTYR nctjb59TkH66qYeLg6LjpcaHQXjDSAHQQluAZDjFgB2oIslhfpnZOxIi9WNii+fEH6fi d82yFrHbNfsZ8l7r2PR/A1UdbW0nFvw9ysV1n7g1PULrfGPww1pxhzpcOWFbSU733oYz CHHg== X-Forwarded-Encrypted: i=1; AFNElJ8Udd4aVFduegAfnkpu6i9fS4H4y5+PoDWVeDxoIjeCqnk31Y+TjTD0CNo1X7E6bwdVQstmP5K1WUE4+8E=@vger.kernel.org X-Gm-Message-State: AOJu0YxjIXsFPoBwZ3oTVq+8Z5EkgSJ3M/znVp9NMdN+wzk3mGAmVzfZ n8JLHuO5CkeCSBAN53ftsmiiTIpPco9qsZRCeOFcrQSCewvqzQhxvVVO X-Gm-Gg: AfdE7cm2kgS+OoueM51Acn/muBtPgJVOBOUYKAUz30uU7jQqdHj2axG4zq+90zFlpox YC6H0enNcJnUpwJkn0dYiund7Vj4h7oTuOYhfc8oyBXm0PpKekJP9spJM3pguy6o1mv00Y8Whr6 4DPtjxqVZKotLudXHqZyDf7RHPNHl5Dy1IEsyv13kIAbwRn1DRqxI4FoEQwgx7rCkmxCuBhQ+EY mLaNy9g0ZD75cp4vGKqiFmlPDkNNEVtCu6JRT8LDZTzwjKcFFYxqZesqAGCP5J30e4af2/36i1P KOzwubEpq7P5c+qiE6LfOiXNWzjdJ9Jj5qDlh9bZCSPNFC6+vvih4hDsIXUj/ei06mVMxsqHnka zR8YGh3FdP5C4xZVz06WdkaW7+NnbYlPnxbBXE64YoL9VUGgeoFhQst2Na6usC9mfo5LMj9zAP8 Uep4+cGgA3Ig== X-Received: by 2002:a05:6300:4c:b0:3bf:b60b:da95 with SMTP id adf61e73a8af0-3c03c717507mr139694637.60.1783090163488; Fri, 03 Jul 2026 07:49:23 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:4288:f1d2:acae:80f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f3b252222sm1662490eec.23.2026.07.03.07.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 07:49:23 -0700 (PDT) From: mdshahid03@gmail.com To: Dan Williams , Vishal Verma , Dave Jiang , Alison Schofield , Ira Weiny Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] nvdimm: nfit: remove redundant NULL check before vfree() Date: Fri, 3 Jul 2026 20:18:51 +0530 Message-ID: <20260703144851.80309-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid vfree() safely handles NULL pointers, so the explicit NULL check before calling vfree() is unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- tools/testing/nvdimm/test/nfit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c index f87e9f251d13..009fe107b0d7 100644 --- a/tools/testing/nvdimm/test/nfit.c +++ b/tools/testing/nvdimm/test/nfit.c @@ -1644,8 +1644,7 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma, err: if (*dma && size >= DIMM_SIZE) gen_pool_free(nfit_pool, *dma, size); - if (buf) - vfree(buf); + vfree(buf); kfree(nfit_res); return NULL; } -- 2.43.0