From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202573DDDC1 for ; Fri, 3 Jul 2026 15:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091303; cv=none; b=OppthdsgRSS4KD0dM8IScgHIiWDHZVyokuds6NVLcMA44puwhMpKkejav6MxT56Xulme+EZOzxPE1Uf8+SRmfqvdu2brsNMEBG7Wn/dwcEbsV5aycdNzdBEdxGXoyCeC4sMVsmy+kD45HR4REjl+3+DX3vTgn/GKi7S/EHCN7VE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091303; c=relaxed/simple; bh=4mOfeWap739uJDDuuZVgTjvZuL6oqW9+az7NIQAkLMk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=bfl+b54DLl1XR1+EEwDOKEAH66xUGhIh637rMUZ7wltombmhRkloivi/aPoHyz5lxRY6HijOHZtC4v4MzaQYcJEMIau2Sz3ECjctgBx9fG8MD2qvYcIcYnjmH6TkHgnu46C71vwc8/om2CcWQ3yPiT8UDh4R3ao+rbEftMqum+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TJV0fMpw; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TJV0fMpw" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so4790305e9.0 for ; Fri, 03 Jul 2026 08:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783091297; x=1783696097; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KO+r/wNoYbU1sjvYFpHZJ/Ol+Vzi+WjeZ3CRuNPxCww=; b=TJV0fMpw0JMOHpCZ5sn78QCX1kz8ObwNGqvWTtmsuPy1dMXy2eV+UiSk+Ki5YdRt5l cGoL2jSPxgCAjmdXxbqp4SkvCbd1INFJWCjXxxethSoa/6N8a1F0epbGt0tXsnL8YhN4 JgH9As2fUHywvmSRSW7GZ1dw04OveUzuckLmia59sc/oZNO2WjkdXubgvaSMQ9OVeCW0 vALfWqylOCIq8JAPQXWW/5KFdfJ7AKQ/GjRiWw+d4UzoRJfURo1F/V1g5Q2mid+O4m1E IUBE3TFip2cdq+AnQIiDt4ffh02othW6/MLQCvlVdAyuAd0m7nJyVtDexSxNUFRCl6Xe UHrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783091297; x=1783696097; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KO+r/wNoYbU1sjvYFpHZJ/Ol+Vzi+WjeZ3CRuNPxCww=; b=He+HVFcosGe6XFoN+rAM296TnXIQAEWP+ZuQz1/7WHDfdysvMj9/He6a5WdnAyfiaH eceqgnyfkRYJbplpIO9Q1VPsVP2DyzANcPRHU+wpEbrr/lQPjVfqxDjj4J213cpG/Nbc j9MezKDuYUwJcod3Oe7rpKxIhyf4/RRqVttKcMlblX3U1dm0UQBn7ij/V5y3nOMPv7XZ uSrPnj1RXjDKKwBguL/A3nhU6WqSHzPsGRZe8orU5JestW0DmgowCasRl28t8tMaN6kL MmAGCq6oECPmo/uivnCZPt6m9nITWdlooBDJY/wVBGwYr/jagLbFZjfpt21EepBRxQ2u pA5g== X-Gm-Message-State: AOJu0Yzqg2+BW8vCHKRONHN/EKv9ZC7a4UqKWb6A1jn94mW9SOShfuxK wzcF8kVTUevabOOQSdvxQJYc3W7xkM2JT5qiJR3q4RqF6Jjw+zMD2gqE X-Gm-Gg: AfdE7cmK+vljpafuGkt/HSJ2K+Wms8kMEaNrJ9Rx2Ye40FwwXmbEjysR4Hmbzc13XAW L/+lpgEqmeWR9XW6G91KkljclWJ/vB58E4q4gZJxwtyB0/pWGSBUm/ImhMuSJO3lom5Z1DdkpsT MT+yNFr/5eLJtbbhScSYkJyguaqV49o/7HkNdP7XB2FiQSviSjIIA0ybgJJsjwcrVmhmnCsJr3T 1Sl6OSgcDT8EL/Y51KjHCurKPAsRD3p/cm6scfdzwo+6c0ZPDIyA5AyMu0tuvvrRvFa3ulnWEAI 7Z5JUjidT6W15xjYBtOiV96fHqGNVroyPOabWrhEtK/xuLolY/PF4jX5UQvz1gWXulhTsa+iVdg U1/78K0c3EPbT+4WBE0hHCGQLXNnC5yhi0RITK+TvvXtH79CaxoqP+QrAdYaMm01DnAQtDjm+yu 3GO9LDDbqnP5yDnIcithPEfA== X-Received: by 2002:a05:600d:8649:10b0:493:b7a6:3dac with SMTP id 5b1f17b1804b1-493d0f3c959mr2267395e9.33.1783091296588; Fri, 03 Jul 2026 08:08:16 -0700 (PDT) Received: from fedora ([94.73.45.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63172fesm240585665e9.0.2026.07.03.08.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 08:08:16 -0700 (PDT) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, boris.brezillon@collabora.com, kees@kernel.org, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v3] drm/tests: shmem: Set DMA mask to 64-bit in drm_gem_shmem Date: Fri, 3 Jul 2026 17:07:43 +0200 Message-ID: <20260703150808.3832-1-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: José Expósito drm_gem_shmem_test_purge [1] and drm_gem_shmem_test_get_pages_sgt [2] intermittently fail on ppc64le and s390x CI systems with a DMA address overflow: DMA addr 0x0000000100307000+4096 overflow (mask ffffffff, bus limit 0) WARNING: kernel/dma/direct.h:114 dma_direct_map_sg+0x778/0x920 drm_gem_shmem_test_purge: ASSERTION FAILED at drivers/gpu/drm/tests/drm_gem_shmem_test.c:330 Expected sgt is not error, but is: -5 The call chain leading to the failure is: drm_gem_shmem_test_purge() / drm_gem_shmem_test_get_pages_sgt() drm_gem_shmem_get_pages_sgt() drm_gem_shmem_get_pages_sgt_locked() [drm_gem_shmem_helper.c] dma_map_sgtable() [mapping.c] __dma_map_sg_attrs() dma_direct_map_sg() [direct.c] dma_direct_map_phys() [kernel/dma/direct.h] dma_capable() Checks addr against DMA mask -> FAILS: addr > 0xFFFFFFFF The root cause is that KUnit devices are initialized with a 32-bit DMA mask (DMA_BIT_MASK(32)) in lib/kunit/device.c. On ppc64le and s390x systems with physical memory above 4GB, page allocations can land at addresses that exceed this mask. When drm_gem_shmem_get_pages_sgt() attempts to DMA-map these pages via dma_map_sgtable(), the DMA layer rejects the mapping because the physical address overflows the 32-bit mask. The failure is intermittent because pages may or may not be allocated above 4GB on any given run depend on memory pressure. Fix by setting a 64-bit DMA mask on the device before calling drm_gem_shmem_get_pages_sgt() for all tests, following the same pattern already used in drm_gem_shmem_test_obj_create_private(). [1] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/2643976103/test_s390x/15128551935/artifacts/jobwatch/logs/recipes/21561049/tasks/220716793/results/1014626315/logs/dmesg.log [2] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/2643976103/test_ppc64le/15128551933/artifacts/jobwatch/logs/recipes/21561041/tasks/220716705/results/1014628163/logs/dmesg.log Fixes: 93032ae634d4 ("drm/test: add a test suite for GEM objects backed by shmem") Closes: https://datawarehouse.cki-project.org/issue/5345 Closes: https://datawarehouse.cki-project.org/issue/3184 Assisted-by: Claude:claude-4.6-opus Reviewed-by: Thomas Zimmermann Signed-off-by: José Expósito --- v2: - Move fix to drm_gem_shmem_test_init() (Thomas Zimmermann) - Link to v1: https://lore.kernel.org/dri-devel/20260703063517.6346-1-jose.exposito89@gmail.com/ v3: - Improve comments (Sashiko Bot) - Link to v2: https://lore.kernel.org/dri-devel/20260703142749.4099-1-jose.exposito89@gmail.com/ --- drivers/gpu/drm/tests/drm_gem_shmem_test.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_gem_shmem_test.c b/drivers/gpu/drm/tests/drm_gem_shmem_test.c index 44a190109249..5e69ff1d1ad6 100644 --- a/drivers/gpu/drm/tests/drm_gem_shmem_test.c +++ b/drivers/gpu/drm/tests/drm_gem_shmem_test.c @@ -95,13 +95,9 @@ static void drm_gem_shmem_test_obj_create_private(struct kunit *test) sg_init_one(sgt->sgl, buf, TEST_SIZE); /* - * Set the DMA mask to 64-bits and map the sgtables - * otherwise drm_gem_shmem_free will cause a warning - * on debug kernels. + * Map the sgtables otherwise drm_gem_shmem_free will cause a warning on + * debug kernels. */ - ret = dma_set_mask(drm_dev->dev, DMA_BIT_MASK(64)); - KUNIT_ASSERT_EQ(test, ret, 0); - ret = dma_map_sgtable(drm_dev->dev, sgt, DMA_BIDIRECTIONAL, 0); KUNIT_ASSERT_EQ(test, ret, 0); @@ -352,11 +348,19 @@ static int drm_gem_shmem_test_init(struct kunit *test) { struct device *dev; struct drm_device *drm_dev; + int ret; /* Allocate a parent device */ dev = drm_kunit_helper_alloc_device(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev); + /* + * Set the DMA mask to 64-bits to avoid intermittent failures calling + * drm_gem_shmem_get_pages_sgt(). + */ + ret = dma_set_mask(dev, DMA_BIT_MASK(64)); + KUNIT_ASSERT_EQ(test, ret, 0); + /* * The DRM core will automatically initialize the GEM core and create * a DRM Memory Manager object which provides an address space pool -- 2.54.0