From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CCF83D9541 for ; Fri, 3 Jul 2026 15:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091481; cv=none; b=jYp5wOqihI4OgXQiilIjV2aHz4Wov2rT0CoEzE2BJFNeAKeL/9rEPrhflA77vAWKj631si65IhpviHM6DYyR31NSifdLEXDv2GVAji95cbrl+L86UQMzMHa/UAgpcmfylNQ043STZXrz9LlP3Tr+q7PUxrBBCUBd7Ee3ZMstflY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091481; c=relaxed/simple; bh=Q5SXDy1vjIYzIvPuVsZ0KuIDDA+irXcZPF5lR7hO20M=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=XXny1FbGPSd72KFAdwjuT9UnwcDd0r/RqJuM52+s7iYU8Y4T+dGxn7eJpdWMnHxjkWfqRh9Js3pawRW3wLM/Y5BxyYODinjdPe4HzFUNpWwkjLF3jRvSFmnJv25dNfvjyr13LmzRDK4B0aBXelKSQEyEmUE0WUe+5v1zUitBzZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rFezSeaf; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rFezSeaf" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-493b0a5e636so6159195e9.3 for ; Fri, 03 Jul 2026 08:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783091478; x=1783696278; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=QtTN57AzzUJ6dugw/eqNCQrlE5alAfMnwqYEMx2fXnI=; b=rFezSeafpM8PHu21qBu0KgQ0b3gkQxsracQPON/kTnKZAYMGvqHYyX4rSHow9Uinss dj2l4ceiF/joioNvqTXkFZOOS/vrYKV02r7X6ZzrOqcJxhINpYew0jJCNZi4Sd98D7bE YIZObtWvJECQSaMTi49cRuH00Ved1yuNyXhpMq5/hMlnQ5MOPiswCsju0I4+BqngQiu7 ozYOPHswcfU1VrmoiOQ+Inws45FE50BjwKVv+UwoCzaxOjJRA6SqNIAjaQi19A6nD7oY zAVyAKGJq+ZwZqF2SbQLSML18trfcJX74+Kb7xhHtg+dqB1UKpFhJMogFPtrDe+lf6bS KYbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783091478; x=1783696278; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QtTN57AzzUJ6dugw/eqNCQrlE5alAfMnwqYEMx2fXnI=; b=hchP34HN1sdW76C/7f185ECYyDIkAlJC771d0ECCWoWaXVIVGVj3EDQb85u1IEnlSb 3jweY7EHTnaKAeKF9tUvUAKggSTIp4NZKj0DUrOjegfCzyHC1jlxmwxrHvGbaCJ27rZg BkKTvCG6xmmZsCWFkJ13K25qs9oYtEreMJYKxhEVw62L/AUrmDN4sQfCpwkFWMri7FzT K1B4SDSfFw1JSoOu2hVaXxj0yCJu4E38KAz02cAeCrFoRx8fHdGpiEEMl/BS02emvLCi EVsjNYCU5lqNF0HrTJayfVZ1rc8jl9UPc8ToOxLBEvjrPAXLlfkgFtNel1Z8Von57OCM gHmA== X-Gm-Message-State: AOJu0YyMJxQibMFEjo/Q+kRk/pmC4LYfwucHRNhXNd5OLMFvHL3iuqvF 5+ZUk6lxCkT0IYLznfu5Zt1/lHC7tpI1OoKlHBPl39Kxlrz2pw9cqpcr5Jrdlm0y068/IVEgIEm 1fmQE3aYmTqfPD8zSyua4DQ== X-Received: from wrmf17.prod.google.com ([2002:adf:e911:0:b0:474:4c49:fdb5]) (user=mclapinski job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3e06:b0:493:b783:ad59 with SMTP id 5b1f17b1804b1-493d0f3a7dbmr3246685e9.14.1783091477362; Fri, 03 Jul 2026 08:11:17 -0700 (PDT) Date: Fri, 3 Jul 2026 17:09:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog Message-ID: <20260703150955.3943082-1-mclapinski@google.com> Subject: [PATCH v2] ipmi:si: Add async init to ipmi_si From: Michal Clapinski To: Corey Minyard , openipmi-developer@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, Michal Clapinski Content-Type: text/plain; charset="UTF-8" Added a new config option to allow offloading individual calls to try_smi_init(). Saves 100ms on my system. Signed-off-by: Michal Clapinski --- v2: - instead of offloading the whole init function, offload just the individual calls to try_smi_init() I didn't implement the periodic retry feature that was talked about under v1 due to my lack of expertise. LMK if this is a deal-breaker. --- drivers/char/ipmi/Kconfig | 9 +++++++++ drivers/char/ipmi/ipmi_si_intf.c | 32 ++++++++++++++++++++++++++++---- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig index 669f76000197..c8fa445c1c17 100644 --- a/drivers/char/ipmi/Kconfig +++ b/drivers/char/ipmi/Kconfig @@ -67,6 +67,15 @@ config IPMI_SI Currently, only KCS and SMIC are supported. If you are using IPMI, you should probably say "y" here. +config IPMI_SI_ASYNC_INIT + bool 'Asynchronous initialization of IPMI System Interface' + depends on IPMI_SI + default n + help + Offloads invidual SMI inits. It speeds up the boot time. + It also introduces a very small risk that something else might fail + if it depends on synchronous IPMI init. + config IPMI_SSIF tristate 'IPMI SMBus handler (SSIF)' depends on I2C diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 9a9d12be9bf7..504d5b8636ba 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -39,6 +39,7 @@ #include #include #include +#include #include "ipmi_si.h" #include "ipmi_si_sm.h" #include @@ -2174,6 +2175,17 @@ static bool __init ipmi_smi_info_same(struct smi_info *e1, struct smi_info *e2) e1->io.addr_data == e2->io.addr_data); } +static ASYNC_DOMAIN_EXCLUSIVE(ipmi_si_async_domain); + +static void __init async_try_smi_init(void *data, async_cookie_t cookie) +{ + struct smi_info *smi = data; + + mutex_lock(&smi_infos_lock); + try_smi_init(smi); + mutex_unlock(&smi_infos_lock); +} + static int __init init_ipmi_si(void) { struct smi_info *e, *e2; @@ -2219,8 +2231,13 @@ static int __init init_ipmi_si(void) break; } } - if (!dup) - try_smi_init(e); + if (!dup) { + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) + async_schedule_domain(async_try_smi_init, e, + &ipmi_si_async_domain); + else + try_smi_init(e); + } } /* @@ -2253,8 +2270,13 @@ static int __init init_ipmi_si(void) break; } } - if (!dup) - try_smi_init(e); + if (!dup) { + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) + async_schedule_domain(async_try_smi_init, e, + &ipmi_si_async_domain); + else + try_smi_init(e); + } } initialized = true; @@ -2401,6 +2423,8 @@ static void cleanup_ipmi_si(void) if (!initialized) return; + async_synchronize_full_domain(&ipmi_si_async_domain); + ipmi_si_pci_shutdown(); ipmi_si_ls2k_shutdown(); -- 2.55.0.795.g602f6c329a-goog