From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap4.hz.codethink.co.uk (imap4.hz.codethink.co.uk [188.40.203.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A912E2F8EAC for ; Fri, 3 Jul 2026 16:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.40.203.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783095844; cv=none; b=UnL09Q7WyaFetwOdd0S+6FV5BstjdvArFc/gbVJsKNajxjkBAjvr3QhzPMZa9LgwuMtxx+78f1vcMVoXcEnKGq7Z5DO+f02+Vzh3odQHPxGix2Jd9czRw2xozb3UjyTzDSkwoSr1JDtfgjs/mRiYRSVqvp7SYi1pCMKn2KCUbeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783095844; c=relaxed/simple; bh=ECfjWTN7vigUoAl6isrBW6LDBoOeLZ5e8HP6awuHlE0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Bdd7QMqhX30s7rApJXOAWNXqChbwlz1YRtP/S+9TTR9ix3z5tsJQfiBKOpI8bIIyGZ1zTn1JYWvutiorFGo+180xaeSZ2MMLX/LoHQnhVCkv6ayx8GqUrkRPSv0sJDbrTMWsTr22uqXXsiHgZL/gC7YXSVWagf8M8dDj98nIKVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.com; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=Adc/QN9m; arc=none smtp.client-ip=188.40.203.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="Adc/QN9m" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap4-20230908; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:In-Reply-To: References; bh=Njtjf1i80jiwsx4tH+XPD/0oObtiwzZtrIXREWvC9jI=; b=Adc/QN9mgdZ21I nXX5EgwMx04HUhu48Let/InbZuHlpFMdMw8uviTAwmJacGu61FpkDWV++00yYfSpjXWFFmQM4MlSO V8EWNCGst5/HoaOxYPBT8X2v+Kf9Qeq3goULW87cuwLU1WGLaw0gCCTH+AQSEQt5G7CMqKPegR5YI r+fQVnzgF2r7Yf758HujVN0nyweawvg+oora2EfPoFqrEv4RcY1Bucz636tM5Nrty/M+JhZXwTWBy dAzeNVsqNlqnTD/DD+tiWvjezRcHBknNfXsvUQCKbDgNTU6XU0j6gIdVrbkxaF6HyPfulESBsL3na QEWw/ItH5iTDctsTAIoA==; Received: from [167.98.27.226] (helo=rainbowdash) by imap4.hz.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1wfgg0-00BZLx-Dv; Fri, 03 Jul 2026 17:23:40 +0100 Received: from ben by rainbowdash with local (Exim 4.99.4) (envelope-from ) id 1wfgg0-0000000BwuK-0Ww1; Fri, 03 Jul 2026 17:23:40 +0100 From: Ben Dooks To: Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Ben Dooks , Alessio Belle Subject: [PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static Date: Fri, 3 Jul 2026 17:23:38 +0100 Message-Id: <20260703162338.2848039-1-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.37.2.352.g3c44437643 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: srv_ts003@codethink.com The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c so make it static to avoid the following sparse warning: drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static? Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")? Revied-by: Alessio Belle Signed-off-by: Ben Dooks --- v2: - added fixes tag --- drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c index 6bb5baa6c41b..805d9f9bc1dd 100644 --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c @@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp) return 0; } -const struct kernel_param_ops pvr_fw_trace_init_mask_ops = { +static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = { .set = pvr_fw_trace_init_mask_set, .get = param_get_hexint, }; -- 2.37.2.352.g3c44437643