From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88BE230100D for ; Fri, 3 Jul 2026 17:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783100011; cv=none; b=bt0PVN/No2UV4jYw1X42aqTHHTqyfxN5FnTjQW/DfGArImTrqfUUrv4KLqtZMZJDPjDzSOeKWvH5IcvUXaqk6DLLRUywjHSVqCGvXhBaJm4Xsi0TxFn/cxc2ILp28ArJjHAOKdmdGpWI4o1TaW89SSB2IMHxI3FpyeKnzY5dDXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783100011; c=relaxed/simple; bh=4OaN38/+Ic68kJglERCsr+iFMu+H0uZi+FVKvPvEwcw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uxEbnZxgxzOSlA7nChqDyBaJxKiumSagkWT3Q5FLMDRsf2XQO/NAyu5ouAi51V+UfOHWLgOPIAwYw712m25c/XRRXlveQ911FnegTyNGTxPqzDhAvZCVRSnonuRpf5eQ9ixj9lKKgLmpmRVP3R96HgVAm8YGnVG0RiCLhYH/2Kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sRHak4Qo; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sRHak4Qo" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cacb8416a1so6052935ad.1 for ; Fri, 03 Jul 2026 10:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783100010; x=1783704810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=C6YIq9wieNEB248qZbJUVWSlhdHzHlBQDkP0JzLpC+s=; b=sRHak4Qo6LRNxw26HWbNjou0IZR2MZ6uOgN9/yAiDLUfSzPHPc/7qDCIbhcmc0Muaa /vkHqo19nwHCG+I0kCO4NKqbW8hAioDKxN39ftQy+Y3Jo0HodgDv2vbjdFHttRSdAl3T nGP6wczVIpwMx7JhsoUxLOoN6BniKRf0I6/NjWit2TIzNP7GyScg/sFRqckOkEFDGRIB iYDjF4VNfhf3iodx6p2lCoDX0X9O38NZS2w8Te5uEYYI8FGLHr+PPslEtR/FAvdD1QBu Yi3vvyD6b3x3ogcxfMpfU8Gk+1JX/+Xi2Yai18OfTQ6YN92dC+KeMwatSZhTK3JmX5yt mmKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783100010; x=1783704810; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C6YIq9wieNEB248qZbJUVWSlhdHzHlBQDkP0JzLpC+s=; b=PiocdyBwrn9OqOcTKhOi7toq5PBiQEN/No15ORj48TpVPnqI7Y6h8I+zEV+RSIUgJi a7xCKdiHs4xglSWIOw6+PsSdIF3FCzrzo9vWJZbTJMRnHsLyhADDIvINcTLQ//XgFqBo glVUZNSBOiB5I6Inh2rIW9ZfRGBTpT/V1N70l1/DHxIlZwIUVv9M22Zj9KaI+HxBI6wv p4y4TtDjoBaManfQNC88AtZHfVtVsrue69XGINoyBXukoZ8zxs+fjHMk7FD3ZJXCxyYH LNQrg1aRhuRUF7ydG33CokzXhpbt2Yno+KEP8Zk8GlkBJwHY755E0cgeSmk0LtcXY6aX gxbg== X-Forwarded-Encrypted: i=1; AHgh+RpqlLEOauD0gzVL/qbJzbC8mHo8Y0VJw8sf/7FLZcCPLCI8+VQ1G6j5I7D4lT6zmstheUuzyYC/+2mDZCU=@vger.kernel.org X-Gm-Message-State: AOJu0YyeK3kSFWZwN+TgKWKtrt0kkcoBBaObpbsvaLOVzU+YAa4L+q3o yxfS/5fTx33i39Btlf5WppGoGmuFSQwdkWmpht2/E697/Nrd7naXeyMJ X-Gm-Gg: AfdE7cmKZ7YTmyV1qeqznHp0ltejFpM4bG88AmyJ6Du7JtHBpLyhJpFY9e/wtE6zddv MBt4dsCCalu9foIHYCjP3vTB0V/yVSkOcd8Oadw5d5JfxjGB4TzwMGtxZ959fOiH7xUcqJ07CRQ Pb4W2fF+EZ2WxkT1Z4TSnYcJfaa/gz9p1RewID+IYm8obTiPefIvDsh3RFYcOOcXhZIQpOa/xVH hnVULD0poqR8wJNqAZUb9nK0EyJS09ya10b5XBAJzWrMEWRmj2HtAvNPOGqp31hEcHxRXeTYwJ9 FLdzqwlx/POLT7zCU2KPFMet9aidvScri0zgpX2wfptj50YW0N2fBfc0HfC3IwV9VFmUrTBCrJU 5P0N2oXo4VQorbmP1pCpy+psIsOUGUwRdxTXlcubs1EydLIKnKr6VfP9MmT8GyLniTgB/vSV1EQ X+e6YIUod2NQ== X-Received: by 2002:a17:903:28e:b0:2c9:b8b7:5d1c with SMTP id d9443c01a7336-2cbb9e254c3mr2131065ad.16.1783100009626; Fri, 03 Jul 2026 10:33:29 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:4288:f1d2:acae:80f]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c85bde6sm36353799c88.9.2026.07.03.10.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 10:33:29 -0700 (PDT) From: mdshahid03@gmail.com To: Namjae Jeon , Hyunchul Lee Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] ntfs: reparse: remove redundant NULL checks before kvfree() Date: Fri, 3 Jul 2026 23:03:01 +0530 Message-ID: <20260703173301.89289-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid kvfree() safely handles NULL pointers, so the explicit NULL checks before calling kvfree() are unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- fs/ntfs/reparse.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ntfs/reparse.c b/fs/ntfs/reparse.c index fa523dc3691e..ced4c675d91f 100644 --- a/fs/ntfs/reparse.c +++ b/fs/ntfs/reparse.c @@ -317,8 +317,7 @@ unsigned int ntfs_make_symlink(struct ntfs_inode *ni) } else ni->flags &= ~FILE_ATTR_REPARSE_POINT; - if (reparse_attr) - kvfree(reparse_attr); + kvfree(reparse_attr); return mode; } @@ -358,8 +357,7 @@ unsigned int ntfs_reparse_tag_dt_types(struct ntfs_volume *vol, unsigned long mr } } - if (reparse_attr) - kvfree(reparse_attr); + kvfree(reparse_attr); iput(vi); return dt_type; -- 2.43.0