From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 333A9339875 for ; Fri, 3 Jul 2026 19:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783107908; cv=none; b=JMjgL6GRP6rJdCIoj9MpPs4P9D3hUfA5FJDnMZ4TbdjaVcC6reuR95SkqnuWbbPWkXlFeAZFZ6sH++WO1pS5corAQsuD1Jv7RKmQ6H/LdXi8bKlc3mpotpKh5Wo9RXYEPOrsBkgMTbCmjyeFFhwbKCZYr7ebSJgcChsPvw+I7w4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783107908; c=relaxed/simple; bh=YCS3/Dpz0Fo4USHwvmuADURVgak+6qLUsiuuXpl8TrA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PDc8NLGrcto956vYp50gfTcmjpQ/acmUkBSoqki1fu5ajYA0c7aLY1ENDfDSMGKzTE4BhGF9JW9IPkxL7oZnLqaIzJPQiu1lr+4s2EB51290/ADzXlq4GPJQUoE7h/9iySu2hsS+2Z0HtoWe8WHkrqxCJH1xuXi0COxcFIjR6AU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I4lGk2E5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OIH22mIu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I4lGk2E5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OIH22mIu" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663HiODR676040 for ; Fri, 3 Jul 2026 19:45:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=wV2jvG58Lj5 Bs1ZlVjSXOSGXHXpRQv1KBOONp4Qs7fI=; b=I4lGk2E5mZ7Li8Ro5GPM2C07N9d b+pOUkiWJ+kt9dhiSiaU2EHDkbsvQyYnnmoK13NsOVmKzOUfpseFpxEEZMgop1sf V4Us6vaVFq4s2wpZA40NshGb0oPMAvVKkWnl+29Iw4tnYF6iVledRkC4P6hYTIWJ aIU87KPTR3fAYuK3eRfa+Jysa7aefGL/V7kSoHfrq7ZA5YmkgmN3YgJtDbXU04e5 XDiArJTWpNNC4h/1ik6zSYXTca60q5JuJiycl0z2+a6YO2+ERe+AcUdLChE29gz3 UssOdQ8699J8ukEPuMOk83jonBFYC42ozd39SRdIY6OCsowsNfKJ65bCjNw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6dkkh958-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 19:45:04 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-380ddac2b02so1246549a91.1 for ; Fri, 03 Jul 2026 12:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783107904; x=1783712704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wV2jvG58Lj5Bs1ZlVjSXOSGXHXpRQv1KBOONp4Qs7fI=; b=OIH22mIuwMHlNCeo0sWlRcfV9lk4xnVPY5ebLknveojI3M0i/jXXHO2wlizKUamVYl Lm92B0Gxv+EuGpy+sonhMSptMI90aJ6WKvIRcGBjwE5HGD9DSbWA70tlMweAyLr96/dT zvmNPIIiYQG6IjqGlh6tkzH751WbKDTQsHLIr/WIKjga84aKhWYBsu/pAXfYpRGMXHv9 Tw4uDySOXgAHQHMxX5FTsmV2J3Spiu+scI+ZVInO8pcj7m7dgPaAxbAfNNUu6ItHtZ2l LW2veo0jCKuGXFnYdOIsCJvMr8/cNmkNvji7GOtsVNoi+gA1fKYrLdFma1gsrRxV2aim puSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783107904; x=1783712704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wV2jvG58Lj5Bs1ZlVjSXOSGXHXpRQv1KBOONp4Qs7fI=; b=Dbid/lz9Iq5UjomquqwoOIfeGM80A2SZiz+CZnBytGeR3LuJndkOqOahBqBmhB+KL1 xfP5h3TW27BPVby4XLpStfb33NktzkTXKgDq4sZ7H5HShtG4pyvHW5UFfZa7kfZv8UVA St5nXg/Uf1sAX4nFj4RdpxBGC6gs4z/3tiBmyPT4vVUF4+4NU45+MLr69tqwUDOvreiH g1tPWPtF+vcrcRQj4gWJTTwn2Y7q4IlehzdAl9tUZ8pHzvVuIM3WxVBEV/37FS4TwMa9 PNnAwuDBWwHDu7oEsY+AsTmAsjfO4jN8jD/HXsFJBy+LriHDbiFNf3qLnMSDauvpKcv2 B81A== X-Forwarded-Encrypted: i=1; AHgh+RozsAb2Djv8QCsPp8Pea3/ImbLbd0QUG10/UiOS4bM5Qon+WITYtrelHFnf501Z6Z8eDDyEEvymeh+l+ro=@vger.kernel.org X-Gm-Message-State: AOJu0YxWmQhraW2muSAQKDm8bwOCmznb4bIZb+AeXNChWqgimn7+OnYF HzBlq2tlqOzqAs7C0hIW3gyWzwOl+Dg841HiOykhUZlMT/b1364N9/YjHa5qPR6Q9OJ5tqss24f iiGuhPeGTkweW1KR8I3TQ+t3qBpfLD/jG3t0/MFSfzePn6R2mS4m/MVRmG0yV21oJNs0= X-Gm-Gg: AfdE7cm4ngcT0H6o0w/JlpCdMugI2qXc53lNdKdqfPem7gDLnkRm+i9Zpd/KUeXAZsh gHdZi8OfVVW0bUB/faltp/zuwsFtwwKocEFrw+O0woDdfQY5J5APPEuPJvQg/CeUL4sLMMEzZob r6YUiE+GZBZAVBmWNzWTSdzCE6YKLK082KbV6ZwxWOcRdUjvfRWgR4EytYS1YDi6Mg9RdJbpdU2 +cUgx8LELH4de052gHrb2Vvb6AmziC8dUvBpMP1d/qrb33+nMTxtizWwy9LE0esf70393mvq/J1 dCymTlhwrQSKh+d+46JPlMjfMPKCKN7AgO4dm5gKzJCYS1XzNjBoEgmIvufuhpXmx0EsKfq+ad8 h3W6Pb7XNE5n+PhIK9SJtnMNhZA+p06LE+fVKkA== X-Received: by 2002:a17:90b:1d51:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-3835a16be4bmr383572a91.16.1783107903379; Fri, 03 Jul 2026 12:45:03 -0700 (PDT) X-Received: by 2002:a17:90b:1d51:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-3835a16be4bmr383511a91.16.1783107902725; Fri, 03 Jul 2026 12:45:02 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f290b6bc2sm10065845eec.27.2026.07.03.12.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 12:45:02 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Paul Cercueil , Anitha Chrisanthus , Paul Kocialkowski , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexey Brodkin , Laurent Pinchart , Tomi Valkeinen , Michal Simek , Daniel Scally , Jacopo Mondi , Mauro Carvalho Chehab , Eddie James , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Minghsiu Tsai , Houlong Wei , Matthias Brugger , AngeloGioacchino Del Regno , Joseph Liu , Marvin Lin , Dmitry Osipenko , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Srinivas Kandagatla , Arnd Bergmann , Greg Kroah-Hartman , Ge Gordon , Adrian Hunter , Ulf Hansson , Rob Herring , Saravana Kannan , Mathieu Poirier , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Liam Girdwood , Mark Brown , Frank Li , Sascha Hauer , Peter Ujfalusi , Bard Liao , Daniel Baluta , Orson Zhai , Baolin Wang , Peter Chen , Fugang Duan Cc: Ekansh Gupta , BST Linux Kernel Upstream Group , Fabio Estevam , Nicolin Chen , Pengutronix Kernel Team , Kai Vehmanen , Pierre-Louis Bossart , Vijendar Mukunda , Chunyan Zhang , CIX Linux Kernel Upstream Group , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, linux-tegra@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, sound-open-firmware@alsa-project.org, Mukesh Ojha Subject: [PATCH 14/42] memory: tegra210-emc: Use devm_of_reserved_mem_device_init_by_name() Date: Sat, 4 Jul 2026 01:08:27 +0530 Message-ID: <20260703193855.110619-15-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> References: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE5OSBTYWx0ZWRfX9zl4kbRNkOal 6a8Nimud+jffuKB91iP/AK9EIqT3vEkgvysuLuDNNFHqfLoDCBTAOFTyPx66YTrah1jqhuj0Gxw spqlRVWCHI8JHpw+A7cLUMeShIFy0kVP/aswKYDxhQCFV55rlSEADs2raFnJxqEP4QuhqkH2Jqk yo+WXwXcPKJZFMP6wnA67Rb9xgQzAG4U2knYlGMkRTlSOTDWpFJ6eWW2ikA47t23Z16L6PssbRg x3of6siww3Gimubz6CNiR2sQbf2wtqthuhVdTApPc1A+rjH+SIvrxsXMiqRU5MTW71eNCwTU1O0 NdE/EhxxlRJ72Cg3URBYv3UhHbtIRqwj8P4Za3Wlb7mHdbEfs9qf22bBcby+R0p1sBn3nyQGhXM p2Wf9RlGgJ5VGyDhr2Awmf0NHyC8fFAxYUXKj2gs0L5FEkONejQOxcjtjktmnJoDNGsX/tiOLv4 DbhbU0Ln29RqLK4wL1Q== X-Authority-Analysis: v=2.4 cv=LeUMLDfi c=1 sm=1 tr=0 ts=6a481140 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=0pCqoRa_c3HA8O-7yLQA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: rk9-gXGUZhtC8E2tjF0gWU_x2NXe1wYq X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE5OSBTYWx0ZWRfXyyIsCByhYzSo YPYoSMm2R7zTntCACCcmLXRzpbfmRhxyXKzDXH5Ni+ZkjkA9+RnKUpanjYDX6Nr/RBaIAF2kddD xP9PNSqX/iFnlp/+4No3x7sJYT4Hgt0= X-Proofpoint-GUID: rk9-gXGUZhtC8E2tjF0gWU_x2NXe1wYq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030199 Switch to the new devm_of_reserved_mem_device_init_by_name() for both the nominal and derated reserved memory regions so they are released automatically on probe failure or device removal. All six goto release paths in the probe function precede clock attach and debugfs initialization, so they become plain return statements. The release: label and its explicit of_reserved_mem_device_release() calls in both the probe error path and tegra210_emc_remove() are removed. Signed-off-by: Mukesh Ojha --- drivers/memory/tegra/tegra210-emc-core.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c index e8d4cd8fdec2..07c7654dac63 100644 --- a/drivers/memory/tegra/tegra210-emc-core.c +++ b/drivers/memory/tegra/tegra210-emc-core.c @@ -1847,16 +1847,16 @@ static int tegra210_emc_probe(struct platform_device *pdev) np = pdev->dev.of_node; /* attach to the nominal and (optional) derated tables */ - err = of_reserved_mem_device_init_by_name(emc->dev, np, "nominal"); + err = devm_of_reserved_mem_device_init_by_name(emc->dev, np, "nominal"); if (err < 0) { dev_err(emc->dev, "failed to get nominal EMC table: %d\n", err); return err; } - err = of_reserved_mem_device_init_by_name(emc->dev, np, "derated"); + err = devm_of_reserved_mem_device_init_by_name(emc->dev, np, "derated"); if (err < 0 && err != -ENODEV) { dev_err(emc->dev, "failed to get derated EMC table: %d\n", err); - goto release; + return err; } /* validate the tables */ @@ -1864,14 +1864,14 @@ static int tegra210_emc_probe(struct platform_device *pdev) err = tegra210_emc_validate_timings(emc, emc->nominal, emc->num_timings); if (err < 0) - goto release; + return err; } if (emc->derated) { err = tegra210_emc_validate_timings(emc, emc->derated, emc->num_timings); if (err < 0) - goto release; + return err; } /* default to the nominal table */ @@ -1891,7 +1891,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) dev_err(emc->dev, "no EMC table entry found for %lu kHz\n", current_rate); err = -ENOENT; - goto release; + return err; } /* pick a compatible clock change sequence for the EMC table */ @@ -1909,7 +1909,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) dev_err(&pdev->dev, "sequence %u not supported\n", emc->timings[0].revision); err = -ENOTSUPP; - goto release; + return err; } emc->offsets = &tegra210_emc_table_register_offsets; @@ -1924,7 +1924,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) GFP_KERNEL); if (!emc->provider.configs) { err = -ENOMEM; - goto release; + return err; } emc->provider.num_configs = emc->num_timings; @@ -1949,7 +1949,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) err = tegra210_clk_emc_attach(emc->clk, &emc->provider); if (err < 0) { dev_err(&pdev->dev, "failed to attach to EMC clock: %d\n", err); - goto release; + return err; } emc->clkchange_delay = 100; @@ -1979,8 +1979,6 @@ static int tegra210_emc_probe(struct platform_device *pdev) detach: debugfs_remove_recursive(emc->debugfs.root); tegra210_clk_emc_detach(emc->clk); -release: - of_reserved_mem_device_release(emc->dev); return err; } @@ -1991,7 +1989,6 @@ static void tegra210_emc_remove(struct platform_device *pdev) debugfs_remove_recursive(emc->debugfs.root); tegra210_clk_emc_detach(emc->clk); - of_reserved_mem_device_release(emc->dev); } static int __maybe_unused tegra210_emc_suspend(struct device *dev) -- 2.53.0