From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D32311968 for ; Sat, 4 Jul 2026 06:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783148308; cv=none; b=E/SqePL/lZmY4gdK2jUPEcd7V09ziK2Nq8FWOV68vgUNmcuF4Hr67TgCHGdzNy5QbL051kLEIZOhvcfVXeVGHI5h40zHgGpSWDo21AmZgvRIKZIAFKnbOWgtXWOV1/NzJ3oY+M1/IOajFCTrBZ8XG8dycv8Nj2Z516uGPFhi40M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783148308; c=relaxed/simple; bh=0Ql7R0chKKnSTLTalEhgSVivzAge5FzmNSZ6cbj00i8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QSMcLtXygmuysG4c6LF5Tcjc0vOGCzvxh0x69l+5YAKffjR8hNChikmbguI6k22OKLlCiDspAMomkpXou7T4Vgdr8ab7mQyq7LFUGNVz92J13JPrrWMFwhhfoIS4uvXpSalPo0hn/DVaLCoV1zX1chUxYp39lfcTT2Q1DjdVMHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bToDJkzm; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bToDJkzm" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2c6b67d5fa1so12194375ad.2 for ; Fri, 03 Jul 2026 23:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783148306; x=1783753106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pk1gsSzNyvLyGL3wQhMLxqEWyeTVD6LK9bSQUeXZaTk=; b=bToDJkzm1rkmGGIrN413snhCtC09ATYl8Dwq1GD1sCQDeKU19xvRdQnCPIkGCwPLhA c5oW7NfKk7cx7IGMKP0yZDRWR4UC/CYVwld4hIM23PnmPI74oFMW3snXNQyV/URBPIxF h6sTR2yhNnzRE4VHogHBpeHZ/Wodggat5OKGqxdwqDLvG3prmaCMHCzkM0U7jvoOL5IK p6PD3occxP8Nc6eS8pk/mQGB4qrs9xmyPgsKa8LUq6oBK0q9EAmwyacl6JbURSSSH0ib FjQvPfAUx/lkqYpyQPHLcaWytIUSSIMf6XWTf1WchCtWR+aD5Gao1qSpGVQr3RtZcdnq O43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783148306; x=1783753106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pk1gsSzNyvLyGL3wQhMLxqEWyeTVD6LK9bSQUeXZaTk=; b=mMCkp+HhdREtrzTrvzvebPnRIWgxQldt318dJsyzDvHRX9iC4qZdJz/mMEqc2sENRq S4bgZrugOuVrQYRIMC4tnMWWHwP2c9cTRbjg/U7r3jF33OZ6kDrqptt70N/VEqXcASbV Ev3b5J5+cMEdL2Pifj7gg6Onkzu9SzjL7u/o/pVabAMdku9yFvbUQuwOPGhlllcGEqDs IkiKPhE9iPj8K4VYnYVUbgnx4vtXKJ+h2zLoY7uJzxyBaGiOi9vCqUvh+0EpBDkKByqv HkfkC4P7uCAxVmzm9s/U5x4inPo2NpK9O+Yi5uylUIzkPX1r6YCqDP4YNOGFquhyJkoC uAWg== X-Forwarded-Encrypted: i=1; AHgh+RqGlR23H9SR/nxRXLgDuJoYRqRS1/c95jk51XInFQNj8pgykJYChbajKOrC6AJoJb+I+HOgp7+FcOClXTQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzsy0YAlNtunVamOSvQ+aM7KM+8w4WZgcJ5iJ79Auqs74BxL0cR /v5PuIGUDspW8NiuhByuHZG4uxaYh3akc8xLxrg85weq+N5uG3Gd9FQh X-Gm-Gg: AfdE7clmXWpHSmGpeRC+E9f7KRAAl1hPT0h+qQOJWvJJDyPZ4/DzWbUzYyHBa/JGEuf 44lLz/Bbp1EG1soZ2DN3X323xoZxWfvzXvbwUVClTXK5wsxHX1gxvt3K8h9zVlPqCzfV/3Uuiqx caBjJ32cO9KmdHGG4foscaXHf+fWlzL18TvWEZjB9O4+SuV6nmHSHJ0EPu4zi1D0QuYp5d+H4vd jL6lSfocppI1ajpHJavKCuZpi4rbiQp4vVApBDD5qyTfs7Mft81/Ck7bK1/KQ0vr16pXl/xJOvs +V+HhhRG9373kK32wKj2C8FCdD7XwfQxPYov8XkynDZQ+UIY5qwFXlUYWZ/BoHxnx4HdRZSdb05 v1IE0LALs9f7uB8OVei7o/W+P7Uh3jIMeKXVZA6/1ywewxaSs0U79w8ftJjufgjLSA8G1OxlkDT 2jBfItHispZzdVuBZULPU3h/TenE5ks8KIGQ== X-Received: by 2002:a17:902:ffd0:b0:2ca:feb:303b with SMTP id d9443c01a7336-2cbb9ee4ecdmr21754205ad.25.1783148305926; Fri, 03 Jul 2026 23:58:25 -0700 (PDT) Received: from Alvin.tail8ccd9a.ts.net ([101.12.233.227]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad712ca17sm19526275ad.28.2026.07.03.23.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 23:58:25 -0700 (PDT) From: Hao-Qun Huang To: Greg Kroah-Hartman Cc: Johan Hovold , Kees Cook , Nadzeya Hutsko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hao-Qun Huang , stable@vger.kernel.org, Martyn Welch Subject: [PATCH 2/2] staging: vme_user: fix location monitor leak in tsi148 bridge Date: Sat, 4 Jul 2026 14:58:16 +0800 Message-ID: <20260704065817.403111-2-alvinhuang0603@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260704065817.403111-1-alvinhuang0603@gmail.com> References: <20260704065817.403111-1-alvinhuang0603@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tsi148_probe() allocates a location monitor resource and links it into tsi148_bridge->lm_resources. The probe error path frees this list, but tsi148_remove() only frees the dma, slave and master resource lists, so the location monitor resource is leaked on device unbind or module unload. Free the lm_resources list in tsi148_remove() as well, before tsi148_bridge is freed. Fixes: d22b8ed9a3b0 ("Staging: vme: add Tundra TSI148 VME-PCI Bridge driver") Cc: stable@vger.kernel.org Cc: Martyn Welch Assisted-by: Claude:claude-fable-5 Signed-off-by: Hao-Qun Huang --- diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c index 4cf3486646ce..c695ad9b4ca2 100644 --- a/drivers/staging/vme_user/vme_tsi148.c +++ b/drivers/staging/vme_user/vme_tsi148.c @@ -2534,6 +2534,7 @@ static void tsi148_remove(struct pci_dev *pdev) { struct list_head *pos = NULL; struct list_head *tmplist; + struct vme_lm_resource *lm; struct vme_master_resource *master_image; struct vme_slave_resource *slave_image; struct vme_dma_resource *dma_ctrlr; @@ -2590,6 +2591,13 @@ static void tsi148_remove(struct pci_dev *pdev) tsi148_crcsr_exit(tsi148_bridge, pdev); + /* resources are stored in link list */ + list_for_each_safe(pos, tmplist, &tsi148_bridge->lm_resources) { + lm = list_entry(pos, struct vme_lm_resource, list); + list_del(pos); + kfree(lm); + } + /* resources are stored in link list */ list_for_each_safe(pos, tmplist, &tsi148_bridge->dma_resources) { dma_ctrlr = list_entry(pos, struct vme_dma_resource, list);