From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB31390204 for ; Sat, 4 Jul 2026 08:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783152990; cv=none; b=Cc0No0sJj8fr2Az/zgBYKHX+S73j08Y0Pg02bw6bTpNh6lSL6mtPU0odd+jt9HDVpE/D7MYyuL/61Ur5HOyS/WjegKYhMwO6xkTVjE036vghUBQSmsNgdUYaomV4SqLtbYNi+bAgDT1CVwGmyJWEcsmZgXAB12jqaU1fp+juNbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783152990; c=relaxed/simple; bh=ICYE2DkCV1p/9tLiNI3rxxRdRQI4UCN+8Zh+UvVQYCs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G5QDU8fzVaRadESGH0ej4b/EnbdpLvzFRdFm/xUD0Z37dnrEAf0LjfK2tqCryl2QhE/qlC1Lmun8GdereX3gxJDNUpQfnNxrneb8rqCegI7qMZtCQxDQKy9m95jJQmLHYJJksQWLXQBmPlyUCiStW+JEfb7pjkVud2sHBehiKCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PUkT61TC; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PUkT61TC" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-381891a9525so1053152a91.3 for ; Sat, 04 Jul 2026 01:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783152979; x=1783757779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TH3+2uge2X7v89K7Klwz73DAfKLAbdik2q1vKZDeHZI=; b=PUkT61TCOQ5SSgJOz8pkgCYMaNaQyDptKuIgNo3P5feZ0QGSc6fZg9EyusE5kQvj1f 4SQFm7h+DiPwsDVG2Y4jj2ZUKBbK2vw9mwj9KuTb4jQjahlJ3SxZuIJMEwlV+aWFZkN7 ltmK1KlPVxeouze3AiV9vJTZWut6pefkABQU11ENoxUh0wm3jApn3Kt9a3MQNnB6uAqc u8SVuE/avhs1SZFMQhDlVJlu1i/o5dWAw1d3uKNs3Hy6t8Ln0BNLvS4WsjSl4TkToewt A4I7f+5H02t9apI9fMretCCnVaY6YEEyS+HHrJkSddc/0F9/e8xSUaNOhsbqYDp6cj/n GoiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783152979; x=1783757779; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TH3+2uge2X7v89K7Klwz73DAfKLAbdik2q1vKZDeHZI=; b=ANs1xZWfk2ZVbAyd0lVjtwFYoVvVndAUg3KrMpQlbLIlM9uh55A+XWF6z7wPNcwdI5 Aqf0CrCamcScCZpC077GPtm/yV8VB/fDHevXAvJ1OQr7j9hde1FBOPQ9MMdoONsBfLqv MKIUfhZbDnq564Hc74F59P+mEbnyCPt06oTQwxjWvhLZKoJoHeVtfgb+o0MuznnJCa62 ZlERwq/lnlgC1tXLkTwfRiHpuERzX9ri+XuSgcsyD0i9hUB73UYN2kf9RuTplx5UoPXo GYdyu09myL/pforCfUyLAKa4KpY/0+j506VRgb3pr2kuh7yhNaKRtb946ExRdF5O0mip lzYg== X-Forwarded-Encrypted: i=1; AHgh+RrG51LDOjPlXRPQ3LWlDewCI4epASDHESkRxMmzlZ2CxoxQjQMPrtvOnfctDkPKvAr9nbtTD2axBa5cXfc=@vger.kernel.org X-Gm-Message-State: AOJu0YyCCadrMoO9vo0MLmrt4j/tFPsENW2cxi7/KX1Cir5a34fgEEtD V4Kgi8v8+f2kS/ka47Otcj4dfp2raRavW4GR1hOrNpXfINeiDY0Qi+JzU4JD6zlmuNU= X-Gm-Gg: AfdE7cnCSssDR1x64cnzuOiCALULDX4rn6YSAZCabNelx916jQTIde/UnK87ot21oG9 x88omnhb9hrbKDbTp6iPyTuJqeH8HoQeZljop8e0NCSu8OXNeL4tNUH45J2Rsg7VR4+Yy8oMzN3 hRWg6KRbaj5Q98Du2ZvjqJ65CvEaWWew3AWwEXLbf27XhWWX4/MKKUh7QBVNpKIKUfaYvJBPnpq n/59Zd12K3NRi1RNFpY2l96s+zzj069oXRvIBvENcAORA7Z2NdC4m0asW1rV5XalQ2N5Pr8N4jp jLfRh8CAXKR78YvUVxf4LCF/LRB5Zw8Hx9omvQAzd2iCuAAw8InUJj5hJQYzCmY/UjcTy/nQhU0 2+r2PmZkMR+4FV1P3zKAwU98WQUyv1m/eppyymAz8f72BMLxQfG5JylxDnLIWRR5jQD0/IKJqvl AmqUTaw7nhgAK51DXbRPOmUEr1YeqsKwpEag== X-Received: by 2002:a17:90b:5890:b0:37f:9ce1:7364 with SMTP id 98e67ed59e1d1-3829f4f0600mr2732468a91.26.1783152978511; Sat, 04 Jul 2026 01:16:18 -0700 (PDT) Received: from Alvin.tail8ccd9a.ts.net ([101.12.233.227]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38127ca8046sm2112322a91.13.2026.07.04.01.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 01:16:18 -0700 (PDT) From: Hao-Qun Huang To: Greg Kroah-Hartman Cc: Viresh Kumar , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hao-Qun Huang , stable@vger.kernel.org Subject: [PATCH] staging: greybus: hid: fix SET_REPORT return value Date: Sat, 4 Jul 2026 16:16:13 +0800 Message-ID: <20260704081613.434445-1-alvinhuang0603@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __gb_hid_output_raw_report() stores the result of gb_hid_set_report() in ret and even adjusts it to account for the report ID byte, but then always returns 0. This hides Greybus transport errors from HID_REQ_SET_REPORT callers, and makes hidraw report zero bytes written to user space on success, although hid_hw_raw_request() is expected to return the number of bytes transferred or a negative errno. The sibling GET_REPORT path, __gb_hid_get_raw_report(), already follows this convention. Return ret like the other HID transport drivers do. Fixes: 96eab779e198 ("greybus: hid: add HID class driver") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-fable-5 Signed-off-by: Hao-Qun Huang --- diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c index f1f9f6fbc00e..1d7186eecd23 100644 --- a/drivers/staging/greybus/hid.c +++ b/drivers/staging/greybus/hid.c @@ -256,7 +256,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf, if (report_id && ret >= 0) ret++; /* add report_id to the number of transferred bytes */ - return 0; + return ret; } static int gb_hid_raw_request(struct hid_device *hid, unsigned char reportnum,