From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D871239B4A5 for ; Sat, 4 Jul 2026 08:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783154609; cv=none; b=Fb8/8tYTv5fG+/8bOqXx+Mqm4q/ggl/UOFua4eieJXyhUFnd4lPkyP8Yn1USWQHMZup8xRP8jq1X/3IJdz3Mv9BUXjDKqwerV2M4V5vyquPvJnv6YDpVHzO1iy5CKabe0ksF4/hyqgtVLvODdD2bmKSlaEdb6GeGWCaQOol/6ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783154609; c=relaxed/simple; bh=W6XndoPJxMmfvcF5J/6RwgK7hpJy2bK1C4lOGRI1vlM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kj/VwIZ7wQM3VxOdCjcKPGljK0r6gpsL5LnTzv2KgHqc1hfazWd2w4wSIB2yasGQ9ZJn9/qSnlNsFAyey9ff3iwA8E974iTIl8TPnmJFK8wTwXy3OuNYFYVlJd6oi91zFBmWQ4ggK/Kb/S5lcA3VrchzfizH7JOFhhHDHk0mk70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AxdlIH/c; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AxdlIH/c" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-381507c9380so649868a91.0 for ; Sat, 04 Jul 2026 01:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783154607; x=1783759407; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RpGZ+bQBBUTVKiZDfz7x7KckanibPTCiPxjo/4OYUFw=; b=AxdlIH/c7Mt/HcTIlgIKrCjLW+bgnaAdZ+EdbDwjxkT/V+1pk9M4LwEo/8zZPZYdf5 LH2EnavLEyzwEwlIFl/gyzDigGabtGNzNFkCBzfbfkmQA2aoY16lwqLZZ3neM632l0KR SxdUP+7DeQA8nibO0ZU9e74MIZ7j3mVYlKk24lbJysK0WH28fX9DjaGloTpyn2Xxqelh 39G5OQWRwLamIDoZO7ONLebF9cmHQnkUPbFkS2YhNcVkHEAl6d7/BWkfC5dCCs10w+d6 TjGnrSDMuB34/YkhD/6/HiP5Kdq1y+qVrrTYBfnJm/yGPxKdO2Nc01ADPGOQABMUMJ4p k8Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783154607; x=1783759407; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RpGZ+bQBBUTVKiZDfz7x7KckanibPTCiPxjo/4OYUFw=; b=FA+Sy1blOaIZKSr7PuYnlK2Tbj3Cj4vSc1m3K+V50OmGDkmSuPlojBVwFCkKDT/ER3 54yTpOaRK3Nh0RybUZ7NOk2bM7JK2MWtEeWcaj4XUIkxrRy8z8JDDqUAPuJHjoa1OIoj mkKFNL5/rdsBe+7W1ifElwWtGVYBzfrKljsjxlgBp0gJ0Ist8nOj7ewp6ssnLmVsb7sG d3ULOOyt2kY/pPpJECJxFBrHLxGJGb0FjRCSvMyeTK/ylAHrfWJ2cE5xs1xA5UcyWnAr gJTYaF7yGbCxh5+Wy/lzf+o8m70pPmN4uqKMpSDKylb+arsYjDC3hHAiailIfOWI8/fD yIjg== X-Gm-Message-State: AOJu0YwycUYMW6p2JONaC6DqGTUSaQcXiQeBFcwxAFbrYBHoV8rW3Zkr pZwfW2iCseTBvinoYbCsUY6lyj663gpBO4Bxl0kn28aFpV/zgsuQXzP5ruEyLnisq0A= X-Gm-Gg: AfdE7cnXTxBQU6VLWANPxEvqOIaZV2N6BEYgwAFBJfZUP6rjmH7oyXviMTstYtshKwI ja9mczMgGJlSdraQ/6Xk31b+I+YCQ6PAiIu5YPxhAyGtwQY2F4lPzY4n8KVWE4CibzUSDS6lz97 04l3Ic92dqdRYPHjs2fnlSpgOBBPa2iFRffRpnahD0PhPp5NJdJYhEahQRcH3HTyyu4DYC8hz6n 5zz2/QRd0Sr62VzBAmm+oynGwdeRKPLHIn6G/eW78Gxqo6NS6vqN2jPzsl173lOgUollmvknA5x lgJDXlUpMRHcs4m/upcvSCYtY4kqdKnSMs5gfmAh/mVjePooy3KU/0rbOwN+NwNjmxyUCumCyEV eYclMyYerT9lrr+sgFy29Np0n1uGVH7rNqndEu3Jdao3ktYjorjwiHBOlg2k/rrn9ZPotwoXfpX p/X2hSpslYxet2HxjRfD24VS0iZ7zruWIuyUpetwy2YspTBP4Vu3C3s0enqQ== X-Received: by 2002:a17:90a:d44f:b0:37d:f7fe:4bbc with SMTP id 98e67ed59e1d1-3829eb1e30cmr2577670a91.21.1783154606804; Sat, 04 Jul 2026 01:43:26 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bb7fe46sm34137884eec.14.2026.07.04.01.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 01:43:26 -0700 (PDT) From: Malaya Kumar Rout To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: mrout@redhat.com, skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur , Brahadambal Srinivasan Subject: [PATCH] cpupower: Fix NULL pointer dereference on allocation failure Date: Sat, 4 Jul 2026 14:13:02 +0530 Message-ID: <20260704084303.86113-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The bitmask_alloc() function can return NULL if memory allocation fails, but the code in main() does not check the return values before using the allocated bitmasks. This can lead to a NULL pointer dereference when bitmask_setall() or bitmask_parselist() is called with NULL pointers. Add proper NULL checks after bitmask allocations and exit gracefully with an error message if allocation fails. Fixes: 748f0d70087c ("cpupower: Provide online and offline CPU information") Signed-off-by: Malaya Kumar Rout --- tools/power/cpupower/utils/cpupower.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tools/power/cpupower/utils/cpupower.c b/tools/power/cpupower/utils/cpupower.c index 9ec973165af1..8f7b18b8bb43 100644 --- a/tools/power/cpupower/utils/cpupower.c +++ b/tools/power/cpupower/utils/cpupower.c @@ -184,6 +184,17 @@ int main(int argc, const char *argv[]) online_cpus = bitmask_alloc(sysconf(_SC_NPROCESSORS_CONF)); offline_cpus = bitmask_alloc(sysconf(_SC_NPROCESSORS_CONF)); + if (!cpus_chosen || !online_cpus || !offline_cpus) { + fprintf(stderr, _("Failed to allocate bitmasks\n")); + if (cpus_chosen) + bitmask_free(cpus_chosen); + if (online_cpus) + bitmask_free(online_cpus); + if (offline_cpus) + bitmask_free(offline_cpus); + return EXIT_FAILURE; + } + argc--; argv += 1; -- 2.54.0