From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D8612F39AB for ; Sat, 4 Jul 2026 08:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783155351; cv=none; b=EM2J04dO5OVVJxhcuq+q8JULp2+FbsFY96u0zC4TCvfUhex9PVxfz37Q7MIxNiWrBRsbjh5QKpP3zEr6Poc5KaYqs4SRfrKmqcw5FnjXQTIPqNOA48tmDeIUhn7w5vROA00tNMzMfgaaeaotPH3O4SedS/yBadG69+ldwEslUt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783155351; c=relaxed/simple; bh=J0VFE9zJZmoVuFdDE3VhtJXDOIDbDkFep0lyGliTIV8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=M6oWnU9XighBK71PMXRl2AdmKTpl9z+C+8tWdK27oiTw1w2lNlE2Oja2S1BfvkbTUsl+XR3d1coIDtuafx3sp6t1+SYfsu/BX0kKG95s08At8O/NTDmHVnWMTjd7UJi1NDgz4vYAryMgBnbe2E+XNTBjPckV8WaxX2bV+Kii2i8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dzILBxfb; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dzILBxfb" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-37df72c9984so1224610a91.3 for ; Sat, 04 Jul 2026 01:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783155350; x=1783760150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PwxK482pBlwvG1SMowfv4tI9fOrGlFvYa9EfI1sy2Ok=; b=dzILBxfb7rBBAuMYEd3uak1/t8kgk2f1Cxo6l2cNaJeIfljHkT8vnWLCFPyCtZd/fz PEhunLLa3ONOTnh/EpSxtkC6B3bdt9MOZN+we3BaPjvctHbbCYR2dj+2FMFoDt3lrMAL 4eNRcF8cgUqDHIWrdehxt/vtouLxhCP3yK1Xwl5XOWDWMn+ir/FUwTmvM2TA3FgF+jSk KU8o6Fo3iV6uwFHIH/h3y80hRP3PVsjlehZIBsqkPHHyT9g60+Zz32Lc5Nw4k/Jx0/zK 58KwGeA2w9k/GGWQo0lANdQkedBy48R2PPza33K1vBoq878GfZgM733GPGgsMXn8NZD3 0iDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783155350; x=1783760150; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PwxK482pBlwvG1SMowfv4tI9fOrGlFvYa9EfI1sy2Ok=; b=DNqg7NXr3a64EK+PWfqqMETqrkw0QQeA6RYZKRiGbyYjUkmWg2ldDuPvFXZ5fupxcw AwDVFnexkiQrS799W8wwo5gn8KtR/rlWnFVfSZk7QQ4uuL5DxH+rO7fvwIa5NBVBKHhB cA2jRm7V8oeZ9BHN1pyB5v6ivrAsBJuF+A+3C2HvcTZ4AfkQhdVasMWl1uveXtBzsXJx YG5rbAVp9YGXOcFaor9apo9/fKuK4ea3SV4kzfHeuuWw4ixdKhbXHjsyF6dsTxM1BZy1 fjsyu+UCgn4kmtCJQM1tLeQVQpgC+Ff4lETsMHv2pd+q74SQtdgzUgK2XetjkZ952Eev ha6w== X-Gm-Message-State: AOJu0YzxnqLlbHg3ZZrC2itaWfW1/VI1EXR8ZJ4SZlEIMYEKcWgKBlyJ 5cXzqLdCkEOtEGdlc6mLr4tfwhMKsFwCjoK0M1fkVoZNSKXxr7bTeS4GymCpEbQVnsc= X-Gm-Gg: AfdE7ckbAxyy81YQny8ywCzMdDr6RHJZX90AN5HoixN7+LW0IOi6RZgkPRfRYgmQNGq QwDUV6eB4yGyF9CbLxCAFewZ2DwfpVLDDMsAj6pAygMcqKjdrdgL0rO5a+GRmOBImgMgQDfK9g+ kuxhXtRLBnREUdjU/A+G7Dpxuvy9H2EXqUTbGPF0jOLHUHFowYvcbxKtsqKUop1bZExrdccRqt1 2LTn7hnXArszEyVQH9p0BjXh7+UBlDpU5cmlQUEXjyfynoUUlvEFqp9cQtSGKmWY358dFan9Yd6 tgNnnVbzSu7Zq44ESTm9hPZMWW7htqKfhfM7Ui4Hqczpp+UnEQvCEh9OPxtw9w6rO6CZtVbhthE v+5OgN8530DRNIupgxTta29t9JAXQ6qEsOdKqS2MUXxGzGnn/2fyMZD8r+Wzcn34+OjtFE7c1S+ b9W86eZ7HVfvFEVSIKZRQZPZtwJatEhakjemIwMygtZThQ4TEZPuYf8SmP3A== X-Received: by 2002:a05:6a21:a94:b0:3bf:9e25:1a17 with SMTP id adf61e73a8af0-3c03e1fa52fmr2868358637.12.1783155349803; Sat, 04 Jul 2026 01:55:49 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c7fa566sm26167666c88.4.2026.07.04.01.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 01:55:49 -0700 (PDT) From: Malaya Kumar Rout To: linux-kernel@vger.kernel.org, tglx@kernel.org Cc: mrout@redhat.com, skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , Anna-Maria Behnsen , Frederic Weisbecker Subject: [PATCH] timers/migration: Fix memory leak in tmigr_setup_groups() error path Date: Sat, 4 Jul 2026 14:25:33 +0530 Message-ID: <20260704085533.87098-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the WARN_ON_ONCE(i >= tmigr_hierarchy_levels) assertion triggers, the function returns -EINVAL without freeing the 'stack' memory allocated via kzalloc_objs() at the beginning of the function. Add kfree(stack) before returning to prevent the memory leak. Fixes: 6c181b5667ee ("timers/migration: Convert "while" loops to use "for"") Signed-off-by: Malaya Kumar Rout --- kernel/time/timer_migration.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c index 806c23cf71fc..d2654abfdef7 100644 --- a/kernel/time/timer_migration.c +++ b/kernel/time/timer_migration.c @@ -1847,9 +1847,10 @@ static int tmigr_setup_groups(struct tmigr_hierarchy *hier, unsigned int cpu, } /* Assert single root without parent */ - if (WARN_ON_ONCE(i >= tmigr_hierarchy_levels)) + if (WARN_ON_ONCE(i >= tmigr_hierarchy_levels)) { + kfree(stack); return -EINVAL; - + } for (; i >= start_lvl; i--) { group = stack[i]; -- 2.54.0