From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD10331E856 for ; Sat, 4 Jul 2026 11:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783163438; cv=none; b=t1SIpug5RCu4y0YMjrPGcXMBmSHLDfnc1YiPoeuD5gN7xJbK0HWp2qeQsNVxPWK+a/eipJg7HxotWIQRG8Jzc0G6EPzrwcIfQZ2RanN08nGP6hH68sFziJCA2OupiXUvZ5Hf+AYqDlTC3dC92OlFB3Q88v/5+Mn6ySE79Ljt/t8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783163438; c=relaxed/simple; bh=VC0lbd93weWWPw0ARHHgPYB9edEsOZyLDpgojPf7rOA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bZLwoY6MC7qEncwJGZoylRKZk/mAKP71MYd/aPQ9Wa06bBTG+pXMYrTbvigYYOP/jVmOlmhb8JMbsuiaSFwfLF/htNYMZ0S6h4tl4tffleaSTkNCBgO28GMuvZykEIPK5TlMjNQsqnfv9+h+a2Iuqrqo/4otYRCjVo8LLE4OOPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bi8xKEOj; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bi8xKEOj" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-847917c3678so1425889b3a.1 for ; Sat, 04 Jul 2026 04:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783163436; x=1783768236; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ARFUOtndToaxiivfKYhDrkkb5hSNxGExw8ndgTKm3ko=; b=bi8xKEOj/y3xvuKg0UCthjb6j6HmmglrsNWVyZRM0RyAyW5tqiKSI3Q9cxKLCCm9nh mUbGVI+W6w2Yrg6zrjqkkRpF7JGCMRM87pJJwjJf34XFjQ37F3vuWIlOm7BxWpe4CPRt 1CGgi1yBgMoLBHGL5XJZ8gb7igdFkOlc8gJoIgu8dgVRmdBnNyQa6Kxp7eQgTFqTguJv 7zD1w3+GwP9KB21I/5T1E9qW+8vZkirNi0ti7us8O530HlmZndFYQNX2u47l/AaBkwnY XC23zPJkbZkGGKpU5IlITa8DUOERVekmKAExEA4XAMv7Edm/97Xul0B228m4Q9vZpa/A bbBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783163436; x=1783768236; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ARFUOtndToaxiivfKYhDrkkb5hSNxGExw8ndgTKm3ko=; b=OSE8R96VNMIOa0shU2YGoFnsyVBlnoHPhkUjE8kFUh/j5mFn44WbvzcZ5tGv+isgjp KFby0X2TN4p45/DBe+G6XjtcdzCdp4tD9EkNFijf9RL2FIw2phQMMDUD7Lat0hRYPZD4 b3gDz81Q9EvfNh02L3Lxtl2RnauJ++5gbLzpUQqqWeYiX4T87C0/6d6vPGOBa5qYRHa0 hZ5IfHNL3C6gxlFp+9vwbQyVuBchK9jY7xs+WNCMLSx5EWw0B9xMrLTx+85uGhqvKm7e QZH7fjma1jHJey02s+p5AHJmsDrWR0aPI4kioYYFd9HfmMaKhuJU1Hse9WcFUWr2i3M3 Xslw== X-Gm-Message-State: AOJu0YxNxHllf/UBjUzb7UkIYXCWy8tfzEV7/vCQdmVuKQ4I+UI0Gx2d 1FR6MN+kPYHGrmBCq2DjBeBSDOpZ2OQX8aw2TnbfxegUc0XxaC5tgDl124HssX2lm6Y= X-Gm-Gg: AfdE7cnBCGP2nhkCnypptJXEnvUEnd4HDX1rDNeekMPMKGFeDeH2qciLzGAdYzHnr3Z My29UQZEkznE5TqMcp0JifHj5xg2MgIxjzlynPfNlIJR8qJXoxnaKjkwqcr6gkXPPMc6r/C2WvB pUxcPdddtCzwMz8Tf3eJNN6GTfcB6kiLc97cMosTdF4PZLAV8EmPT0MLWfvUcNWC+Mh5ud/CJ+i ELQhchc4vpDR02zvJ1k5foBeNH/Vjd4y8FS12d4W/9cEGYWU1VvJGoJOq9706zqHyvBFXJA/92t Eneq16saD5rIO/3xl+fCKIf/COG0ignKrOVxWZ/vifDNz7GAYC+zKg56rqfDYWL0+tbPz0Hg/Qj oD0sRYaLWnlYsn5aPF1jIjwJqC5r386jzCqG1iDeRHvxHl03XlVHhaprnMo7t7/MCJJfj11dId9 KCfifEFS51BYlfvm7nHX9lvwG4NVgerg8Ad+EJCXtRHMFO5XJgy7WACg7vvQ== X-Received: by 2002:a05:6a20:a120:b0:3bf:ecf8:abe with SMTP id adf61e73a8af0-3c01c225648mr8224385637.0.1783163436124; Sat, 04 Jul 2026 04:10:36 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ffdd292b0sm1695968eec.2.2026.07.04.04.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 04:10:35 -0700 (PDT) From: Malaya Kumar Rout To: linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: mrout@redhat.com, skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , Andrii Nakryiko , Eduard Zingerman , Alexei Starovoitov , Daniel Borkmann , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Shuah Khan , John Fastabend , linux-kselftest@vger.kernel.org Subject: [PATCH] selftests/bpf: Fix memory leak in msg_alloc_iov error path Date: Sat, 4 Jul 2026 16:40:16 +0530 Message-ID: <20260704111016.95816-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In msg_alloc_iov(), when calloc() fails for an individual iov_base allocation, the error path frees all previously allocated iov_base entries but fails to free the iov array itself that was allocated with calloc() at the beginning of the function. This results in a memory leak of the iov array. Add free(iov) in the unwind_iov error path to ensure proper cleanup of all allocated memory. Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/bpf/test_sockmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index ac814eb63edb..3e6be455d158 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -436,6 +436,7 @@ static int msg_alloc_iov(struct msghdr *msg, unwind_iov: for (i--; i >= 0 ; i--) free(msg->msg_iov[i].iov_base); + free(iov); return -ENOMEM; } -- 2.54.0