From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CAE916F27F for ; Sat, 4 Jul 2026 12:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783166701; cv=none; b=bBVpX/QcD+6v/ttTKvZ2Hk0mssbbrHC+nQY9JnCy61QpPhfUy+fCguGrhrn/+ZA9u3RFsTQFgOUpiSJWFGGbafhfaNNtUtxJVnOhXiHRd7/PUBPe27hi7ME+wxgFXTPk7UNI9ZdNy/ppSb/Egv8u2mdZHRSeShZ0K9kd97dTvws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783166701; c=relaxed/simple; bh=f4GTZyb84/4u70c8CMGYPFKG+uXGChxqsJo++uOjrJE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Tq+NCVb7kxCgQkkJtoIaC08e7pmYpP9rhOuHKoqipydlx1rmHeCPYbUVCqU3AEtzTRfH1M9BaoamAzfXqIRnhguTqn9auseunyP0XaK25Z8oyVH34Nz0wX48KI0d8j85HiWaME4yrXBzvZsWWQVTNwblw/rx+O4duWUtvp2skYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FwpixNBo; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FwpixNBo" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38426d04bb4so170908a91.1 for ; Sat, 04 Jul 2026 05:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783166699; x=1783771499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kDApiyhfQ7zB6Z95TfhqpMpei8zMQ8r0EAsOqioA/uY=; b=FwpixNBoj1VbGUd3ZF4wqB/zikGscFZzmbXDdkV7nMgmNGM57ZKVxd8ginsf+/7CLJ 1uUnSNNTq1DO5/gYUW0IT7HRvPpz0hAvDQO9V5A52iOymGxGUpunz1rCZDN3Lkb5EZ17 1M+j9sDy7s6MYdvc/ARJ34GQZaNoHH29v/BZVM60V28kUBlKGAqoLeY5PeJF4HcerV7S 9XZc8AN58MkoGSG/RonEvnjknh97pOxCmempPf7xlZojkASw2kUl06RKmlx8aYGXVVvD Ra3ofw4D84abWqRPMNy7ajrq1fQUiTYOCdNU8Epk+w8Q2fGmWTy7f23t76sQsRwfLv9z wqKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783166699; x=1783771499; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kDApiyhfQ7zB6Z95TfhqpMpei8zMQ8r0EAsOqioA/uY=; b=QwaxVzPVLOvhtWNYWMf4coqKpXvOgS3YfunrxbfQpRXjo4eIiYXogXlUA1gMx8ez/J TmG74VMKX6+rKTaEPwdP2tVDf1Yti5S9l2wpYVdB/E1gpGobYSX+GUOmKNlwOm/i5g/z SvXpnoXlr//uQn6Ap5Q6AzQkykfgNmi8RC2Gzx2ksdalXevRsGAw41hquVQnhiNdB8PW Vmnd5r5WJvrpHRbYKNOa2XztrfUzk+MFvMiPAE8oE3JBOqjDTgm+sRfITMhWOlql1Z84 0r3CRxhsVnecLv56wcF0whJC5L9689wi+2l59VxXjCws3PNAmp/icdDvYAw26a3G99wx UYqg== X-Forwarded-Encrypted: i=1; AHgh+RoZjbjjMVT+MW1SjortoJDfMetEJoL+VBz4X2PFLKi48iBBp/lzY238YmlvRE6x8QcO+5sCLZmiqfRO3rE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+uUHz4xIwJsS92C0W57KwYZ7Z0qFNmnv3YRM5hyhQMY3FtsA9 Kq+0XfVDMI/seRQGdquCdX2nuyT51mzb6jexwNTwbEQ0TWTO8kSgOCSz X-Gm-Gg: AfdE7cksbeYFX7rMn1s0JN8HCVbxcxN9xCqP3jKLiOUqY/tmYnyLV6dJ2Q2mkTPVu9K +Tf467KgmtmLZOJgvhL7MsLl16ZrDDWM7Pss6sMl+PZeCAlA+bCLZ/bJr4gonCqu7SoVnmHCaeL 7+kekZjCOm0jSBc0nwfqPWwVLSnLu+K7NqScd/odouVUOI84fjvVRLX/dpWJQWwCHuAFWaULCXn 1su210OGh9d4O4SEfhZFoH7ARQZhGSYinf8tq5jYBTzRSfdIw0MAStrZhB2VdgVxuMfu6rOpm3k 9U1kmRs1kfi3FTbx96mAleYikLjDMuReN4duKyOU4eoyn7NsUAipvKOGHlcQCKZQUSauB7dFgBy o5kcpn8JKNSHLQ8DOXkvVee/fIu3LNkzqWOLL9DJVtmLuJagvO4+6HXd9tm1RAhw22AuTJo7c6C oZnO+NkCBq+bVnz+XYIR6c6N639Q5piz7Fg6BKcrO0skX1jHqOsIX1hBYmrg== X-Received: by 2002:a17:90b:1e49:b0:369:7491:7b24 with SMTP id 98e67ed59e1d1-381120b2f0fmr9267108a91.6.1783166698601; Sat, 04 Jul 2026 05:04:58 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bbd2362sm34504916eec.20.2026.07.04.05.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 05:04:58 -0700 (PDT) From: Malaya Kumar Rout To: linux-kselftest@vger.kernel.org Cc: mrout@redhat.com, skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , Shuah Khan , Christian Brauner , Andrei Vagin , Andrew Morton , Bala-Vignesh-Reddy , Bhavik Sachdev , linux-kernel@vger.kernel.org Subject: [PATCH] selftests/statmount: Fix file descriptor leak in setup_namespace Date: Sat, 4 Jul 2026 17:34:36 +0530 Message-ID: <20260704120437.99851-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In setup_namespace(), f_mountinfo is opened with fopen() at line 115 but is never closed. Multiple ksft_exit_fail_msg() calls exit the program without closing this file descriptor, and the cleanup_namespace() function registered with atexit() also doesn't close it. Add fclose(f_mountinfo) in cleanup_namespace() to ensure the file descriptor is properly closed on both normal and error exit paths, since cleanup_namespace() is already registered as an atexit handler. Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/filesystems/statmount/statmount_test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/filesystems/statmount/statmount_test.c b/tools/testing/selftests/filesystems/statmount/statmount_test.c index 8dc018d47a93..7d9035c1815f 100644 --- a/tools/testing/selftests/filesystems/statmount/statmount_test.c +++ b/tools/testing/selftests/filesystems/statmount/statmount_test.c @@ -82,6 +82,9 @@ static void cleanup_namespace(void) { int ret; + if (f_mountinfo) + fclose(f_mountinfo); + ret = fchdir(orig_root); if (ret == -1) ksft_perror("fchdir to original root"); -- 2.54.0