From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B0452F1FC3 for ; Sat, 4 Jul 2026 23:19:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783207147; cv=none; b=TzkcwL8ACDRI+PaHvUisvh9iuLB5nUb1iqmz4rLDstxvBPqFbNpNAqMOCME543AsOTcqsB9kyFPutf5tVAUPQgoRiyIdsy4Q9IqfkZjT2Rfiu8WXlegPv0UwT5K/cT9wOPJU/yMsDMiGgzsmBNQ8i3m//f4QeVHVEKGsnwAh6HA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783207147; c=relaxed/simple; bh=fmvoQHKRvDekxoyTarFeqkgQrkrY0uyxUncqHSFyyC4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GyPxat0XFiBP1gYmLiCbkUfSrzbomW/DeJCZzmCqKA4hO8MJoRcvsNmY+JZ2hMkUmhdNd43CX7T3fXaJgrns5KGs2KYalxdeHpOPLtzipKQAQoV9xGIShclzHrlCeTRW52RwBux2hm02hS2uV3nY6a2v5xcRCX0NQSFrXtTu0dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=evMxH5NE; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="evMxH5NE" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c6b67d5fa1so16800605ad.2 for ; Sat, 04 Jul 2026 16:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783207145; x=1783811945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+4ieKVIWYtjITdsZQG6XsoZ4fXWdYpY0XZnQZWHxe5E=; b=evMxH5NERGS8f7R5IOpU+1h7nsJjwslGIjRWNZ+wFwam/asm/r2RyqTjbucO2uYT+d lYiilgPMDvfMz+OFdqntzsEUXUpW3sOutnOkwwJHbIQxv30uq1ZZhEYWVMPnSjDjZYpU TDrhvrJ2XuX4qBCwRQjojWx5E1Y6574VSbsWLPcOx/4BjLcIhxnq6Vslo0fHUr2Xtid2 VYbPaMqK90yVV3tEvIQjsN5Yp00hWvcXpgV5ahJEaMFh9g97BBCDEz1tUbXDeD75FO81 Da80wI92xWvyXhC0WEBaSqlUdBxTKRIhMjo8Ds+bRDkSph7mApXPj2SE9bl32/Tnpg6J v88Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783207145; x=1783811945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+4ieKVIWYtjITdsZQG6XsoZ4fXWdYpY0XZnQZWHxe5E=; b=sjNPGCeOeKd6mow1vtGUtMXd0K/4jAzKx7KBKH2cwdHSO51nRibPNLgIDyHqZ2hr5h Ll86ozsDI34sd93e+4YqCfwHNz3nGfSV3G7NZ0ISZc0vpHTsC09/U3tIAUZaFo2Z3am6 +oVGpJgtjt4M9jXL+ZGsjou7F1elYkF8KYTysh3JAu/UE5VrJWrHvn/ARGA4cEKyXsdo s9yrJ9kVd7pg2pE5gDfbx8AAPUDrthYRnnyx1ze0QAT+wCfokTpr5Wh4XIh34WHoesX0 hD2od5xQVGbr+zxI63cZEiG34Du7FAEor4OKGtCfLHKmA5UWMrrdRf1yNDLt0mxRa8Y3 Qtig== X-Forwarded-Encrypted: i=1; AHgh+RpOLeplACKenlsJc2WcM01WREyysz1EQul7S9Dw+xDA17R3OlcGDPKqR6MGn70M8OzXtyYxzXqeY08Y1Q8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjq0fTwKabs0Nohb9Av/DdDA9JK1LpL3RripyR9bpLA9qI3hmQ OM5ws45/YfZ3MeuSBNl27mNPrdNuEl2AWhDtL7PTBmZqAcxuMn+xHWjH X-Gm-Gg: AfdE7clyQ8KOV9skt7GV5A0EM2I91Ry7YKnUtlgteUtxgFZPaPqwWQh7orez+gdrFAg /raQjEzVj18xTjwvDkUeGHXzEesRTYcseO1CfUqotWfS1nGMxzC3GgU1bue6ggfgLb8Gkd1KBsY Lbx9MrFPCbCTO5Ll3wtL2wVpHNQPuHeXrpNWS01IVjHnNHj+OA3FLjoSskoHVMBTs+BxuzqIn+N 7LPFKd+HJqdyf+J0KY9dlsrS+qqgjyL9D6kYgkrHYHLGcojQ5WWp8eiUpo0ZajZTtrsE44vAzFg rgdsDnvv0mx1lXhqEpZlyxWRmetVfTjl58CUISI6QEK7sGaHi1OrXDTKUF4kumkdy2ykrPZybKG SdRscGqmXuTdWmGOaU3r4U8I5zpVi+BjoI+QTDnAG2k1lRtgAAeFb7u1lxb791375vLO54g/aQ7 9274xW/AyNpZBuhX/maTmr41q05plchW+Pkfa3NKPj49RsfQbq6Q== X-Received: by 2002:a17:903:9cc:b0:2c9:e86e:a9f5 with SMTP id d9443c01a7336-2cbb9e4cfe1mr46314435ad.18.1783207144512; Sat, 04 Jul 2026 16:19:04 -0700 (PDT) Received: from pop-os.. ([2601:647:6802:dbc0:55ba:96cc:892f:32d7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad776589fsm27088215ad.43.2026.07.04.16.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 16:19:03 -0700 (PDT) From: Cong Wang To: Andy Lutomirski Cc: Kees Cook , linux-kernel@vger.kernel.org, Will Drewry , Christian Brauner , Andrew Morton , linux-mm@kvack.org, Cong Wang Subject: [PATCH v5 2/7] seccomp: introduce SECCOMP_IOCTL_NOTIF_PIN_INSTALL Date: Sat, 4 Jul 2026 16:18:26 -0700 Message-ID: <20260704231831.354543-3-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260704231831.354543-1-xiyou.wangcong@gmail.com> References: <20260704231831.354543-1-xiyou.wangcong@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Cong Wang SECCOMP_IOCTL_NOTIF_PIN_INSTALL maps a supervisor-owned @memfd at @target_addr in the trapped task's mm via vm_mmap_remote(), PROT_READ, MAP_SHARED, MAP_FIXED_NOREPLACE and VM_SEALED. Because the mapping is sealed, neither the target nor a CLONE_VM peer can munmap, mremap, mprotect or MAP_FIXED-stomp it; its contents are immutable from the target's side while the supervisor retains write access through its own mapping of the same memfd. The install needs no target-side cooperation, which is what makes the feature usable for fork+execve sandbox wrappers (Sandlock, Firejail, Bubblewrap-style) that have no trusted post-exec window to install their own mappings. The pin is just a sealed VMA owned by the target's mm: it persists until the task execve()s or exits (a sealed VMA cannot be unmapped piecemeal), and the kernel keeps no per-pin bookkeeping. A supervisor reuses one region across many redirects. Assisted-by: Claude:claude-opus-4.8 Signed-off-by: Cong Wang --- include/linux/seccomp.h | 5 ++ include/uapi/linux/seccomp.h | 34 ++++++++++ kernel/seccomp.c | 121 +++++++++++++++++++++++++++++++++++ 3 files changed, 160 insertions(+) diff --git a/include/linux/seccomp.h b/include/linux/seccomp.h index 9b959972bf4a..a91d1fc8a2b8 100644 --- a/include/linux/seccomp.h +++ b/include/linux/seccomp.h @@ -16,6 +16,11 @@ #define SECCOMP_NOTIFY_ADDFD_SIZE_VER0 24 #define SECCOMP_NOTIFY_ADDFD_SIZE_LATEST SECCOMP_NOTIFY_ADDFD_SIZE_VER0 +/* sizeof() the first published struct seccomp_notif_pin_install */ +#define SECCOMP_NOTIFY_PIN_INSTALL_SIZE_VER0 32 /* up to @size */ +#define SECCOMP_NOTIFY_PIN_INSTALL_SIZE_VER1 40 /* adds @offset */ +#define SECCOMP_NOTIFY_PIN_INSTALL_SIZE_LATEST SECCOMP_NOTIFY_PIN_INSTALL_SIZE_VER1 + #ifdef CONFIG_SECCOMP #include diff --git a/include/uapi/linux/seccomp.h b/include/uapi/linux/seccomp.h index dbfc9b37fcae..d3249294788b 100644 --- a/include/uapi/linux/seccomp.h +++ b/include/uapi/linux/seccomp.h @@ -137,6 +137,37 @@ struct seccomp_notif_addfd { __u32 newfd_flags; }; +/** + * struct seccomp_notif_pin_install - have the kernel install a sealed + * MAP_SHARED mapping of @memfd into the trapped task's mm at @target_addr. + * + * The supervisor owns @memfd and the kernel installs the mapping without + * target-side cooperation. It is read-only and VM_SEALED, so the target and + * any CLONE_VM peer cannot munmap, mremap, mprotect or MAP_FIXED-stomp it. + * @memfd must be write-sealed (F_SEAL_WRITE or F_SEAL_FUTURE_WRITE, -EINVAL + * otherwise) so its bytes cannot be rewritten through any other reference to + * the same memfd. + * + * @id: The ID of an active seccomp notification on this listener, + * identifying the trapped task whose mm receives the pin. + * @flags: Reserved, must be 0. + * @memfd: Supervisor-side fd for the backing memfd. Must be write-sealed. + * @target_addr: Page-aligned address in the trapped task's mm to install at. + * If non-zero it is MAP_FIXED (no existing mapping may overlap + * [@target_addr, @target_addr + @size)); if zero the kernel + * picks a free area. The actual address is written back here. + * @size: Size of the pin in bytes. Must be page-aligned. + * @offset: Page-aligned byte offset into @memfd to map from. + */ +struct seccomp_notif_pin_install { + __u64 id; + __u32 flags; + __u32 memfd; + __u64 target_addr; + __u64 size; + __u64 offset; +}; + #define SECCOMP_IOC_MAGIC '!' #define SECCOMP_IO(nr) _IO(SECCOMP_IOC_MAGIC, nr) #define SECCOMP_IOR(nr, type) _IOR(SECCOMP_IOC_MAGIC, nr, type) @@ -154,4 +185,7 @@ struct seccomp_notif_addfd { #define SECCOMP_IOCTL_NOTIF_SET_FLAGS SECCOMP_IOW(4, __u64) +#define SECCOMP_IOCTL_NOTIF_PIN_INSTALL SECCOMP_IOWR(5, \ + struct seccomp_notif_pin_install) + #endif /* _UAPI_LINUX_SECCOMP_H */ diff --git a/kernel/seccomp.c b/kernel/seccomp.c index 066909393c38..1c0b3bb71379 100644 --- a/kernel/seccomp.c +++ b/kernel/seccomp.c @@ -37,12 +37,19 @@ #ifdef CONFIG_SECCOMP_FILTER #include #include +#include #include #include #include #include #include #include +#include +#include +#include +#include +#include +#include /* * When SECCOMP_IOCTL_NOTIF_ID_VALID was first introduced, it had the @@ -1823,6 +1830,117 @@ static long seccomp_notify_addfd(struct seccomp_filter *filter, return ret; } +static unsigned long seccomp_install_pin(struct task_struct *target, + struct file *memfd_file, + unsigned long target_addr, size_t size, + unsigned long offset) +{ + struct mm_struct *mm; + unsigned long ret; + + if (!VM_SEALED) + return -EOPNOTSUPP; + + mm = get_task_mm(target); + if (!mm) + return -ESRCH; + + /* + * Install a sealed, read-only mapping. A fixed request (@target_addr + * != 0) is MAP_FIXED_NOREPLACE: an existing mapping yields -EEXIST + * rather than being silently clobbered. A request of 0 lets the kernel + * pick a free area in the target mm. + */ + ret = vm_mmap_remote(mm, memfd_file, target_addr, size, PROT_READ, + MAP_SHARED | MAP_FIXED_NOREPLACE, + offset >> PAGE_SHIFT, VM_SEALED); + mmput(mm); + if (IS_ERR_VALUE(ret)) + return ret; + if (target_addr && ret != target_addr) + return -ENOMEM; + return ret; +} + +static long seccomp_notify_pin_install(struct seccomp_filter *filter, + struct seccomp_notif_pin_install __user *upin, + unsigned int size) +{ + struct seccomp_notif_pin_install pin; + struct seccomp_knotif *knotif; + struct task_struct *target; + struct file *memfd_file; + unsigned long addr; + int seals; + long ret; + + BUILD_BUG_ON(sizeof(pin) < SECCOMP_NOTIFY_PIN_INSTALL_SIZE_VER0); + BUILD_BUG_ON(sizeof(pin) != SECCOMP_NOTIFY_PIN_INSTALL_SIZE_LATEST); + + if (size < SECCOMP_NOTIFY_PIN_INSTALL_SIZE_VER0 || size >= PAGE_SIZE) + return -EINVAL; + + ret = copy_struct_from_user(&pin, sizeof(pin), upin, size); + if (ret) + return ret; + + if (pin.flags) + return -EINVAL; + if (!pin.size || !IS_ALIGNED(pin.target_addr, PAGE_SIZE) || + !IS_ALIGNED(pin.size, PAGE_SIZE) || !IS_ALIGNED(pin.offset, PAGE_SIZE)) + return -EINVAL; + if (pin.target_addr + pin.size < pin.target_addr) + return -EINVAL; + if (pin.offset + pin.size < pin.offset) + return -EINVAL; + + memfd_file = fget(pin.memfd); + if (!memfd_file) + return -EBADF; + + seals = memfd_get_seals(memfd_file); + if (seals < 0 || !(seals & (F_SEAL_WRITE | F_SEAL_FUTURE_WRITE))) { + ret = -EINVAL; + goto out_fput; + } + + ret = mutex_lock_interruptible(&filter->notify_lock); + if (ret < 0) + goto out_fput; + + knotif = find_notification(filter, pin.id); + if (!knotif) { + ret = -ENOENT; + goto out_unlock; + } + if (knotif->state != SECCOMP_NOTIFY_SENT) { + ret = -EINPROGRESS; + goto out_unlock; + } + + target = knotif->task; + get_task_struct(target); + mutex_unlock(&filter->notify_lock); + + addr = seccomp_install_pin(target, memfd_file, pin.target_addr, + pin.size, pin.offset); + put_task_struct(target); + if (IS_ERR_VALUE(addr)) + ret = addr; + else if (put_user(addr, &upin->target_addr)) + /* Pin is installed and sealed; we just can't report where. */ + ret = -EFAULT; + else + ret = 0; + goto out_fput; + +out_unlock: + mutex_unlock(&filter->notify_lock); +out_fput: + fput(memfd_file); + return ret; +} + static long seccomp_notify_ioctl(struct file *file, unsigned int cmd, unsigned long arg) { @@ -1847,6 +1965,9 @@ static long seccomp_notify_ioctl(struct file *file, unsigned int cmd, switch (EA_IOCTL(cmd)) { case EA_IOCTL(SECCOMP_IOCTL_NOTIF_ADDFD): return seccomp_notify_addfd(filter, buf, _IOC_SIZE(cmd)); + case EA_IOCTL(SECCOMP_IOCTL_NOTIF_PIN_INSTALL): + return seccomp_notify_pin_install(filter, buf, + _IOC_SIZE(cmd)); default: return -EINVAL; } -- 2.43.0