From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E1D121D3D2 for ; Sun, 5 Jul 2026 03:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783222720; cv=none; b=qSxF9+JfdwHDGy0DjwkDhbTh4jqKhI1O6YRHTmZFdQNQlXVV6p27EdRKYb+GxZoJem/DFA8+4yFKm0grWYNHZzTgjE9Rrjyh7SNreTIM/hHjYVqfqunOfHLgba8bB0W1V7aNLfHu8Cg6EIw5DA0gdk8VZ1b4QJxZ3OMoE9rXRco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783222720; c=relaxed/simple; bh=ANceJ9b98BTOb7cjTXpEWeapQ0x5Y+oW6BrMwWfSbU0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YXEZgTXd1EZ6dWvvPIyCUCpYlx1iJt0m+HPf6KieQQ8lv/oNFhoRoYoBLf4ROn3n8K94vRL0PS6QFrQlFlp4Q9oL8vN3CYI8nZOgl/4p5sQ9rHZwIxMZv4amwsC67Ob5+5hhuYu5JjIJBy10ZpbDafsCjSpKFL8QZqQLqDAjd1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o2B03XZi; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o2B03XZi" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cad8076b01so23792525ad.2 for ; Sat, 04 Jul 2026 20:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783222717; x=1783827517; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WH3fDa/mQ1wFJ8AJw76Ffp4EfrLnbmDhJB4OgmL9g5s=; b=o2B03XZiMmMWEftPT9BHyGuryMxKYMkzIUx5Q6UgWtvm2BzNeNgfiU/PhOhZNBqdZu JmUOKrFDGwYwLL3za+T0566Ek03tnQ6EcM+VsKlPQm7nNpXCjES2paf/UdYGvGMlbq+a Uiatje8KRP0l7/HPrEJVPcbHnTi4WVZBOMOZaxXuB7IL/9spLAKh/hRLoG8/JEvRJaFn d2PRddCVEBmIyqpQFt3BCycVG85Ims5KI1cnaNG4OBwMjSFt+kqZ8fNBG0S38mvsYLe1 2/MvcZvJUuK45UFIFjBfXPhKGP2OdPc6Lj2//IMPWU+66fbLriI0xA/R3eHE7LFQ2Xzi E7fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783222717; x=1783827517; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WH3fDa/mQ1wFJ8AJw76Ffp4EfrLnbmDhJB4OgmL9g5s=; b=Y2yXG344LKp7FocRRmoLL4oJHdBw22A74aMqznycN0J1QUfXDa/xGVXd7mFT4T6vI4 rAyk0QHQ6QFGtaDovNIpYobzwklANqShQrA5XQWpKFkVuG1mg60JYsBYvk74jEjgGoBy lxNDglQjy3BucVCOrQ3p+Yxa7hGHsDtmP+5ZKQgX/zz3g8+006ODcu2WCJpIHiZJDDA9 grSp0lehWyLhXlLC6brKYkqC8HTK/fZEfiRoOPczkZTiq+lA/MMAxaBF52if/o1/4Bsm BOxYPC6VQJRIwtlPhCdWduvWWJZgZGM/IPfG8J2Q8xjrkpUTDWtfgTA8+qg6QB4/Eava Y/0g== X-Forwarded-Encrypted: i=1; AHgh+RrFNu3jKtv9ugoXYnv+JlmwockDssDSuYLho/ET7pwFszrlyFNlIWh/17k1y6XDxgXZADWCl4ioxyL/K+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwXcsbm+o6rWYNPfL8gaJ1DJD0mzUEjCpsSeO2olQL9Hk03qJaD eVx7qBHSP2KfB8S/VHQdq5b3LjMAzstSmlN93lCFgprhQ1Oh07RErWbYN6bZTg== X-Gm-Gg: AfdE7cmDjD5VkrofSYyz0xmcvr7YDXNMi0Qh20g9jC2mQgq3ZRcRmXZTB76rk9IlWQ3 mMvEkPxvqdi3la9NwnZQnNWuGy0SZRs6SGpgPwGzt87gojcb9eV8eZN5odVx6txhFe3ZujIgd7Z ubX14LEbD4/ZnXNX4Wc6qz6vEaNr0VWJBKKF30vVJKfj6iryW5UFgrrF4GFsUZ8h78GSOogbibv 2vS73PP5y5YOd+gNzQdeJ86ZFvSizhryRJWDAsWNmedKbpi0O/nynlLtWGYKuGeGT1bcalKmjPW 6U51WfsI8/PnNw/5/6cARwEmetTroQ1TVlVfpnjw1dJ8O1pwrdnb0AcAOwcVyjqTfDGVNxSXH5O FGKfIETodA4tgxdvpjhMarwE1viwLddYCZxI9cwaIUfRc4okEE7ZClCY95udgwdmU4fNTR6asNB Caog9oKKkPXWuLjf0J3pM5l19kDPT1/VpZ9l3zvw51w+VfAlMu56wVhu+xiRqJCfm6wKBcI5QM2 H2gnsIAupNmMlCoiJNhWOkDNbXWlf0JbMEa9h1E9zC9O2h7vlID++IpsSSz+M8G X-Received: by 2002:a17:902:e74b:b0:2ca:5d24:720b with SMTP id d9443c01a7336-2cbb9f0ec42mr56329435ad.39.1783222717268; Sat, 04 Jul 2026 20:38:37 -0700 (PDT) Received: from [192.168.2.3] ([2403:581e:d87e:0:fc2d:ed31:e80e:412d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b41c364d5sm35463845c88.14.2026.07.04.20.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 20:38:37 -0700 (PDT) From: James Calligeros Date: Sun, 05 Jul 2026 13:37:50 +1000 Subject: [PATCH v3 1/7] ASoC: apple: mca: increase SERDES reset delay Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260705-apple-audio-redux-v3-1-ff7a7afe2b6b@gmail.com> References: <20260705-apple-audio-redux-v3-0-ff7a7afe2b6b@gmail.com> In-Reply-To: <20260705-apple-audio-redux-v3-0-ff7a7afe2b6b@gmail.com> To: =?utf-8?q?Martin_Povi=C5=A1er?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, James Calligeros X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1359; i=jcalligeros99@gmail.com; h=from:subject:message-id; bh=ANceJ9b98BTOb7cjTXpEWeapQ0x5Y+oW6BrMwWfSbU0=; b=owGbwMvMwCV2xczoYuD3ygTG02pJDFmeF7ckMoWf3eS8bHW2lbboROXpn88El2kvsQ6tjrIMX /2z7N3ajoksDGJcDJZiiiwbmoQ8Zhux3ewXqdwLM4eVCWSItEgDAxCwMPDlJuaVGukY6ZlqG+oZ GukY6xgxcHEKwFT3zWP4wzlhU6DomrqseapJ86qXvf12bd3j8F+uquWXZVauPpze8oWRYXrCIpM d9mvytZbe+8zbHK4aKP09Y+VKY+P/hjEaVgt6GAA= X-Developer-Key: i=jcalligeros99@gmail.com; a=openpgp; fpr=B08212489B3206D98F1479BDD43632D151F77960 The SERDES clusters in this peripheral take a long time to warm up. We tried polling the reset bit until cleared, however this is not a reliable signal of readiness to be configured. Only waiting ~25 us to give the cluster a chance to settle makes it work reliably. Increase the 2 us delay to 25 us and hope we never have to do this again. Fixes: d8b3e396088d ("ASoC: apple: mca: Fix SERDES reset sequence") Signed-off-by: James Calligeros --- sound/soc/apple/mca.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c index 492165c0e1ea..ebe116f32661 100644 --- a/sound/soc/apple/mca.c +++ b/sound/soc/apple/mca.c @@ -210,10 +210,10 @@ static void mca_fe_early_trigger(struct snd_pcm_substream *substream, int cmd, SERDES_STATUS_EN | SERDES_STATUS_RST, SERDES_STATUS_RST); /* - * Experiments suggest that it takes at most ~1 us - * for the bit to clear, so wait 2 us for good measure. + * The SERDES cluster needs a bit of time to reset itself + * and settle before we start poking it. This is... slow... */ - udelay(2); + udelay(25); WARN_ON(readl_relaxed(cl->base + serdes_unit + REG_SERDES_STATUS) & SERDES_STATUS_RST); mca_modify(cl, serdes_conf, SERDES_CONF_SYNC_SEL, -- 2.55.0