From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21D1236074F for ; Sun, 5 Jul 2026 07:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783237528; cv=none; b=H0ANT4rHokfZ1XFs9Xeqsl8cV85b/ILjJMGeN1L4E0jqFGrXyfh6ryAoR40ksXK4appa+6EVQudHX5oqE+K8DYgIDOLpz2MV17kfNtQVovcSpcLK5/Cynddd0mGHA9hhqSg0Wv0mHdfjzMBqxoLGvMJoirTMQ/9Wzzw3xktnL6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783237528; c=relaxed/simple; bh=BVW5opIi0+/cE7OlpXBc90Oq74oubV2N/6QRraf3UVo=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=oQbNdfbfUFumI4egCczUZHFWp+RWBk35NexlBOPe4j2ccahkgzKY98hNke//K0z5Bfenj8IleWVoC+HkN5Jie+qpuVc5fyq8UWugC2tKVUZoBmhlWMqq1dof+RagP2yQkFW5i1sY69QmpOkU/S17fnHQJgFKfyorQ7K1JsC/IbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=gRnFhPHb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gRnFhPHb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB79A1F000E9; Sun, 5 Jul 2026 07:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1783237524; bh=RX3le/qPT7zqjelY/UP38ySnAKXxuX0WuhVciQD3IWY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=gRnFhPHbpFC/3ywofs1mMe8NkJOCzc+3slJfghrYxsxz+YxgEIGInp3iiGlEp1eca XT0aXsnw0ZrgZ1Z6y994vzNW+BgoxKw0PjUXP8gfAvSTX3cltwi1+T7VGZSTB2S7En 5lafFxltUOJsBNji181n5RIUffNZSvJXONR3ZDKo= Date: Sun, 5 Jul 2026 00:45:23 -0700 From: Andrew Morton To: Dev Jain Cc: muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org, david@kernel.org, liam@infradead.org, riel@surriel.com, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, kas@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, apopple@nvidia.com, rcampbell@nvidia.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, ak@linux.intel.com, nao.horiguchi@gmail.com, mel@csn.ul.ie, j-nomura@ce.jp.nec.com, pfalcato@suse.de, tglx@kernel.org, dave.hansen@intel.com, jpoimboe@kernel.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, ryan.roberts@arm.com, anshuman.khandual@arm.com Subject: Re: [PATCH v3 0/6] Fix incorrect access of hugetlb pte entries Message-Id: <20260705004523.12817419684173cb1ed1dc57@linux-foundation.org> In-Reply-To: <20260703114202.365553-1-dev.jain@arm.com> References: <20260703114202.365553-1-dev.jain@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 3 Jul 2026 11:41:53 +0000 Dev Jain wrote: > There are various places which use ptep_get() to get the pte entry > corresponding to a hugetlb folio. Some arches (like s390) have special > handling to compute the pteval, so they provide huge_ptep_get(). Use this > helper consistently. > > Additionally, some code paths may provide huge_ptep_get with an unaligned > address. This is a problem on arm64 (I checked other arches and it looks > fine for them), which is fixed in patch 1. The fix is made to be > backport-friendly: the cleaner fix would be to perhaps pass the hstate > to huge_ptep_get() - that is wider churn and we can do that later. Thanks, I added this series to mm-new. That means 7.2 will be released with these bugs unfixed, which may be a mistake. But without knowing the userspace impact of these bugs, I cannot make this call :( Sashiko is worried about [6/6]: https://sashiko.dev/#/patchset/20260703114202.365553-1-dev.jain@arm.com