From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A688E2192F4 for ; Sun, 5 Jul 2026 04:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783225658; cv=none; b=RFTl9okoxSav53vgcIa6LV0pcHuHF7L7kMqmA9Oku3y7KYDewbIW/PXSXqBye1NttRonUXIVjPuT7+lu3TTE5J0DWl9pbepnHq114WmleIndiICRYXTs3RXbSMr6V2CZAL391b8IQfs8SjbuuaLB+1a11AxnoKqfk3ZPG16sCL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783225658; c=relaxed/simple; bh=xXbqEGBTHdI4gCh+pi+4bWPkKiEcKqIDR6p0WzuoYAo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=p4ZUbvoz10kYtoowMi7D/S7jY6oWBwDhCBncn7zSMCTCCqjN7yiAWY/E2Kdhev2BSgNrP/BJYnC1+gWM0JsFPpnfQqxMqIoe7c935YLNT+uXoArm8XbwDbQzb0RGPKC4me7gG/ShkO3nwReu81xzEhvQ54imkNKh9MMbHI7kKoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VOzP8qP6; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VOzP8qP6" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5aeb8870485so2159533e87.2 for ; Sat, 04 Jul 2026 21:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783225655; x=1783830455; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vJJ24iBX9cnCE8ZMUdPAOVzOCaT5jrfPS+x2jz5hwlw=; b=VOzP8qP6IVGH+UxEU0T1NumTvz2E71zhVGFur1hjxOA6zhk1Yjy0MQtOEbJKRUy2ch guIMOc2g6lOhjFXwyNoPYxBwxwnIsdKnDxJH38UHN48ogoDURjyJZ/FvL+LAaytdOt07 7H3wWD79gPmMUtJzrXhps+gllr6pf+xtMdviDM3uhQtgRvHJCHCtYa6GQGlrGuGvp5IS u48F03esV8r5BfueU53p68pKjqS05x/fDqruWsE8mO0BQJXNveH/7VJumeSVZNTjthn9 lAtHR4G61jXCvOXn1+wUesdMvzMGkV4oA/yop2AVCpVF1fXPtvHM2gXewYdbcfVjVSnG VyNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783225655; x=1783830455; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vJJ24iBX9cnCE8ZMUdPAOVzOCaT5jrfPS+x2jz5hwlw=; b=OcJo6kaaOFjIs1+K7cidR92deX8eeowhSd+El0gAXlah1axBHUBA9PeYmtFkyI/Ak4 bMNOa7X3HnIAZGRmq7iia1O+1KdRo5sgIFaRlmZRsbxlhDgV+ZeTbuN2QD17cHXz75sU 3ShuxJG9S9G0HgQ501pKtyzhcqC0bmYyHKkss8DuySWcb3gnF/0+815ghIyN2ZAMHx39 u5xJxSy57Kq+8iRf0Q2StICjZsWv26gadeTkEM/p6mfLefbEG9QcTAI5fpuBdXF0/n9o 1yDHAAu7hPKvUV8dCTfPzjmO3ap/2MAN1DICJkynPUetlFyxCEkTkCZszhh/0SnalBdC ooWg== X-Gm-Message-State: AOJu0YweFtXaytgeFwDt2gCOaVUYIjoxGSvtx4ai+6PReuAxKuvUxV4T R18ep1BsKSNE3/SF1yVLghN1uykKFm0cjsZ6Wt1Pw/v+Qxy/ZQfuSqfJ X-Gm-Gg: AfdE7cnr4T+6MJK/1FdRa54edfvpRAD4XWkVXlr942FY48WCA836A8w5xzOpiYVrKSi 1KO/rOAGATyRPVnLMXML7M7JOFGKJkgwwINfI6UtfhJNu3E6/REwP2X69whGJSQ7fCksOqNZR6/ Rld1uun0kdWaCIsiQLbT7kK7Pl+5dRyAcfua0hLmAMwajUzVPeYrNKa7poczUGkbPcuAMPwOCbA VOoGdPKpKGtNIGJUZDXxlxKAfH+pR8mggOebF1ITNFBAeqi7a4xElJS/ixHdhh8+jQi2w/pzqDa KEMUd8nPHUsllslmbiKJHyrupLKz9GW7uD5nABJi9c3jmPRS+fwNaypZHdTXUjGs7JVphXnOoD7 AUZBPisfM95Zssc5Su9JlwjQq/M4DOziQSaNm2OmzV1GBjn+Ovsmaq01Leyc9rA81qYi5+tR0Zo 6lEzUiLG134+s68LMQc5f8SEKdRhoAc7Po23v2qERERQ== X-Received: by 2002:a05:6512:3d87:b0:5ae:b7d4:7dda with SMTP id 2adb3069b0e04-5aed50b668bmr889740e87.32.1783225654553; Sat, 04 Jul 2026 21:27:34 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f9:2a:1c13::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed1377068sm1798289e87.27.2026.07.04.21.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 21:27:32 -0700 (PDT) From: Melbin K Mathew To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Melbin K Mathew , stable@vger.kernel.org Subject: [PATCH] iio: accel: bmc150: free irq before teardown Date: Sun, 5 Jul 2026 06:27:31 +0200 Message-Id: <20260705042731.388592-1-mlbnkm1@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit bmc150_accel_core_probe() requests the interrupt with devm_request_threaded_irq(). The managed IRQ is released only after the driver remove callback has returned unless it is freed explicitly. bmc150_accel_core_remove() currently unregisters the IIO device and triggers, cleans up the triggered buffer, suspends the chip and disables the regulators while the IRQ action is still registered. A late interrupt can therefore run the hard or threaded handler while the IIO trigger state is being torn down or after the device has been put into deep suspend. Free the IRQ at the start of remove so that no handler is running while the rest of the driver state and hardware resources are dismantled. Fixes: 55637c38377a ("iio: bmc150: Split the driver into core and i2c") Cc: stable@vger.kernel.org Signed-off-by: Melbin K Mathew --- drivers/iio/accel/bmc150-accel-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c index 2398eb7e12cd..2adddc965650 100644 --- a/drivers/iio/accel/bmc150-accel-core.c +++ b/drivers/iio/accel/bmc150-accel-core.c @@ -1766,6 +1766,9 @@ void bmc150_accel_core_remove(struct device *dev) struct iio_dev *indio_dev = dev_get_drvdata(dev); struct bmc150_accel_data *data = iio_priv(indio_dev); + if (data->irq > 0) + devm_free_irq(dev, data->irq, indio_dev); + iio_device_unregister(indio_dev); pm_runtime_disable(dev); -- 2.39.5