From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5BD2C0303 for ; Sun, 5 Jul 2026 10:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783247717; cv=none; b=iUGT9OgXpwC9K9KrWxNroErPChJD+DFiEximYejx9AWBpqpZc6PeaVw6C7zO4rEa2pJ1/J25obIX4Moi6Mo4tXFu1pPGN0hMVnwCWMsofc1dK6+sfAgd/xSC1bxDyokehWPFOvG6xXmCANRYWw2ONXcmyf2mWl2E079TgQ/BC+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783247717; c=relaxed/simple; bh=QUpOtjJA1fKKKIGK+q5DkLiLn6j++MwmNQcpg6m7bu0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gvWIygIH8Kqz9FbDIgsHq1X1/K19lvqLQVuAsBKozdXQELMpFyJh9oQKz/hxeJ0T3pOtGDAxLxIeGUH1DjCRvNRkU/jrBXevS/RAU05YFPsriKswIP3fKrUf7j2BXIo7nPPojBgQQOUEt/cHKdDdHOzVPY54mD4wKbnoKDeVVEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Da6KcYJo; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Da6KcYJo" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-847aebc56b6so1499812b3a.3 for ; Sun, 05 Jul 2026 03:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783247716; x=1783852516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uc2/OX4P4+qZ8YfdxG54xkPztMxglA34ZXzI4is0OPI=; b=Da6KcYJoOe9B2he+apGmcS1skqHYP/0tc9h1Miuf4lJEjvPzqH8cxRDVNCptD3uVgR +WzTRNVtaFuDiywnO73x9dvwv6czKYpRaWEV1VHVo4kDVf+mPKWrNBnUoW33iffZ3AyM WCLPkqv1gVc+SuFXoJF3f+GuR6gnhVV1kvnG8GwaApmt03qbgv29kc96LesHkBfQVtT9 0FrP+zhmynJCNgKltn6GQ+8yTCG3KqslqP6GyrqoKp2rKn43Y1QG/jYH6cqaILnl7zLq 5R0os4bQDbZaCbRuixGX+pRqzwdZhyVP6TmtWOZLsosy/tudWQ5LDFChF8FQUuEXDOAG 9/tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783247716; x=1783852516; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uc2/OX4P4+qZ8YfdxG54xkPztMxglA34ZXzI4is0OPI=; b=ccrdT6tByxWXKQNQRupJz7RLZjDGrB4h+uW3Nq+VKi/kfwNsp09H5MRwcsMsk5LLWO OcwdLhA90hyOUpamhkfHWgEGP4Hc9JV1BXkWUMw1O4iazLXqnvneKNbHSw1ULZQn3Xft lOY8APADPzQmGA1w56/DfkQIx6kPlJ13/dTyx7445naFnttGOjy3uy3nLKYs7pnValcJ 0dDDjZuU9YWHV09eeXFaODMKrBIAaTZaD5u8LkmBaXb+IPV5elcmOuYpFPE4JpMGobCV 2YmZb68ND79STpbeCxTkAMbao3Fc0BBoDHjzDPL92PomcGNOAiiBYpWT7gLQwEUSq7qK x/AA== X-Forwarded-Encrypted: i=1; AHgh+Rrue/S24OiGHfsOwf8nEoLrOL8Iqq6vC0hro/gZCsFb93G0buOmwJSERUDJPZMF8eO4Jj98VbI8QmrkxjI=@vger.kernel.org X-Gm-Message-State: AOJu0YwMr9HlZjonnoZuGKSOghc3BMt7M8CsyJ6tBcoEIZgvlLukDK5L r7HrVHQPCCp3PjD3T4Ty/QOMHoAklNlUPanxI2aV6lg44FdbCfPeuU3G X-Gm-Gg: AfdE7ck14D2GtnSNl8y/fAzd2wxrZ9+03GFXb49CgRvBzAg5Ott6giHLgvqeQHkTwcC kVfaxl77vLgzidEHD1l4ahSMdcFjPQevevycac397IfffoHWU0PfP1u93EdXlu5KnaphIWiHfSc PugKQ1UPcCj0+CUzzWjdEonaPgtfGk+55MynXDuy7yFKrhfksH8vxrXEkNCNiwspGqKp4K/qXfs H5rBDeK5JE6QRvHnTQxnsPNMzDKIepuv/2fH+fyLUV/wu6QaaCXrCRLZWx762GnfDpANBwXjh1G aVLhr/1LYdJ71AivGGvzk5/dJQA02rV13lcPILRU8rthP42hXtN4W5FzQzJmdMf4qLspbGvPHRO nvkOn4XBAAvI76wXVQDMIz36znxl4g8g8wehfTLSU0rnHVz+Z7erJ/45hlGo10Rr+CR7F1LU= X-Received: by 2002:a05:6a00:2e1d:b0:845:d286:1fb6 with SMTP id d2e1a72fcca58-847f6fa9cfdmr5543003b3a.52.1783247715985; Sun, 05 Jul 2026 03:35:15 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d82382sm2129385b3a.49.2026.07.05.03.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 03:35:15 -0700 (PDT) From: Guangshuo Li To: Sudeep Holla , Cristian Marussi , Ulf Hansson , Peng Fan , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] pmdomain: arm: scmi: Check pm_genpd_init() in probe Date: Sun, 5 Jul 2026 18:32:56 +0800 Message-ID: <20260705103256.284467-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit scmi_pm_domain_probe() stores each domain in the onecell domains array after calling pm_genpd_init(), but it ignores the return value from pm_genpd_init(). If pm_genpd_init() fails, the genpd has not been added to the global genpd list. The probe code nevertheless stores the genpd pointer in the domains array. A later provider registration failure then unwinds the array with pm_genpd_remove(), which can try to remove a genpd that was never registered. Check the return value from pm_genpd_init() and only store successfully initialized domains in the onecell array. On failure, unwind the domains that were already initialized. Fixes: 7458f72cc28f ("pmdomain: arm: scmi: Fix genpd leak on provider registration failure") Signed-off-by: Guangshuo Li --- drivers/pmdomain/arm/scmi_pm_domain.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pmdomain/arm/scmi_pm_domain.c b/drivers/pmdomain/arm/scmi_pm_domain.c index 3d73aef21d2f..a60189ea32a8 100644 --- a/drivers/pmdomain/arm/scmi_pm_domain.c +++ b/drivers/pmdomain/arm/scmi_pm_domain.c @@ -99,8 +99,12 @@ static int scmi_pm_domain_probe(struct scmi_device *sdev) scmi_pd->genpd.power_on = scmi_pd_power_on; scmi_pd->genpd.flags = GENPD_FLAG_ACTIVE_WAKEUP; - pm_genpd_init(&scmi_pd->genpd, NULL, - state == SCMI_POWER_STATE_GENERIC_OFF); + ret = pm_genpd_init(&scmi_pd->genpd, NULL, + state == SCMI_POWER_STATE_GENERIC_OFF); + if (ret) { + dev_err_probe(dev, ret, "failed to init domain %d\n", i); + goto err_rm_genpds; + } domains[i] = &scmi_pd->genpd; } -- 2.43.0