From: Christian Brauner <brauner@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Bradley Morgan <include@grrlz.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/1] signal: avoid unconditional siginfo copy in send_signal_locked()
Date: Mon, 6 Jul 2026 11:11:33 +0200 [thread overview]
Message-ID: <20260706-bewenden-mitverantwortlich-couch-4f2bc160dc96@brauner> (raw)
In-Reply-To: <akkaAgNfUby5_3nM@redhat.com>
On Sat, Jul 04, 2026 at 04:34:42PM +0200, Oleg Nesterov wrote:
> send_signal_locked() unconditionally copies siginfo before the namespace
> translation to avoid corrupting a shared siginfo.
>
> Not that I think this can actually hurt performance-wise, just it doesn't
> look clean to me; the copy is only needed in the unlikely case when the
> translation will actually change something.
>
> Defer it to the two cases where si_pid/si_uid are rewritten, and while at
> it add #ifdef's just for completeness.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org>
prev parent reply other threads:[~2026-07-06 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 14:34 [PATCH -mm 0/1] " Oleg Nesterov
2026-07-04 14:34 ` [PATCH -mm 1/1] " Oleg Nesterov
2026-07-04 14:46 ` Bradley Morgan
2026-07-06 9:11 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706-bewenden-mitverantwortlich-couch-4f2bc160dc96@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=include@grrlz.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®