From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0AD133A9E9 for ; Mon, 6 Jul 2026 13:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783346009; cv=none; b=nu3TyrJb4Okdz05tqXZpbJEln727rsxRgyEK22P5VsFFKaqbO1VFH9t2FHtCFjAbKnWkdvFfkGIllelbJ/flOBtex4vvBEfLEjlSQpnX6Rn0SftOsIQyPsk6KAwzCX9oRv3GKwcLpQg+3sn6UNYlHYDDmVoGSDS+JUGZSR/Qvkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783346009; c=relaxed/simple; bh=Ie5pYBqhk3vp8OQsIMaFbe7S/1NFcDmqVuYASiDHrc4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H5vmD1OiDRLgKbkiQEBa7k19QfGeP853SFeEoWJc+Pap0ftiQBMrwWcRmtXSF5Ii9h9CIyaPiEJFMVHfp4JrpTj/2IFHB8AYJOby4wr5JcFTew6ZOZVEZzG5eR9ObiyyRpmltSs1aVv0C7jQRdf/c1IHlMvDEZ7AaqTYND1mEV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aXpKcu0Z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HyP0lnsk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aXpKcu0Z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HyP0lnsk" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxPVs174990 for ; Mon, 6 Jul 2026 13:53:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gh+NdjO2RmlO1SWD3vOIOXcduq0pfLcMmTUXy69Xkyc=; b=aXpKcu0Zv5LZzomM nyrUBYWSHt1GXQF3BFh+eV2Uj4uHwpwgoEHPEL4SfAodn5UJTY4Vb4POgqCtQBEH ZGX5ds9lr/bti8oShh/ssBZ/PsEN+G4ccwpK5U2RoFTD0/Lq/hFqp38jn661njeH vnsXy+t/BcORj/VA2VJyLfW2ZcMohRD5FcOj320rnrJWjUDgFLpV4jQMC6PocrCJ cVgJAiEaeRVg5PEvxv0PBy7rY+cS8lZf/La3afsCvHlR0bkJLwcjPLW/MjYBjoBA /I0ANUdDd68rU8TzFd3FEmwpAkUjsOkp0YU86nVFMWfNYn/KVMUN4/0RmYs9mXjA +Vog8Q== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87rxsjxd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:53:27 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-59d595bfd94so1090291e0c.3 for ; Mon, 06 Jul 2026 06:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783346006; x=1783950806; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Gh+NdjO2RmlO1SWD3vOIOXcduq0pfLcMmTUXy69Xkyc=; b=HyP0lnskbSUhs1xWNiZP/Oa50M3hgXddr2iTfj7/BUKpAvtEQP6swv0z25XxstS1XR hOSC0AMAm0BYNvjVDHb/e7H2iuM1dov0Bmc64Nry2pMACdBHRcw+okYXMQBj7tXSaXBS 46zxpFW1iGJWZM6/eREA3vfBpz4jkpUYMmk7+Zw6O9P1EFZ2wI8RrGfFEHIcGUbccHw4 7SuTGcGqUuhpNbKGNxzUqnev08tM2wYDBcXwNej14MbsXdB+5yddLlIj1irn/xku1XlH wAZ61aZe842PHEiSW7dYPvb4kDvd+MwWd8DLjIafWOxy6oxxchXS0yHoPHlgCmDRCn4/ ja5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783346006; x=1783950806; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Gh+NdjO2RmlO1SWD3vOIOXcduq0pfLcMmTUXy69Xkyc=; b=cmALnAq9Altl/xFnOlpvwAy+PZxX9tCR2oii3W6hLTjGHIzk0Kz6qq4VgRpZWz1hyq 9rhG1Tt7bx9wFKTfpGJTsrb6awp0Rg592cRzp+0qkYtCYCBUzNtEbje4oNMAVvPkV/Fp UtWKaPdpJ0NIZVrtEgqWG1FFvBgpR+3BwaiSzO0gdz8dRkjD+TbWSdpWMs4VoXowuzKJ Ue8WctfkeaeXOzV+LRLxQYUNu/8WyUAmkQ709NHAIrHh5UF3ADx9ODn0Ifp3/gbiYtFR AV/q1v82FJCHPqoK+42e0XOtHe+EsgMMyrDdTfSmT3MfcwD5nyNfwJupdz9fEe1921Qr 6bRA== X-Forwarded-Encrypted: i=1; AHgh+RoG6lqjcRzcwISukGADRBphOKwdcP2vgzx95OFsYO//stUe8YoNayxnaBPsbsLaIw6A2mJVMgHlxiEo6n8=@vger.kernel.org X-Gm-Message-State: AOJu0YyGRviObb/f7k+BY47RX2Ltp2oV7T5agPTH8smERY+LfRQiDrTe 120kysqNAu4d4Bgz6y9NxGW5d1gxYHTZdWd0y8a+RgJ+cg4gZ+8xR+pYtudqjTVBwyPiv6dI1Hw ly7CDPhrhqdIVYrL6uwwIoVzcJTcfmnEArStJ8V6FyckIXiUVLOZ9tTXe/zRK6SSDJQs= X-Gm-Gg: AfdE7clBRqJVQs+32rY1MP1S3pkL8EsgX09LmMvQu5sSLPKi/ouN/G+DqFce7f03aPX V2pI4Kd5SzIiig6LnmK4Am3ofolMn2P63kamULnrLNy/gOowEUy70zSoJLxlUOCJkuAct2HZ8qh gLMgP2Ij9fGfLqHi2vTWN13r4HclD9/Og1XEb13JnOEddF5srkAwt10fvo/NMaPCLmWg2PNtuv4 L3xR9oSUO/BVr8vsrQLoZmmO8h/WjekyE1d3TdN+1NraPfo3lb5dvpqNdZh6XE+qeJfIDemAuUO N4wQD5Nv2eIAlBrozxo+VRoc9o8/prPpIbddzBDXEb/RXjcYzrRyMe6ADWc7djO+PRoR6lWfBR9 7/kGhDshZov8L9VAj7pYnPvma1eIZYU9ijErmLaTw76ZMvpcCLtBKrbDvz62xmAr9rW+ycJvKnm LXXoESwsvd3PcFwCp+qGo+/8MP X-Received: by 2002:a05:6123:4b:b0:5bd:b27c:bade with SMTP id 71dfb90a1353d-5be907432a7mr312216e0c.5.1783346004489; Mon, 06 Jul 2026 06:53:24 -0700 (PDT) X-Received: by 2002:a05:6123:4b:b0:5bd:b27c:bade with SMTP id 71dfb90a1353d-5be907432a7mr312195e0c.5.1783346004009; Mon, 06 Jul 2026 06:53:24 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13701easm2932551e87.16.2026.07.06.06.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 06:53:22 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 06 Jul 2026 16:53:15 +0300 Subject: [PATCH v2 2/3] phy: qcom-qusb2: correst PHY description for IPQ6018 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260706-fix-qusb2-v2-2-8d9cd73b1db7@oss.qualcomm.com> References: <20260706-fix-qusb2-v2-0-8d9cd73b1db7@oss.qualcomm.com> In-Reply-To: <20260706-fix-qusb2-v2-0-8d9cd73b1db7@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Kathiravan T , Baruch Siach , Dmitry Baryshkov , Krishna Kurapati , Manu Gautam , Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1792; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Ie5pYBqhk3vp8OQsIMaFbe7S/1NFcDmqVuYASiDHrc4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqS7NNWJ0d844JtYmUmLQ1wgzvuIfVAsHG6ccrZ +CvpNQP3bKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCakuzTQAKCRCLPIo+Aiko 1ddPB/9qHlktAkKXgnjmWI8qkAJsxso0HoXFYx4cGpbhfDeEv1zAdr+41NnrF5RfPh1nDBM29pe +AExWZH7N3dlhNtQ3fJ+UVe8Rd9SvN7qM6Xss2xkkRdj4KxT/mNVH/Uqm4hUqPvCWT7sfszEz2U yIQdfVSj+tQ1E1GJ5mEH+5tAmu4Kxsce8kuA0ustU2FUxhEu0n+JapGOnoHEoKKremkpCsy09Ct QBPwEohc0Be0yapfxtNweN5GVIw3P56gIiMwC2XpUwxCofKL2IpcIWNf/bp0aHd3iFUnuP+RMsP jIfD2IAn/wpdQcRntghLZ6eaTzGBzVE+c4k7rTvQ7vjWItZ3 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: -ASCSjkRMXsHUA_4pS88JNrAXPWckuY0 X-Authority-Analysis: v=2.4 cv=Hv1G3UTS c=1 sm=1 tr=0 ts=6a4bb357 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=rLpG3bFX5iBGt7CpEVUA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX22Vpkb4CraL/ rk+ibhQGCTCYyTw2xQRxb2CD43E5xyc/UKS2HXDwqEttQ+hKmU4/VSWyEZ3R9Eq1X9KYIJNgta/ Sx98sK9Vc/q2pOJwfoQMmWh74W7OGpo= X-Proofpoint-GUID: -ASCSjkRMXsHUA_4pS88JNrAXPWckuY0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX56I/jcxNuB+u oS0ilRKFCd2zwoe/P/6OLFlh75y/nTwuIpS1g9KfZf6jIj7RfWYL/5hs1pEX7iIkFjw09z++f9s oyzPeAMihtsv3eBwWt0BGKozlgjKtlEQ2EzniyTCEgQU6FuBu1zUFDgd68Um1OMtInZF5v+fDRp nSpzjE7P9u31RC8qmwb0Uz/H+pJV2uIMdFTsWPO7OtIaSDwxA8EALmasLAvkeDdbdW2qPNi/Lz5 iMGhdSI118mV4SIQoOMgrQTjJqz+c2950YjD6gssm7vU33G+lfuQND2NFXYVm1y4hsfb768n9St 6cpcmLS8hKaPqgkQZBIH6dO6AcqEoWvLTHw/12KEVAZSsTsPipuCpFHZI7j8OGHhfL2eKubtHJa VieP0vggb3HObRg7BRrNmpTsAsvqK+4T4trNCRLCNOmT2V94k/u0dErpqDfJmlsospMOPmHonqI lRJ3zRECa7la4SB8X5w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Qualcomm IPQ6018 doesn't need to reach power collapse or retention of the USB voltage rails, so autoresume is not used on that platform. Instead of programming a fake register bit (BIT(0) of TEST1, while the QUSB2 platforms on that platform should use BIT(3) of TEST_CTRL), explicitly disable autoresume programming on these devices via the flag in the platform data. Fixes: 2cfbe6765b7a ("phy: qcom-qusb2: add QUSB2 support for IPQ6018") Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 15c36b594c09..b1d34b080cfd 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -294,6 +294,7 @@ struct qusb2_phy_cfg { unsigned int mask_core_ready; unsigned int disable_ctrl; unsigned int autoresume_en; + bool autoresume_disable; /* true if PHY has PLL_TEST register to select clk_scheme */ bool has_pll_test; @@ -341,6 +342,7 @@ static const struct qusb2_phy_cfg ipq6018_phy_cfg = { .disable_ctrl = POWER_DOWN, .mask_core_ready = PLL_LOCKED, /* autoresume not used */ + .autoresume_disable = true, .autoresume_en = BIT(0), }; @@ -676,7 +678,7 @@ static int __maybe_unused qusb2_phy_runtime_suspend(struct device *dev) } /* enable phy auto-resume only if device is connected on bus */ - if (qphy->mode != PHY_MODE_INVALID) { + if (qphy->mode != PHY_MODE_INVALID && !cfg->autoresume_disable) { qusb2_setbits(qphy->base, cfg->regs[QUSB2PHY_PORT_TEST1], cfg->autoresume_en); /* Autoresume bit has to be toggled in order to enable it */ -- 2.47.3