From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AEE61A3029 for ; Mon, 6 Jul 2026 03:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783307196; cv=none; b=dnKTo56azjgMJMrPFlDg67HanIi+DVjeZEzuP8juQzgYGb0DwiGgF9b8RQWAXEJSHypdX5xTbomloQRxIuIgqBJju1KlMhMPH97aD+e77wAnCbSJfAwhlSg6xF6w95gsNe0NBH/PtvsU7BZ/fwarmT9FyN83Bxyel6R1gixF0ME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783307196; c=relaxed/simple; bh=XOfCdFUKFIo7HMCTJ7WSzTMTIpbQEXqIsg/t6NcO5Y0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OGk2KdqBdN8Y+JFa2i+HK7CwRJn7aH/5w+AIE2EEHcvcaGj0hvIrLJ40kJxsX7rXpEdfjvmrFBMMurxKgkvY/6tnykMGpJTva1l8HBh4C2vV6GN0gbscl7Zh7ji2nqNPHsBR4rjWrEHbfMauO0Dsu+hcyCIDYcRchQ+RroEphn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N9KJmBnr; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N9KJmBnr" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3811f512167so2167749a91.3 for ; Sun, 05 Jul 2026 20:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783307195; x=1783911995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qZgDyLyNz2cPWa9DlLdj8DZ7TG8u0RQDUWdSZBVgwfo=; b=N9KJmBnrkOchfyBIJHDL4otrhfrzoz1347qnNNbQJbo2ympIkrOLI4dtalw8U3dumi sRbaN3sPYkVojDYZZOMGXTXlrO0LFX3bQpzgZRuV+UpqtyfOS07kwenhfGMgdtE4GIcf lVlV7Yd6UzxYilTTYe+TMcc55uR2XwiI9hOSBKNmF8HlED1NTpjLC9JCdricgR5BF0No H+vmBkzAdoRYUk23sGuvAHEVtMjBItV88m+Ckdz4x+Vgppm1CjqzZ+PHVu7wOvBT+idv ufcCfkVmmFiVqWM7Qf0jnDw6QQo94rSCsWq/CfMlQng24ETcZ45LDqAkUiqJkhfDhtWZ WP7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783307195; x=1783911995; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qZgDyLyNz2cPWa9DlLdj8DZ7TG8u0RQDUWdSZBVgwfo=; b=qP1AOKzNln5P5WFPCNBeH2423DjHoUN99Ct8gMf+OG2DLPGbo+69AFFA8W20/mCanS /Oq6aprOswdU2r9/Blth2+IH3DSbmX/LOyyxJteKVyZ6NGcjdJ9sc741TwncIOrxqIQy ZAiJ6EjBjQZdYJtdG1uvuehpF+bKCO69eINp3zktCqU1zfkHw5hzgZ6Gnjc1e6SWt+Ln NBRx7xsn3G+HGAaxljGOWaF8qVecULL1DprOH+K4VY/4LUuL3GDKyv1H5ctt8pJHL5mn aVBk2weR5KXFjYsbcmVNz52viXv+L+1i1DpzkOElAB8Aq0Q1hN/DqhQiWis+lUijvc24 hd0w== X-Forwarded-Encrypted: i=1; AHgh+RpufFAZmfSMDjoqJE3c0jFJASYrs9OIZ9R9aXgOtOGTDcgWnlRJP7vdFgG0pOazjkrEnfI9veuHgRQvCoE=@vger.kernel.org X-Gm-Message-State: AOJu0YwgzHr7+JOmleVAaRUlj3gLX36hX++uYAXivM/9PzwVDYAV77pP CDGekqFBeo5xZp6Yo5PH0bXhCDG4ixIhY8c7PKlxFYZg7DQ8ChcVENjqUteiZQ== X-Gm-Gg: AfdE7ckBQxYD/MsJ/93z14qXwQ2JJHThOXxQjlblcHiFnOXIPZYv4WhNglbyncoAPc/ 8XL1u3po/BU6N+Vi+MLVRxkWhkm0hwUSpKDw0hMcJabyW/EtYbuFMBW1r/r9AJkVbjprrMMyHU9 hpjIZ5tIW33rcqoJ6iDLuJPmONKnJrSbGZh3sAMU/g852/GoZrYZ+KK07xqf5b7gczNVGfFkNwz +R/pO5B5q3TURmrf0HCqL2JlEgXvL8pL9lRKg52fgAiQ99uFkaW5VZY3AApYDEmVNwRi5wfK+sU KtRKitV3+AddKSo7upKUzIgQwwJi/Ff0ieOSQdnbb9tDvc/QYT3ar5G1BFyTvypbOE78oKzT01L XyEXMrz6ICAVfuHVAxGyLnuh2a2qlPYA2fBo5MHcJH/e3I2S7EEsjLwMKIhtGm7Z/l+Ip420JoR G+qFqyCSr3A2uXifJs0V/5Fw28jTSZ053RMoNGkIbFRvAuULjcIY5D+XrYM/TDBcIMXLyjWoBor VZvW5PJzA== X-Received: by 2002:a17:90b:48c6:b0:37f:9ce3:ca93 with SMTP id 98e67ed59e1d1-3829f8e55d2mr8819064a91.28.1783307194975; Sun, 05 Jul 2026 20:06:34 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38127ae1333sm4056699a91.4.2026.07.05.20.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 20:06:34 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Madalin Bucur , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next] net: dpaa_eth: convert to napi_gro_receive Date: Sun, 5 Jul 2026 20:06:32 -0700 Message-ID: <20260706030632.1826810-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace netif_receive_skb() with napi_gro_receive() to improve receive performance for this driver. It has rx checksum support so routing speed shouldn't suffer. Tested on a WatchGuard Firebox M300. iperf3 bidir speed test: [ ID][Role] Interval Transfer Bitrate Retr [ 5][TX-C] 0.00-60.01 sec 5.35 GBytes 766 Mbits/sec 184 sender [ 5][TX-C] 0.00-60.02 sec 5.35 GBytes 766 Mbits/sec receiver [ 7][RX-C] 0.00-60.01 sec 5.50 GBytes 787 Mbits/sec 124 sender [ 7][RX-C] 0.00-60.02 sec 5.49 GBytes 786 Mbits/sec receiver After: [ ID][Role] Interval Transfer Bitrate Retr [ 5][TX-C] 0.00-60.01 sec 6.49 GBytes 929 Mbits/sec 0 sender [ 5][TX-C] 0.00-60.02 sec 6.49 GBytes 928 Mbits/sec receiver [ 7][RX-C] 0.00-60.01 sec 6.55 GBytes 938 Mbits/sec 0 sender [ 7][RX-C] 0.00-60.02 sec 6.55 GBytes 937 Mbits/sec receiver Assisted-by: Opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index ad2d8256eb8d..83191f636ec7 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2824,10 +2824,7 @@ static enum qman_cb_dqrr_result rx_default_dqrr(struct qman_portal *portal, skb_len = skb->len; - if (unlikely(netif_receive_skb(skb) == NET_RX_DROP)) { - percpu_stats->rx_dropped++; - return qman_cb_dqrr_consume; - } + napi_gro_receive(&np->napi, skb); percpu_stats->rx_packets++; percpu_stats->rx_bytes += skb_len; -- 2.55.0