From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011065.outbound.protection.outlook.com [52.101.57.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2D42E7631 for ; Mon, 6 Jul 2026 05:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783317355; cv=fail; b=hwySn7zsAJLMsDvACVa3meFdGV2ZxpLpc0K9vUltVS6jmt+kQ2R9pUrstBIuMhpK1Nlm7Gfo3sdyzWSGbS4WJcmitPjAR7Fn+SheGHGF8LIPDZHXLJOsB0SfqO+yub0xAsb8TjzsNgE9FMpdtrJnHv+FLMs3DKUpDGBYL49m7fE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783317355; c=relaxed/simple; bh=L0CGptIVAkEwIKk39lb0lwM3wQTjpEpLj9DFBOXLd5Q=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=ceKObDwf52aZB7GfknX02jREWUhkDGFJ0XH/pAy85QVmOXB7CzlMn3Ec0BTL8M6ifPk4or8ysbKruC61eK4ckDPYZPELnH2+iRteQsWjz5PHeGdKdaqgY4q19fV4wmQGdOS7s4U0I4pIJn+X64bmxV5DlX+GSb4yQdONoPSaGss= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=p9cqn2rW; arc=fail smtp.client-ip=52.101.57.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="p9cqn2rW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yb4dshejFhDCjneOf//F0E0ekX64l2nzIcKz8npxJ2n26Cc6ohrRRGKBL73YYvvUxDw4uC05eL/0l9j6VIe9mkF38eUVyFiP1PlUEO7qBOd/CX7xi6E+TsNsktRxcM3TJw0UzMsWY2FnwPwGdepbQtx+sK0u7uT/y9wfHZFZMQJDZiUf0UusO9XTG1hrt8MpgOKwbe/cXLWX1EPmrkggf6xpmoJ2wsbWiirW91tlL9x/nYrh+8T5ik0GB6LgniXyIPPiiSBF3uiWw4hU+O6sH8y8Ng/wG8hcOKTbBQ8dGNT1MgqQOmhs5tYVrAMAZs/6yZ+c3RNWwf/DCl3zv5aWDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JGkMhnD8zdieGqYeh0F7dU135/Ngjo8aydGxlrssbx4=; b=ixhK/rAvK0G2oxYGaZlMmQHgjkSB62E6eLa7kHaaJOm79zq8CkOvhe4UcwUTMeTC0jsDnL1uiUSzSmQ4UqNRvLO1kgLsbjHBrdQc+ZrP/LQvsQ3QPEZjQltO6R7K1sIC5qsRrhga+6J8rGAUkKY1Kx3rwe7SBaX3Y8RWF5q+yMIChnXnr4Wltn9JMbb3bZQs2mScbHHs9p379RLCwNDRpaLtnkMasarBHSh3dQtnd8KhQfMbqLrhNCxk61wTHY1rPn5CxMKT0TzSNCQDmYFTIVecvGLeDlhonH/u1B2PftsL9NmTNQUGhQvYnu3LwBCd2PeNxOg0Hm77mTffS59CAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JGkMhnD8zdieGqYeh0F7dU135/Ngjo8aydGxlrssbx4=; b=p9cqn2rWtZ/oW/EYCn5ZcnpDUxTODdm4+CmEKyzPuiXXuJWaZMxITPmgD/7xvUoymL1mg36+Aj8h7gKScq1uXSN1YB3XDWDyNRBF9U+BRMwc6KvLZ1pKF9LBN8NCwkmCcK39ezDod0hpsRoEagNDKPQWR2oz9GMHE+6R9kEcMzRxHjuVOpdUDUZM1kJJ3adPQeeAheVDDz0i6b3/m4lmcJtzomPuhnv1Ui9/W1q/3EEt+lDp0MHpbdnsH535GvQ55SAlUN+zWFbMxr00JLzRrCA8hF2qM6P02/E4Xn8Tim3z9L+3zXqaulUfwNcqS5HSI3lk26WQ04zX/ozM0nX+aQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from LV8PR03MB7398.namprd03.prod.outlook.com (2603:10b6:408:18f::13) by LV5PR03MB8388.namprd03.prod.outlook.com (2603:10b6:408:35d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Mon, 6 Jul 2026 05:55:51 +0000 Received: from LV8PR03MB7398.namprd03.prod.outlook.com ([fe80::9d6:b5c1:7f72:e982]) by LV8PR03MB7398.namprd03.prod.outlook.com ([fe80::9d6:b5c1:7f72:e982%4]) with mapi id 15.21.0181.008; Mon, 6 Jul 2026 05:55:51 +0000 From: genevieve.chan@altera.com To: Dinh Nguyen , Greg Kroah-Hartman , Ang Tien Sung , linux-kernel@vger.kernel.org Cc: Tze Yee Ng , Adrian Ng Ho Yin , Nazim Amirul , Hang Suan Wang Subject: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc Date: Mon, 6 Jul 2026 13:55:41 +0800 Message-Id: <20260706055541.74783-1-genevieve.chan@altera.com> X-Mailer: git-send-email 2.32.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI1PR02CA0042.apcprd02.prod.outlook.com (2603:1096:4:1f6::17) To LV8PR03MB7398.namprd03.prod.outlook.com (2603:10b6:408:18f::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR03MB7398:EE_|LV5PR03MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: 0648bac5-eac5-40a9-62b7-08dedb233c00 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|55112099003|18002099003|3023799007|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: QvHjG6949DnON0UJWEdD9Hfi8QvYG27uHAcaGUP2dYO+25hJNsuNmP5mSw3npr7ljQ/cU5T2ZeZMXIS5e6zknAVyH70WQhA8Xes/Cyd3iE1bPO9J5ZxpWDC7lRMXGGFcVxmiLUl6b5q2+4o5GHCcxzZYbNFAWDueQ3vWb68PY9vwfMgXH+dVL+I5gOD/Yhc/ROrf7UuDltpf/diwn3tA0C96eEKmmkHt3buN4JtFTzbQe0fmuvm4OQ/fwcpciQ4SaqXUKnOdes9F7N59bJeMQVmdP2cHd9kQDjjcejDm0MhLFU9RwprEIUSoUnRptVPI3kB9/+XEHHzUxl5G1RkBhxsP3kxpfiF9zIcqpMMqngTL1DjyaDOn3lxYUBUFxnqFjCZZVnkO3jPur5GfmEzsg85Xcx3NgIy9Xlyvi51DvvR4x92GRH6XvDR72PF1GielSyu2eDXsNoMALlM3p5W3CXxmN5sd1RjEBAjnSUNzMwjddoFrT5f3oSKZsavoPZqa2an2TD7hOyzt8dt9QvLiSif4mepcsUwY38Ep8lwHxdWn54kSdWDxOueM4lXPJeFhzf/cMFDGeI/Z3D6oMaxINEqxh0PYicPS1O1L8Cs//y7O/N4La1sAC/ZqAWITPl6P3TjCvDxhmEg8B4kFdQ7317oCCXQgUChNDHnwR7XOf4c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR03MB7398.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(55112099003)(18002099003)(3023799007)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TGXLm29u0IwfpzfdpKL5dFDeqEXY22omOI7J386OAIWPKy/GE9PfeNScr27h?= =?us-ascii?Q?DWPyhIlMZwHxYVDIAdBK7WC5iGuBF2WXtj/BuXDuR6W1jJRJQfKvUgczv4Iq?= =?us-ascii?Q?DfmD6MJhqjXxpxe6pn2+04WRGGgt8xq0Zo9OGM66PJUPUHHbR7D36zKUeymw?= =?us-ascii?Q?8jAz5CFXCTixAihWmfIR0kGL9qrUpH9YKZFhx6C1+TCVrep9tJg1o0dtq7mI?= =?us-ascii?Q?aYrGwXjbcfB8kEp3RgnWax3XXmstzvMjZfsj/AIcfy8rQoSdVfiG30xM2ZyS?= =?us-ascii?Q?Gki4DRS3bN14oHDmtQdpEvOXqeXFBFQh3UXS4qnzst3FMJoQfN6jOx9cZwic?= =?us-ascii?Q?eONrY1ZgNwa3hjFSgtJWk8Q+forUbfvFHudRPQr8uCOk8Fl51kMzRnEYP8hu?= =?us-ascii?Q?I033s5s69qLz7BzGtXsQPnknI7ZuCIoBUkziRcKO4TdaNIp0dBXtAPLY20gS?= =?us-ascii?Q?FLu+qJlrTTlmMAyZ9+R59+81AdtwSICUzdMgL6PESSyHEeQynPhvy/H9mQrG?= =?us-ascii?Q?FQeNEmUXjvgBV1qXMAxBrSqb3RYvNly8i7BIiDANe938SAa5ToThL0GLg5ef?= =?us-ascii?Q?T4Mqpc0T4/FKvsZJSBAV1/XWueTce3MtjIP+KbBE91g/Jc3PjR4bWbOJ7cJD?= =?us-ascii?Q?Jdayw4ripXiQvaQujB7ZkXPpP8h4t0dd5fqbdYUvSVnx7d16uRFuGa0kN/pK?= =?us-ascii?Q?g9ESvekpLAkeZ3SRziR6Ea15KlWS2Nn4rlNki9GIWQ2ch2WOFb83Dq/po3uW?= =?us-ascii?Q?qSMqRY7MBK9p7+3oxtPmh5V4OzPxegX7XsYGVue54U55LRZuL2YEg4v2ibvb?= =?us-ascii?Q?q6+QWyflxpeLIOnCrngtLlySnxmWSGC9CxvcXaLbkfs2SrhHrSyyEMEsPDbP?= =?us-ascii?Q?Cp3nHHzir3cZl5yQMZ7Feg3GHQNGhlNE58DbECegXiWVa1YtiRZTPdbz5R82?= =?us-ascii?Q?85HVhkJlk6SJq6jFxac3C0oChfF7/cWlwNqnIgmXwBR48fqs8CdrsMr8kJJF?= =?us-ascii?Q?XMiJsy/Ftz0jnQX11AAkjUVHnl5GslimjOG0wSa+i3XU2VEAnsejfwOHD/m4?= =?us-ascii?Q?CRARJSjVleXpDC2q6VlRpkD2DTblrbAHysMpw+sOU0SdR2kfA/9npO9kZeL/?= =?us-ascii?Q?L7rgZXT3wz2TUflybH5wHA3ilaR/GvkFNMVketcHkitIex3OkU08nLvu0nli?= =?us-ascii?Q?NWbfJxZm3Mfj+22nkmnak/sRenLyF47IrYMytdXrMORi1TCH1hKQ1dWLaxgn?= =?us-ascii?Q?ldTjBS1oFg/Zz4TRC3d6fqh0oVXXMJhy5XWV1hVuyHQA2Plxv31/QJBb+3d6?= =?us-ascii?Q?ysF9LjrPlMq4gO8Meth5ZdpqnRzOApp2dFtsyM6lVtFkg1L7QL4ylMQLeG4P?= =?us-ascii?Q?T3HmXd7byja9lYU9Fvf3CytMvaFnNqBSYrZO3a7wwPrz+CSxa+zorlFygr7U?= =?us-ascii?Q?CdXin0IqROnBHlz0nYJdD2/X7+6+Z122YdEEdK3JEzWHjS2726yQHHjOas7d?= =?us-ascii?Q?YmsVz3nnUjI+00mwY4Cf9Pl1lhoeZXm25HOiE1sEp4Z1PfxkdtmSPUJuaVI8?= =?us-ascii?Q?Qg0RFD6+w6ZR7H30QX0GNBr2aeubdg92WTUHeZIEbCeHBJjrUShlrtSXyp++?= =?us-ascii?Q?s0bn1TV46lEDbn+l+L73iZVErc4C7BIjuhqPPuJtql5u17FMcTPDpI5z4PYd?= =?us-ascii?Q?67EBhKxWKydomdG0fRGgE2Yc70pZu/oH4woS5REWLC4jwf+NvMKoAYIPkxZZ?= =?us-ascii?Q?kRw6JxKCMd8tQKH1SP0E0LOqrvjhIjM=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0648bac5-eac5-40a9-62b7-08dedb233c00 X-MS-Exchange-CrossTenant-AuthSource: LV8PR03MB7398.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2026 05:55:51.3712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3HUWkfzoajkDqh1qB40BnMm9fyWMH49Efuda+lCMi8bL3LwfY/y/06U8vTWL0yWLJLE+XchSpnpEMCiceqQwLAeVWTmUaR+KgSPG6kMocGU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV5PR03MB8388 From: Genevieve Chan Correct kernel-doc errors for two FCS SMC calls: INTEL_SIP_SMC_FCS_SEND_CERTIFICATE: - Describe as async to match STD_CALL_VAL usage - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED INTEL_SIP_SMC_FCS_GET_PROVISION_DATA: - Replace FCS-specific status macros with standard status macros (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED) - Restore return register documentation for a1 (mailbox error), a2 (physical address), and a3 (structure size) Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands") Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision data to async SMC call") Cc: stable@vger.kernel.org # 6.0+ Signed-off-by: Genevieve Chan --- Changes in v3: - Use 12-character commit hashes in Fixes tags - Remove 7.2+ stable Cc prerequisite line - Use 6.0+ for stable Cc tag - No changes in code --- include/linux/firmware/intel/stratix10-smc.h | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/include/linux/firmware/intel/stratix10-smc.h b/include/linux/firmware/intel/stratix10-smc.h index 9116512169dc..2c603a24967f 100644 --- a/include/linux/firmware/intel/stratix10-smc.h +++ b/include/linux/firmware/intel/stratix10-smc.h @@ -606,7 +606,7 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE) /** * Request INTEL_SIP_SMC_FUNCID_FCS_SEND_CERTIFICATE - * Sync call to send a signed certificate + * Async call to send a signed certificate * * Call register usage: * a0 INTEL_SIP_SMC_FCS_SEND_CERTIFICATE @@ -615,7 +615,7 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE) * a3-a7 not used * * Return status: - * a0 INTEL_SIP_SMC_STATUS_OK or INTEL_SIP_SMC_FCS_REJECTED + * a0 INTEL_SIP_SMC_STATUS_OK or INTEL_SIP_SMC_REJECTED * a1-a3 not used */ #define INTEL_SIP_SMC_FUNCID_FCS_SEND_CERTIFICATE 93 @@ -631,9 +631,11 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE) * a1-a7 not used * * Return status: - * a0 INTEL_SIP_SMC_STATUS_OK, INTEL_SIP_SMC_FCS_ERROR or - * INTEL_SIP_SMC_FCS_REJECTED - * a1-a3 not used + * a0 INTEL_SIP_SMC_STATUS_OK, INTEL_SIP_SMC_STATUS_ERROR or + * INTEL_SIP_SMC_STATUS_REJECTED + * a1 mailbox error if a0 is INTEL_SIP_SMC_STATUS_ERROR + * a2 physical address for the structure of fuse and key hashes + * a3 the size of structure * */ #define INTEL_SIP_SMC_FUNCID_FCS_GET_PROVISION_DATA 94 -- 2.43.7