From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outbound.baidu.com (mx16.baidu.com [111.202.115.101]) by smtp.subspace.kernel.org (Postfix) with SMTP id 110F037D114 for ; Mon, 6 Jul 2026 06:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=111.202.115.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783318176; cv=none; b=d00NrWyYJRqKEgcd7GXUddSZAyGoxlczXn/Irw4t7HoeuzoMfmg8MBysotxiwcY7uqH9vqIc6JJV0l3LRlqHbN2EK1u6Syx+NRwYNy4/gUA7Kl0Z3EceqChEIVgnQhRhgLdczdBzKo+B5JtmYlzufhrURwgRIsxwQ7ymaLUsdSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783318176; c=relaxed/simple; bh=mZ8RdtoHoaP2zKecqF7SODEaHQyJcEThwFDo29lFUhE=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=s4V4OAboEjbj4t1WSSIvVDzU+JfvbzXZ/3/OvsLto4qs9mY5KOMRQ+8zrlb4if5qShWV0XX0hAhAfN/+zawz6Kg0iTf6SI2Q0TXnRWm/ubDBLuQoI7Ta8lDQ7/dK5dq9uwgU07ZBHR0MY22jc4zOaXUYfWPzytYZshOYJk5UaVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com; spf=pass smtp.mailfrom=baidu.com; dkim=pass (2048-bit key) header.d=baidu.com header.i=@baidu.com header.b=CcJ6jeqO; arc=none smtp.client-ip=111.202.115.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baidu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baidu.com header.i=@baidu.com header.b="CcJ6jeqO" X-MD-Sfrom: lirongqing@baidu.com X-MD-SrcIP: 172.31.50.47 From: lirongqing To: Dragos Tatulea , "Michael S . Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Cindy Lu , Kees Cook , , CC: Li RongQing Subject: [PATCH] vdpa/mlx5: fix wrong MLX5_ADDR_OF struct type in alloc_inout() Date: Mon, 6 Jul 2026 14:09:02 +0800 Message-ID: <20260706060902.2341-1-lirongqing@baidu.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: bjkjy-exc13.internal.baidu.com (172.31.51.13) To bjkjy-exc3.internal.baidu.com (172.31.50.47) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baidu.com; s=selector1; t=1783318167; bh=dOY/T0UMhDtLTqbVSJGV9b3hkKpMYso8tQdta9n8M/I=; h=From:To:CC:Subject:Date:Message-ID:Content-Type; b=CcJ6jeqOEzZd4166lSpuyxIAKv2MDqc5EZ42DaCqg4NPIZyEQiiC++hKPYB84M5kc bb8LjMgavx1LxbvT6OKtHlpLxPY4RNTB5qeMrlUWkXfi+Pn8zF9kLM6hiA2KLpF+vd s6LHfFZWQiZCTiHT/TphJA7VdWuqSgRSVlwFfFRDLurV4hKK7t9yFUO2xhi0tnzVi7 ZhDHU4ID/6GQPThfoSGvKDdV948YcWk5rNpnX+kEwlcDZ/RM2cUsZQt1SiJv8w2mDj CGDODHY4uryCd7XalVamtSEhjlv9pmtG8A5fcYJMHbII8HOcZQsDWqqx3M36rEVyKG 6nJgMAMpp3+cQ== From: Li RongQing In alloc_inout(), the qpc field offset was computed using MLX5_ADDR_OF(rst2init_qp_in, ...) in both the INIT2RTR_QP and RTR2RTS_QP cases. This is a copy-paste error: each case should use its own input structure type to get the correct qpc offset. Fix the INIT2RTR_QP case to use MLX5_ADDR_OF(init2rtr_qp_in, ...) and the RTR2RTS_QP case to use MLX5_ADDR_OF(rtr2rts_qp_in, ...). Signed-off-by: Li RongQing --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index ad0d5fbb..eb431a1 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -1080,7 +1080,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl MLX5_SET(init2rtr_qp_in, *in, opcode, cmd); MLX5_SET(init2rtr_qp_in, *in, uid, ndev->mvdev.res.uid); MLX5_SET(init2rtr_qp_in, *in, qpn, qpn); - qpc = MLX5_ADDR_OF(rst2init_qp_in, *in, qpc); + qpc = MLX5_ADDR_OF(init2rtr_qp_in, *in, qpc); MLX5_SET(qpc, qpc, mtu, MLX5_QPC_MTU_256_BYTES); MLX5_SET(qpc, qpc, log_msg_max, 30); MLX5_SET(qpc, qpc, remote_qpn, rqpn); @@ -1098,7 +1098,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl MLX5_SET(rtr2rts_qp_in, *in, opcode, cmd); MLX5_SET(rtr2rts_qp_in, *in, uid, ndev->mvdev.res.uid); MLX5_SET(rtr2rts_qp_in, *in, qpn, qpn); - qpc = MLX5_ADDR_OF(rst2init_qp_in, *in, qpc); + qpc = MLX5_ADDR_OF(rtr2rts_qp_in, *in, qpc); pp = MLX5_ADDR_OF(qpc, qpc, primary_address_path); MLX5_SET(ads, pp, ack_timeout, 14); MLX5_SET(qpc, qpc, retry_count, 7); -- 2.9.4