From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA768416119 for ; Mon, 6 Jul 2026 13:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342837; cv=none; b=DpBNHCtJ2MgdF8km8YjyirUtxbgz16lg/f1XzTQodbkSZe8R62BYrAULcLHaH1cRcOeTyPOYJ16BIJPfPkc5rhmLU0pyWglVVHWHInBIN3KWxy+vUC6RihbAUWaDdn3ZELvABDcnxffhbb8TfTvTkbh16b2tIBzx1KFfaVXek/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342837; c=relaxed/simple; bh=SgafSM+EQPguZfkQHsc6kCGrGqgI5C0MV8ji00rsMUc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G8ACHIqP4M8pT5ajR97S6KhENLCF6nI+g7DkU1owacCVqm1qk6h87gKTN29C71A3baqPS7j53U8KXR86SqAsA7Kpsee+J9iltxAV2pjPKj1CKMfH7QekLxDJQILMA7xIezzwZMFB87BeE7rzSLh++GNl3xMfRMVwvEP4+ZuVirM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NoxJj8YE; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NoxJj8YE" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3825c406ffeso2095024a91.0 for ; Mon, 06 Jul 2026 06:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783342835; x=1783947635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hBqyNV7dq1ohKzmYnk+loevfX7z9FulC1QcACgXGXhE=; b=NoxJj8YEqqfkQ3/rWskl4qsDwvQSpGJ81NOcV/hp8JgLmIbnCot3qfdCkrlaaVj1JN GYP8Ld1q5TGQeTgan6/tj21SiK4wek5/XR1l8m3PNjshKgvxJoR2N2TC4l65x+UABkss p4JmIQbegCxp1+GlR06NCCYGOX57uvvTtFoZ3PtIgSGrn1NUV9G6WHV0FZZJtDOEHCAJ 9xnKntPypYJAm3yazv5KpMi5cSOyMM1apm5zJAULR7FdQoabpJdFH4Smlp3kR0LTIyNo 453cJMH248MXjTrZMq2y2OCPp+D7fSclfmDvYQaGspzR5q7LOmeVUTAGsVHpvdVg+lul iqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783342835; x=1783947635; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hBqyNV7dq1ohKzmYnk+loevfX7z9FulC1QcACgXGXhE=; b=GZ5gVpq3Vhcn1At5zx1eGiPfyCjj+FEQ0PYnxhuu8nSNi+IsWwmlaxWSgQWK/aCoL3 HgW8hJuRx9bnTuLGaXA6hIhAH4/v+t2qwkpwFp116ZB7onlucUkz0K9i1Nqzf6dJH5Sf 0WfKf25rkZs9lUu8S/X3FIGpQVAPJe3JgA/1YWyv9oF0KV2llMiczh531BLnM865nPU1 HzxWrIMF14TBzYmU68YiJ64px9l/SArnNMgBUEKndGqfq5PdpTr68EQoP4yelaCcWFgj 02QvzeiGv3fjr/h7zfQ98Bkjt+5xP7mlgD80HrAbMzhPjIPihrMTAHEHzkLAG/YvKuzd RIYA== X-Forwarded-Encrypted: i=1; AHgh+RpqLhpiUmlle9a1pedHVf1DJtHRSXUId6X5MDipkk5vwxN/cP3LBm0RWkuOPziRwieDVgpaU0uoq34UmeQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjju7C+iUG+v7JC/dQ3uWuMTcwh+QbGgT8sBV6XKLHSugqtlX8 XqLUA9f7ymRm6HhN+xIbSoLYMLiNSZ54i/YAD82X7BPm3C1511EoFBUR X-Gm-Gg: AfdE7cm8Q7F6BxwQS+kmTgb9xRPYAWAPp4cZzCyfunKowVITI2IlNL+eE/2ZDsh+qdh OWfrG+xrMYi0divyKAUGNLBZs7Uc8D/mZ/hvO+S4YgTHUjQszqpB1QI0wMi0Raw1qPoIuA5PHnB W+bv25lMvd8CCpqk6ChhLB+5fZE/SRUsT6tKaDSAocp3CBMNE3+x3vlYNtI9ZLtB7rHLCOL0WbP DYihhgnBfK7ajoMHCqcDd2Ygln/EhmLSaySO10EexMUpveSbNnlPYTBGlhFIRRzOgHOyxH8FC5c 6x1aYdLTHyTO3fkVsBraiTE0JsBo/xikIDpz2uKYPfvXWFm12Zcjq0LV6/pHYwsRpliGkgk8igZ 74ktvlOvIHNcdb9VmgWrVvdGN0w7jlxyYQ0jKTLfWW7T7dx4S/JrMGfD/ZjorMOqIHRFUwcmqxM /g9Y8DhI0+WYNq5CEgZSC/zrIC3Q3hKQgtBsgHi5YzcSNqr3Xbsw== X-Received: by 2002:a05:6a21:648a:b0:3bf:a9cb:b799 with SMTP id adf61e73a8af0-3c08ef902e9mr603245637.54.1783342834712; Mon, 06 Jul 2026 06:00:34 -0700 (PDT) Received: from steellegend ([2405:201:304b:4973:59cd:5c84:346b:aa8e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f3a9341e0sm52766903eec.12.2026.07.06.06.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 06:00:33 -0700 (PDT) From: Uday Khare To: Mark Brown Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Khare Subject: [PATCH] ASoC: tas2562: fix deprecated 'shut-down' GPIO always cleared after lookup Date: Mon, 6 Jul 2026 18:30:13 +0530 Message-ID: <20260706130013.71862-1-udaykhare77@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In tas2562_parse_dt(), the fallback lookup for the deprecated "shut-down" GPIO property is broken due to a missing pair of braces. The code intends to reset sdz_gpio to NULL only when the lookup returns an error that is not -EPROBE_DEFER (so the driver gracefully continues without a GPIO). However, without braces the statement: tas2562->sdz_gpio = NULL; falls outside the IS_ERR() check and is executed unconditionally for every path through the if block, including a successful GPIO lookup. This means any device using the deprecated 'shut-down' DT property will always have sdz_gpio == NULL after probe, making the GPIO completely non-functional. Fix this by adding the missing braces to scope the NULL assignment inside the IS_ERR() branch, matching the pattern already used for the primary 'shutdown' GPIO lookup above. Fixes: 7cbf5fefabc8 ("ASoC: tas2562: add support for tas2563") Signed-off-by: Uday Khare --- sound/soc/codecs/tas2562.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index 2f7cfc2be..e1d62f304 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -675,11 +675,12 @@ static int tas2562_parse_dt(struct tas2562_data *tas2562) if (tas2562->sdz_gpio == NULL) { tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-down", GPIOD_OUT_HIGH); - if (IS_ERR(tas2562->sdz_gpio)) + if (IS_ERR(tas2562->sdz_gpio)) { if (PTR_ERR(tas2562->sdz_gpio) == -EPROBE_DEFER) return -EPROBE_DEFER; - tas2562->sdz_gpio = NULL; + tas2562->sdz_gpio = NULL; + } } if (tas2562->model_id == TAS2110) -- 2.55.0