From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0292C370D5C for ; Mon, 6 Jul 2026 13:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783345245; cv=none; b=bH4q3V6c0NUoc91DeRkI6pjU7bsBFcoSD/LA9DYBcINSJrJ+nf6cfmLcs35BqwwndVJcw1YZUxJLdDbfZFbEe82U/xygToOakAR2oIOR4hGY4+XMNkXeU+tK8wSnF5Y6qg/sn2ulTJQksQpskswX1tDAbus0CAL0id3rh8vzcbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783345245; c=relaxed/simple; bh=lsDFIcHAftlanfKCuHhcmiZBwiRMAZikzgChqPjJjHI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WKchtAAsOpXWVHa5L5tXgcl+7eK0+AYxhc9koRHzr3Yj4NqF0LRx4Uu3ySgV/3suKZy1LmMJTdAvJ+z4HZoJYPuEwaT+9BvH9epqLtcG2iK0afTUVUQO9roQpmahkFhtriYNvdCJye19hFpWbhXWzNHmtDA8/SlOyuw+5AqKEOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=H6ka8P+I; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="H6ka8P+I" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-471eeac43bfso3433707f8f.3 for ; Mon, 06 Jul 2026 06:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783345242; x=1783950042; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YNtvrx6JU0RSTB5C/gMvs38ikePYtzcXdrklgWjxoQE=; b=H6ka8P+Iv8JbglyJ3MfUf1QG1iBNmZU6TBryESC3elIvf8iwSw8uPLCSnp91kFEtpy AnO274KLUH5UkpHa6Gjlq+viJv30b43y0UZ4n6lcC97vTkxc+NjwjqxxXHjcAKVW766+ qDQ/eRAW5vyoG3lbHI+6QAynTEECKXhNvYR/X2PeStRxR7FojRGp4bSatSXE3BVOcYD6 Yo7IOLoeKrrbupHK3rFVWqFNEq2O63EkK785Zl7f25bxRYIrFeNFloV+QM5xT4ZryOt/ Y4iPbCk8+mPD/8Cu3vtInLmC2t4upaMGihe/kzKl9NihpvxSD3yFDEZpxFc85GM5AuFa dihQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345242; x=1783950042; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YNtvrx6JU0RSTB5C/gMvs38ikePYtzcXdrklgWjxoQE=; b=mebXWiHIG34P4JtSdfNlZB2d5QrvFo1l+uDEZvurUgP5LxarxHrhTqbmLr5/lpV4gF 5O3bRl3ULptIYaWISOp1VcQVlqFetWWoIyHs5iTF6hJELOznlNeyFx+f/Y7ofgueBHnN 6cVzKrx5/OVDdbA09h0suQvKxFYiiITLJJf7f7Ju4uP6ZDUH7CaXOcF+YhDnc+hWOt1a 3gS1jDYMrqa4xcOGvArGRHUqKDtz68LGpetq9a1T9G286ZbCvbwl03RaHRYO6BvrmMYL GpwTvjFUC+b3f+zc7inXNIvlGO6Wrr2Uw9tWfv1ujzUrxPO7ZmD62iBIto52EAfz77np 36YQ== X-Gm-Message-State: AOJu0YxZkDUj2cclt92rR/O1DDCT6gY1MGNkSHcJT4hz3OL++aoZ0Icn W6nVPzYxQ80d8ZOLb/u7OtZ21+ppe4sgde2OVdanjzdAgQbtuQmT/3uh3xil4VQdkODYp3IQAUu cUX/TGB0= X-Gm-Gg: AfdE7cmT8xmCc6IAwJGmVQ24GedDwTSkaPzCyH+2AxPBXRk04M/wz2H59GRMBdbNoew MUeOwZ+McGh4yiABbK1vgWfY8d1QMQDkBvIhaeKH4ORt9ivNHo0OvdSrRU5nwObrs3jDKkMVa3B RnfclZ2tOhIUzvBn30DSTAGSryHUTcqn0ZrfVjK2IZ5kTYhkJRJD0qvsEPcygv9jzClOStadl9S d8OnDqCALLCPB9yp7t1vFUs199YMCHe6FOrNtgdZDQdSIksX5JytZQb4hJTUC8eltS5dKBR2Ppz 6nSb+JlBUnt2y1XcCKJED6YNjU+hWD6IqPf89pjpb19opt7vUfJq1oV0U3oClLbXkaEp5rGcsCJ q0eqXYow7KKhyNsGybNUdA7Ej+mDh7ZHzB2nfmJwMijBi8MXQWXoU+LvFT2wBySBKVcXlW5f4Oo Wz0jyoOrYKD7UE6XViyj3/RDiolBvo0XQP72cGFiWSKGuWcw== X-Received: by 2002:a5d:4101:0:b0:460:2eee:4e21 with SMTP id ffacd0b85a97d-47de66a4d3amr240493f8f.17.1783345242476; Mon, 06 Jul 2026 06:40:42 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f214d2sm24424868f8f.33.2026.07.06.06.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 06:40:42 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Haren Myneni , Rick Lindsley , Nick Child , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2 1/5] ibmvnic: Move long delayed work on system_dfl_long_wq Date: Mon, 6 Jul 2026 15:40:24 +0200 Message-ID: <20260706134033.244295-2-marco.crivellari@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260706134033.244295-1-marco.crivellari@suse.com> References: <20260706134033.244295-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the code enqueue work items using {queue|mod}_delayed_work(), using system_long_wq. This workqueue should be used when long works are expected and it is a per-cpu workqueue. The function(s) end up calling __queue_delayed_work(), which set a global timer that could fire anywhere, enqueuing the work where the timer fired. Unbound works could benefit from scheduler task placement, to optimize performance and power consumption. Long work shouldn't stick to a single CPU. Recently, a new unbound workqueue specific for long running work has been added:     c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works") Since the workqueue work doesn't rely on per-cpu variables, there is no obvious reason that justify the use of a per-cpu workqueue. So change system_long_wq with system_dfl_long_wq so that the work may benefit from scheduler task placement. Cc: Haren Myneni Cc: Rick Lindsley Cc: Nick Child Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy (CS GROUP) Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Marco Crivellari --- drivers/net/ethernet/ibm/ibmvnic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 5a510eed335e..a1c01c9820d2 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -3229,7 +3229,7 @@ static void __ibmvnic_reset(struct work_struct *work) if (adapter->state == VNIC_PROBING && !wait_for_completion_timeout(&adapter->probe_done, timeout)) { dev_err(dev, "Reset thread timed out on probe"); - queue_delayed_work(system_long_wq, + queue_delayed_work(system_dfl_long_wq, &adapter->ibmvnic_delayed_reset, IBMVNIC_RESET_DELAY); return; @@ -3267,7 +3267,7 @@ static void __ibmvnic_reset(struct work_struct *work) spin_lock(&adapter->rwi_lock); if (!list_empty(&adapter->rwi_list)) { if (test_and_set_bit_lock(0, &adapter->resetting)) { - queue_delayed_work(system_long_wq, + queue_delayed_work(system_dfl_long_wq, &adapter->ibmvnic_delayed_reset, IBMVNIC_RESET_DELAY); } else { -- 2.54.0