From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6779D3A83A9 for ; Tue, 7 Jul 2026 06:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783406152; cv=none; b=s2OIwaq/m4OEJd+3ThiIHmBXejANv5IteTFwtnQ8+q6jA8gpzb+UN3b2XZ6/SEeOz2uRW8Njv7YqOWWs1KyHSkG7s2AK6R7JOs048sQka4FamuKfdL8mAV50lciXGgI0Of17RWX/+lnWAX+PtAvCYY/xYZCB4ZlA46BGgXNc9xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783406152; c=relaxed/simple; bh=r0NQcgVWIF3QYqJ4mnNHJAILzS2N4Wgq7EHm3cD0oHY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=flrpxml1iwG0gBt372mjbGI9CH6emYdxCaN8QiQP8dZjKRuWisezDVwu2K7LkqVZizJrGp8QjwOa7d5uhdl7gGS5JDYtGK1f+95W7ngs9XcQfsUcDbgp92hNH1m/hahigt4a3ITfOSUUp0HEGeKTaKlJVQ23sjsFG6BTniNvKZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mRdrq3NM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CEKYxWSO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mRdrq3NM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CEKYxWSO" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66748phM2669313 for ; Tue, 7 Jul 2026 06:35:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k1hNNt27jWnOZ+OiFVXad0UrkLnA0nIc+AMtFumubcc=; b=mRdrq3NMFT+VnlSb w6rT/DTseWlOJmPZUsJA07GNfNipWMsr0SdudKl0XZMa2ObJ1aHHB2C8p/JkOnY9 7gheAQ2morNwNeQOrvfPzn89BMA5gZ9SxtDO/q+9nfOQ9oomdrkv3FAvmRpy3b3u 69PUf20cmZD2+0KqJe52sruINhsBGJPxyy+HSstX3Pjkz9DmInogsaiyV8ARoJ9T vpgOlCPeEi8raijSMC4f/UXQKYyL8bRaIYfytdNNr2/+Tkz11Lnj4TSWAXd5/GmB 2Vq3Bo5X6WtHFyJk9oNypiYzlFpBcKj4C700iCKSfAiDC3DieqOlVzVpKUZKXbeo fidEsw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgvmd3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 06:35:49 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8478e9c4bd2so4246380b3a.1 for ; Mon, 06 Jul 2026 23:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783406149; x=1784010949; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k1hNNt27jWnOZ+OiFVXad0UrkLnA0nIc+AMtFumubcc=; b=CEKYxWSOia0z7qCfEKuu7ODORi594B47VwJ/oWFjRratXan9IErVj5FNGMthj+UxwJ 0F/EQEZtPC07K/x2nInLtMVCtKglf/8CqjfFNaC22VBpmhNqe0DYOAKvuDewYghYnBbT dHWUb3ZURdtv/UaxHVVV5izLmABl/MsMmwq5V8Fvr+ZRe5L8Yo6ZrQnsuS1mSj88cPJZ y1HFTRdc7pK5OmY7LIDxVAaPTYDG8KsLjwztwm84I3tEU9Bvwh/p4tXiflkBD/usFhl7 wbrUtUegiMdxSfKq0evn2rMFXFT0xC9VNq+s4wTlFPa6UsTx1OkWVstFO+oGNXlNovMO Iv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783406149; x=1784010949; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=k1hNNt27jWnOZ+OiFVXad0UrkLnA0nIc+AMtFumubcc=; b=eALMPD80e6FtJIt8ppPiz5eqPNdVGkKiXKIyTl1hwKA4MHyMQWt+D9qsoc7KYCWpko Aqt1kOWWEjcCvBSvzudF0iy0slyqPxnBfZDEQaEOilY9KXn2ROGYMQid7wWqsTnyqHyh 8R0Luk7VG8uwcU9QS7go5vZpz1z/hJz4hsS3cldlTkM0zMPH/1aY+T29ahveT0Fb2pld qKaWc81B4YnZY/XbutAKGaLr8DwQee8miLLBSuiIZe95C+4w5AMvJQ1Sk0M9CayI+lVx 7cDqPJE7nJ+wO28jZg7Hk8fyKB5th97I0mmZ62nXGbLfSLmy3RI7ALKQeFfd/xQ4q+0q C55A== X-Forwarded-Encrypted: i=1; AHgh+Rrc8g0ROO0uGIOqLt/mWDIdCC17RaHqiRH+k9D5M73TfiZ9Odf1peRHSHKEpoRCVN6zsjGGyZ4e/wko6lg=@vger.kernel.org X-Gm-Message-State: AOJu0YwBx225W2OUzVO8GyBhuWhXHvnPdAdsUrg8hCSplZ0HUqCflZOD vxBUbylq37l4vby8aeQU+gURGk1wV7edzOD6cjrRpvak5QggYj2FWX3OEScg5kyi5nQv68OY2ib Sg+mRd15LhLo1plZK57+BlYeESYMyrQgeG0H3LgE+WKpOtdwtK9h7X4XISav5BrcTT9g= X-Gm-Gg: AfdE7clox0bGGjIfP4lomVnwDQqlae2+OoWlB212n7WTgUljp1A4CahQNNSTscmNJ2U 1eRRKe5REzNqN4qaxd95cZKHP3ttiMAm1HeLo2WUjJcBUvR7vJn2L2+fVt5nZIlRPb8GZQtEiUx S/fM8c0gHoMY9KstIepcM12kwrhRz1QYxIPKHeRlTPMzj8kikYONVs0GQAlb7nX51tuXJS8ZWf/ ezcjebnkGcEymUOXmAgmsMY5GQjo1bSJUW60Dtao+6foxrSGRThprEA8EnD1rZHFnK3lD1gZEI7 ID2rw1DqwyVXvffzRy1UEs5Fp9C3Sr2IYeoWjtMB4J1kYZxbmNBg4LBLois3dPhliS9w3SMtg0o lR0ZFSJ3VoiDJmJcz6vaBQBcLk19zBOfGYa2bLZPU7aZC X-Received: by 2002:a05:6a00:1796:b0:847:9c3a:b77f with SMTP id d2e1a72fcca58-84826e28b2dmr3860453b3a.35.1783406148999; Mon, 06 Jul 2026 23:35:48 -0700 (PDT) X-Received: by 2002:a05:6a00:1796:b0:847:9c3a:b77f with SMTP id d2e1a72fcca58-84826e28b2dmr3860427b3a.35.1783406148494; Mon, 06 Jul 2026 23:35:48 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6db29d1sm4889973b3a.53.2026.07.06.23.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 23:35:47 -0700 (PDT) From: Vishnu Reddy Date: Tue, 07 Jul 2026 12:05:23 +0530 Subject: [PATCH 1/2] media: iris: avoid bit depth validation for capture formats Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260707-qc10c_fix_and_disable_time_delta_based_rc-v1-1-33fa130bc535@oss.qualcomm.com> References: <20260707-qc10c_fix_and_disable_time_delta_based_rc-v1-0-33fa130bc535@oss.qualcomm.com> In-Reply-To: <20260707-qc10c_fix_and_disable_time_delta_based_rc-v1-0-33fa130bc535@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Dmitry Baryshkov , Neil Armstrong Cc: Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783406138; l=2154; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=r0NQcgVWIF3QYqJ4mnNHJAILzS2N4Wgq7EHm3cD0oHY=; b=YS5HcCYaIYKbnA2YywI0czjqnCJmNdxLlZ+W2pdvia8EPCS4vQVHLoCFE2MM9nQiN0XmHTWIh 7q+B+yp7A2bCuLcXTBI6mN3HIW7Hr0KX3iaqo9/OFldGVZYJN8uvzbO X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: WO9Z2qgLOvSXdrEmPItQEsXXd3aTiOi6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDA2MSBTYWx0ZWRfX84ALHaRmT1i6 pgB/M8aV0a19z0iyMdxpVh70XoWzqHTcTYS/BPzQFrbtKP+nTVx2fYWl6PVx9E94PwBygYopqO0 KsAQ9TcOu91JSRhwNjIAnoVYKBXuWGdkaUwaWTBEGqtxhX+h111ryvKMILkWkg+rLPJgOWiREyn bBOx7qyz875dw6YGh3W+3yCm9+YSioD9dyw/q0tLQ7kagQg6YjIrD5u9Noiw9bSlsBpqvtGLmU/ Ya9bzlA9ywTId0f4sIEFsRHH9azqpoh6J3zBU6aCABqxh4V8jpp4TFifvABE3E4Nsw4QF6aXR1S Qa3DQcQGdR8ccunl4fczdGLBnrvQ13KU6vhkeeuXmIBNNVpA/vO8QioiUQhQnIDlUPoL+zE3LC1 W1Ip6YOeCYuLM027AjjCw/Z5Mqwuua6mW0IrRUOd5LknmLrvDNFtXdqkpuGB3ZHReRsTf9INfU/ Plh9PZ/7/UI8+iWGLdA== X-Proofpoint-ORIG-GUID: WO9Z2qgLOvSXdrEmPItQEsXXd3aTiOi6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDA2MSBTYWx0ZWRfX/ioIQVK3qsBc qi3XDQQKN9DRVWMxN9+gduF4TKpsDGUg95HX8VQ2RqA9D2ZZIoaqEVup9rztmIM3zE0NcKZUdNO l0NxWqM5Syr9kn60WnuKPr81P44alAQ= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4c9e45 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vL0Q6q4W2X9FnyRf_zQA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070061 When validating a capture format, check_format() compares the requested pixel format against inst->fw_caps[BIT_DEPTH]. However, the bit depth capability is not available at this stage and it contains the default value of BIT_DEPTH_8. The actual bit depth is updated later after the firmware reports stream capabilities through read_input_subcr_params(). Because of this, a valid QC10C format request is rejected during the initial format negotiation. The driver then falls back to the default capture format (NV12) and stores it as capture format. Later, when the firmware reports that the stream is 10-bit, the driver sees NV12 as the selected capture format and switches to the default 10-bit format (P010). As a result, the original QC10C format requested by userspace is lost and QC10C decoding cannot work correctly. The bit depth information is not reliable during the initial format setup, so it should not be used to validate capture formats. Remove the bit-depth checks from check_format() and only verify that the requested pixel format is supported. This allows the format requested by userspace is handled correctly. Fixes: 20c3ef4c7cae ("media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats") Cc: stable@vger.kernel.org Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_vdec.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c index 9e228b70420e..7f89e745a4b1 100644 --- a/drivers/media/platform/qcom/iris/iris_vdec.c +++ b/drivers/media/platform/qcom/iris/iris_vdec.c @@ -95,16 +95,6 @@ static bool check_format(struct iris_inst *inst, u32 pixfmt, u32 type) if (i == size) return false; - if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { - if (iris_fmt_is_8bit(pixfmt) && - inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10) - return false; - - if (iris_fmt_is_10bit(pixfmt) && - inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10) - return false; - } - return true; } -- 2.34.1