From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDA242F719 for ; Tue, 7 Jul 2026 15:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783438429; cv=none; b=VR0dYxEhZjTAPb5BVqFS02QTBtSqFzrKtjjFaqorlEUPP+sXJiXMiNu2VegFd1IDAo2gG/bfTiHeqPFQknkkya22cGjfRR3gXOhsTpwTSdf6UlEOdns17PFmPR6kM6NHOpYfI5jl1C/I1X7N/ZIWz2Z4f0ckTilVLEtzshqYiTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783438429; c=relaxed/simple; bh=VVzIma0I7zNmP6eQ/nWT5dZPi9IA+HOi/YWBr2ZGItA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SFjxMvCJp+MAOrHtqEvYW2OFvTj4FxvMidr+KmOw7KudTU7nVJ/wazBniO0L99IRSC8BPlJjuurw2HKH1mu5jhSOP9FNq3kb0q6i5b2XgRqigKrGcZGcG0YvcQUw9+j4s6a8JW4kZPDD34FgRhxWlts9RQ5QVvR7MqHyX1hzr1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eK5viA6Z; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eK5viA6Z" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-493b7612475so41416815e9.3 for ; Tue, 07 Jul 2026 08:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783438425; x=1784043225; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DlDWtQ71cy4M6Iwx6C9VpFd4pqPTgh6eJknwRkh5wwk=; b=eK5viA6Z1ZWlDkD5rtEutdOzhfsiNhw+/icjNuMgxFUBLVdvkAb6yO4mt2im3tQzF6 LKM1U7EtVWF9pG0C2ANtotYIpqkOXN8a1rlBBtDdexIi4KgrHM0J6dtqmGN0jHlFCENK xCgqzDh/kOjXArvyA5JA+dJsXLhPf8/Hdc8bXX7jRlA+7M8MWQvnhVkVF4uWWjxFyV/w 57NoliCUIg/YGa8wL1Q0OkLCvouUEsrpF5cNiZWIf5Vjf+En3AHSBrJ7Y3U63DBkPJr1 90JPRO92SxHDn/u8Dums1HXUTALwklZjhSvrW0zwUQLTG2QELkDqy+dPR9Zp8j6PJEvq Y8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783438425; x=1784043225; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DlDWtQ71cy4M6Iwx6C9VpFd4pqPTgh6eJknwRkh5wwk=; b=egSqjU2K1gdOqv7IPGemsLdOjkk8RCRTVgnldKNxXcoXc1PLg3l8ieQvQy42gQUxQ3 l5arJ+K3LEGtwmFGG5eb2XdIY4Fk5CR5uuMWWMdoKaCKR2zY00FgejFq4WzIxbmQGuY7 Atjxjj3NOnNZPUrpBxcmT3T3TFF5CdFdtof8ah/uvCxp2+9XI4kEtW2wy8l9p5jp8ps6 8f7hkCpZ4ua7Xm9MkK40ztgCWf/gRS+T8BGfoyeCrV7XcChn3VwXkqYFM17tbYAoTsRe 4mvqUMb9Lxva/AaYLpwZNeej+3tjSgb2HXKwRvlHxBTUdf4GSbFN7UR1fNEYY8FZZPX7 Eyag== X-Forwarded-Encrypted: i=1; AHgh+RrstdgJw72rS2lDDEPY//S65q6PpUYcZxMDoFzFkgwsUy87tOEe34XS5hQV3bCyPNBSw0vgN5Bd5CdiY7U=@vger.kernel.org X-Gm-Message-State: AOJu0YwFMc9PKZwcN5KVsOmnoncKYlD1GMDPFxMTLKMrVLB+f46zfUs8 sQwNXzY/qKlyBc/Hv65jfleelMXB+q6qDbQvvTLZ3/RO3kBpRcDE8SRz X-Gm-Gg: AfdE7cmP+Ev3xd7hM3aJCOySiMlgvzo2V9Ptd3Cx3aJXl96+4tyfoYvAWkOpyuI1t1K HJem/SkBC6RBl1sUQWoVSgMCwT/tvwCGhS1YHnUvYvYzkxzu4pdcqnToe9ZjJZzRuk/vqBNpOTI axGA+ftfSTpUGpdzMPqxzpRYrlWs2MvqV3FyZ/KZY/eSxz+ldB7DD/NTidUeWSxhoQ8R71XNxMR ekasBQYKTbx6C3CTAuwFAb+qd/xeqLcs01psjxn5gEXrNEmsI2EzfINyhuxNkWTTgwJhMq69rWR bId4i0qPCy6HfHOniaix15UzyYvs0lZA8+bUDcn480AUOCYIZDhqwcs39GBuYur+oWHG5lTbtws wZvbqx0ZxJqk+mPP9F39DPeRj3xXyA0+Gv2Nq1JSzyA4Ozoph0RcgN9di4izE9MyFkg3K72lMdq eThjRI11BqAb60GrXWf8jP X-Received: by 2002:a05:600c:6085:b0:493:bc97:916b with SMTP id 5b1f17b1804b1-493df0929f3mr4664575e9.26.1783438424204; Tue, 07 Jul 2026 08:33:44 -0700 (PDT) Received: from [127.0.0.2] ([194.35.121.133]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0f5b811sm100622385e9.13.2026.07.07.08.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 08:33:43 -0700 (PDT) From: Diogo Silva Date: Tue, 07 Jul 2026 17:33:27 +0200 Subject: [PATCH 2/2] drm/xlnx/zynqmp_dpsub: check return value on drm_encoder_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260707-xlnx-simple-v1-2-df50c6665b02@gmail.com> References: <20260707-xlnx-simple-v1-0-df50c6665b02@gmail.com> In-Reply-To: <20260707-xlnx-simple-v1-0-df50c6665b02@gmail.com> To: Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michal Simek Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Diogo Silva X-Mailer: b4 0.14.3 A call to drm_encoder_init() can fail. If the error code is not checked this may lead to drm_encoder_cleanup() being called on an uninitialized drm_encoder. This patch addresses this by adding the proper return value check to the drm_encoder_init() function call. Signed-off-by: Diogo Silva --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index 698ac692abce..1d194c2824e3 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -439,8 +439,13 @@ static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) /* Create the encoder and attach the bridge. */ encoder->possible_crtcs |= drm_crtc_mask(&dpsub->drm->crtc); - drm_encoder_init(&dpsub->drm->dev, encoder, &zynqmp_dpsub_encoder_funcs, - DRM_MODE_ENCODER_NONE, NULL); + ret = drm_encoder_init(&dpsub->drm->dev, encoder, + &zynqmp_dpsub_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + dev_err(dpsub->dev, "failed to initialize encoder\n"); + return ret; + } ret = drm_bridge_attach(encoder, dpsub->bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); -- 2.51.2