From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C154D379EF0 for ; Tue, 7 Jul 2026 03:06:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783393612; cv=none; b=nqDJF9yEI+BUuMswFGEVuU8aTrr4VcXsOisoUL78fuNCHhb2/B4af67+z/iDKRLOwE0Sp/HEpTkldovbOFkho3lFceIIVDcCJwZaDMn8ZB7nmTmMabc+LjW7+luUPzej2RKP+yYs11aJ0GPGSgyoA/S0uMzouLSVp/g9DKwIu94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783393612; c=relaxed/simple; bh=aoKO72l1A+dW3fqW3BzjjnB1+WCcmKxl8/Z+ZRyiK5c=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=ecIHW8cET4eNvRSqfQJBORKbpcLQL9iJ9phAbqhWZapQolyGlWt9Bk9mLwpckORg+qjIsu4yvN2EJMqWjQe9fSZCaK1ux+dyKAl7kB0/cTA2makAMGa/XyKaCPP9ARcpRuhfMctGvyZ7lBMwfYcoK5EwXn5+dfEeHJ2put9URx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=POTfBv00; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="POTfBv00" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-8ee6912d86dso25162016d6.1 for ; Mon, 06 Jul 2026 20:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783393610; x=1783998410; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DF9/m6/00tuGO47IW671QE4G3CPTVyzUsVi+M5LKDUM=; b=POTfBv00rYXd4NZKlhPjHBgF1meZxG2KGs09SD/M1y8aEN+6TrHCa0OVrLQq0OgKwK S8HBZ90BEBBJMrw7vOUB7e4tKlVVan1EVCsjI7lr+wH6rzSwmNnTsSnxivIsch3atqfh V967MDMC2aXigY9Wjp/cPKiuDT3lr4MaHacFSjn/ujagoDq5IuTHVpK5TCY+TcxPfhu5 CdOX92l1PVklPXeTsrJ6C0e+u8utGJH2DxtJ9oKLSXfYN8tAXxgZhTozXpe+3qD3PDSo ZeQN4UX8os8nAnJUXDBdCzyGXsLwn9CmgPpIl68+v7dLzIx2xQNJFEI0IpUEBcWRlg5U 71lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783393610; x=1783998410; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DF9/m6/00tuGO47IW671QE4G3CPTVyzUsVi+M5LKDUM=; b=dYP9mhr2IP5q04pLi7bgAjNjhK9ToYNkbjwAe/+4ZhhAYIRH0Kr/ycd2B0NDc0Fvpw qgddI/Pw4y+hOjxJl1R23qYrE5Lx+9A9uC6a5K4zhzSC9eQpTf3MoLO2/Pb9k2yntATd n4MiwbrOUT89HmAY9m7rOQbUauq+Ribh8WJJLh3mE0EEFF2J+38yf8T2sieKHjD5kawK 2Vb/Oh4jlQq6yfGkLhkpTPBVrTihn735YbYDSz1+z8dE8oDWUl/P7/KFGwtAzxBb2ATe +wqPpbb4bgn0vNg4BAQiXrM5LAI230QBSxCxedwxw5iDQ7RNy8raD/ySpFg6A3dv3TZp 6ocg== X-Forwarded-Encrypted: i=1; AHgh+RqNyhu6aYaWjMwPyLbOzBHaWYkcdyjXLytSwyLqZVevCx1ctuMWsPYDvVHIH9C01ogcXlpjYHsA5FW1ey4=@vger.kernel.org X-Gm-Message-State: AOJu0YzauN9lYwYzH7S5Kr8KxGV/4xjcL2mlj5WYFznoBz65lTwZSVJ8 OcnEhO8MJizfsd3dAP19Q66wwwraVutTqDGAbwCD6k4uG7aar07Uy6RgdK1EECwaCkVkfA== X-Gm-Gg: AfdE7clXK8HkNIYnXhHm4qu3zZsl4xB6Yd/x3e6FxzkeO8/9qMqBb/xg6TIoIuGqNvi DhlMJV/aL4uABLKCsfmQcmzsneDb0F4nOV50Ie4LICLbbC3m+pikksXCAQ0F2Gnlw9jG3fHT6ja 171G0V5av2H2So9f3TplYT1V8i0AElFUFCRSGMowHY1uX5JfE6BRk/JZd3VQyGvLiNfhazmVX2A YH5vyY99zNwhGkIMI7xAO80/tYVqtgZK5OouQKxO1xPX7ieCcyotQFU1xPlkofJOpdv8No8CLec R2HBJVkh/dVZaHKWk5XOSNoxTmaHR/Qvi1awWdLw7HSjNuH5LnRmwW95qN+EQ175iyRzqkSiwKa obE7tB5iKAnYUyjUStGjHUvNtBdyxs0SH+X07GlSuy4zT0boDH+v3ND5duWlmJunw1mIpgnKiMp QuxaiEgBFmBhJgX+CQfDyFc1Kucwk= X-Received: by 2002:a05:6214:419b:b0:8ee:ed05:61d5 with SMTP id 6a1803df08f44-8fcb4a06276mr41670976d6.36.1783393609669; Mon, 06 Jul 2026 20:06:49 -0700 (PDT) Received: from localhost.localdomain ([104.28.205.50]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f4724b9ff8sm148107466d6.40.2026.07.06.20.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 20:06:49 -0700 (PDT) From: YeeLi To: jgg@ziepe.ca, kevin.tian@intel.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, yeeli Subject: [PATCH] iommufd/selftest: Fix dmabuf leak in iommufd_test_dmabuf_get() Date: Tue, 7 Jul 2026 11:06:35 +0800 Message-Id: <20260707030635.221577-1-seven.yi.lee@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: yeeli iommufd/selftest: Fix dmabuf leak in iommufd_test_dmabuf_get() When dma_buf_export() succeeds but dma_buf_fd() fails (e.g. -EMFILE from fd exhaustion), the dmabuf is leaked with no dma_buf_put() called. Reproducer: exhaust fd table near RLIMIT_NOFILE, then repeatedly call IOMMU_TEST_OP_DMABUF_GET — htop shows unbounded memory growth. Fix by calling dma_buf_put(dmabuf) on error and returning directly. Signed-off-by: yeeli --- drivers/iommu/iommufd/selftest.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/iommufd/selftest.c b/drivers/iommu/iommufd/selftest.c index af07c642a526..7340d9f3c62b 100644 --- a/drivers/iommu/iommufd/selftest.c +++ b/drivers/iommu/iommufd/selftest.c @@ -2023,7 +2023,12 @@ static int iommufd_test_dmabuf_get(struct iommufd_ucmd *ucmd, goto err_free; } - return dma_buf_fd(dmabuf, open_flags); + rc = dma_buf_fd(dmabuf, open_flags); + if (rc < 0) { + dma_buf_put(dmabuf); + return rc; + } + return rc; err_free: kfree(priv->memory); -- 2.34.1