From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f0.google.com (mail-pj2-f0.google.com [74.125.227.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9063EB0EE for ; Tue, 7 Jul 2026 11:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783423539; cv=none; b=fcgO5HmTyilBErDqqaQHk3lzFNeG3TDyBGnTlPJwm1U4SSKEZQUDNa3r2KalpdTzEhbuHWEpstxZyPRAC8qHYmgYv2m1Xh4nGVr/nYQgfin3IzSDqqsUYMVm7v7Vmlfp6s0UWUXs5ZO3qSdEweq86VmSfwQFSQ4MhZ4sRkYkQJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783423539; c=relaxed/simple; bh=iMxtahLHQoMiubV/pcHoTNYwowF8bdCxQr/U4FlYtrw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eH4ZBo6I3kYC0nZYpV6I6NCGCfHGY/7tPrYKZMEXQnOmq34BLtPrG9Gi2cSI5EG6d0FbvHXB1QEpS6vJ/W3TGOGKtVKbhoTXqxxTbeXSMRkuOn7ypaEKi7CFzkIdrJOp1eq1JQ8xLYXkpdX41YWpsfoajO+JvYQYzPF9rmaoziI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EtYnGnvv; arc=none smtp.client-ip=74.125.227.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EtYnGnvv" Received: by mail-pj2-f0.google.com with SMTP id d9443c01a7336-2cc2c6e0688so14140665ad.0 for ; Tue, 07 Jul 2026 04:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783423536; x=1784028336; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+M3jZ+huP1pty8YCVL4kj3Pow6NKpQ1GPn0YVqT9low=; b=EtYnGnvvqle/mSjHdXNtudkO8zsMjem78BxNyZAmmLJewwJbLcPC4GPj63VDUP5UDu DSf9K3b7UIEY/XMIhQJ6YzE+pDv/N/PulMq6D2Y8SElPPX0tzM1ZmyvcgvSj6R6TNp/R KO2FNCigtK44kOxvteqxXbeWkKPL+dixIwqyiEttu94sJ8OygwI58MC76Nbjmqlh9H3Y EpvObPJoMpgi9uVHcsNsDdj+D8ugK7dyc+Wd6OZD9yjisMKHs1AUK3VmJ+lAvuN9sfoB IjHyRuNp5Hp940sLun9mwjcOzcXnYY3GWOl1xlC03RYQGetOivqbaImmewwXWWlugjbi aR6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783423536; x=1784028336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+M3jZ+huP1pty8YCVL4kj3Pow6NKpQ1GPn0YVqT9low=; b=Am0bxAjRzWo0KpCzWQToyMbLfJZ22qm1jI38ykb0/hSKzND3Yomu7mn4KgC+PdokJW JibYISZdPj3X62gQTcVc4LyQ2ukkcAnAiWU13pX13b0fghkAku1inHTMB1bRbrbbNjKT XVUYL9g7AfOb06VPc1IMZCU8flvN4334wkYnCkrNc3U23Un+jcy+3cf0olwZ1fJOTEoG AmMbcTnf3YMDJVR4/X1o2n6/qolka7MCbkOYvHlm/Chw/Poto4a9PRBbFIxXoFfP3nqW oR4oOMNGi8aWuv832zJgIcUCWCwNWxuJ24+6k+fT/iqMJO5KPLxh1dvsBj8cLvLsJqZf pnTA== X-Forwarded-Encrypted: i=1; AHgh+RrCMW3bcn+mwjJEnAlHEdXbmjaQ0B3yF2dv4RdHL+n/tk/Tcz7RFGTop0USLS/7d+s7RstYdo0HwlNTLM8=@vger.kernel.org X-Gm-Message-State: AOJu0YzlTWoRMtqAoP6SSw9sHwPKADsWQ25FdfLylMuPw23Rlp7EEP97 h0sJs+keYOhBf/N2CcI+uXx52u92AoX+oodb8fbYceHDOgtzSGPwV9yV X-Gm-Gg: AfdE7clB8v2DyOgzZc0XfEknD2L+IoBHRww6N5KbnMZIVA+9vGrJ6E/w3NXKqODYkt/ YH7Bmm7RNlwZeXy81tEkUOVsufYRyHTzGQeJAkShsraIViInHQsu9/853Qm8W/K2iZupHw8xy1u NU2MzYE76fzu0Z0X+HH+4xKOXft0Fdl9yOWVlYYGuVCJTtpuF6u3O0L+8GvaYCKiunD+TtKknpR AzV5ACCosPDXHRdoO91gRjVXWR4yGBy9oJ1L1cYzeLtGGpF6Rwhm/E9YaswPHhe65Us8CCod/aU 8DuE+Mnoz3OMImyGSjxgqW1OxnAbeqs1kGX0Nagl4gLF8yavAORdLNfnVE7Nt6qe1zyehnO0MvP iKXy+myE/6xAZU8kLjvBCuP12YnOlPmTrqR7unRgsQTvQQ7PzPiVllQLd2FZHRngsV7ocawfI+l pt9wf6lVcskAgVBzNrWctRA2DewkyYKUeW76rtd06rLhO0 X-Received: by 2002:a05:6a21:e85:b0:39b:ba95:b14c with SMTP id adf61e73a8af0-3c08ede20damr6218021637.24.1783423535842; Tue, 07 Jul 2026 04:25:35 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b65960d88sm6548721c88.6.2026.07.07.04.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 04:25:35 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, marcosandrade95963@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v4 3/4] staging: rtl8723bs: convert update_attrib_sec_info to return errno Date: Tue, 7 Jul 2026 11:25:02 +0000 Message-ID: <20260707112503.612-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260707112503.612-1-dennylin0707@gmail.com> References: <20260707112503.612-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert update_attrib_sec_info() to return 0 on success and a negative errno on failure. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 69b6d3a2554a..066f6e974e4e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -505,7 +505,7 @@ static void update_attrib_phy_info(struct adapter *padapter, struct pkt_attrib * pattrib->retry_ctrl = false; } -static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *pattrib, struct sta_info *psta) +static int update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *pattrib, struct sta_info *psta) { struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct security_priv *psecuritypriv = &padapter->securitypriv; @@ -519,7 +519,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->encrypt = 0; if ((pattrib->ether_type != 0x888e) && !check_fwstate(pmlmepriv, WIFI_MP_STATE)) - return _FAIL; + return -EINVAL; } else { GET_ENCRY_ALGO(psecuritypriv, psta, pattrib->encrypt, bmcast); @@ -558,7 +558,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->icv_len = 4; if (psecuritypriv->busetkipkey == _FAIL) - return _FAIL; + return -EINVAL; if (bmcast) TKIP_IV(pattrib->iv, psta->dot11txpn, pattrib->key_idx); @@ -596,7 +596,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p else pattrib->bswenc = false; - return _SUCCESS; + return 0; } u8 qos_acm(u8 acm_mask, u8 priority) @@ -755,7 +755,8 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p return _FAIL; spin_lock_bh(&psta->lock); - if (update_attrib_sec_info(padapter, pattrib, psta) == _FAIL) { + ret = update_attrib_sec_info(padapter, pattrib, psta); + if (ret) { spin_unlock_bh(&psta->lock); return _FAIL; } -- 2.43.0