From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f4.google.com (mail-pj2-f4.google.com [74.125.227.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B08203F824A for ; Tue, 7 Jul 2026 11:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.132 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783423541; cv=none; b=QfNL6lzxyOpkjkLX0wP2Qov/nln9En0YNzsLDOcsp/1nQ2U3UPPmaIZgxvoOhK9HhNdfGF6gVUI+F+e9As94NHIDu0d1l8GDEPGfBDcWd/kW2ex4pDJVGCHSXa3c5foyt2YmZ16GqtcRmMfpClVDtInU0KgkhDHb4z4E9KtTVKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783423541; c=relaxed/simple; bh=nB4yWnb/jg/+t+pIYYHahQVVd4WbT3ePmsmhKUWoTGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GDOTn9maz3ZfgqrBxf42GWiDFMRPPY39Uw7V6phVZkt1Bpm72VMD/d+JDxoy4cm2mczlZbL4sRSSSceFOBsonjhIC8zrlJujwzoMyCrQcx0Svbk9uWl96odq+2x3KWcsDzzwpDvEllyiyJxAFqZNSnVbNOolH7iV7Vd9IKlH5zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kpY6eKuI; arc=none smtp.client-ip=74.125.227.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kpY6eKuI" Received: by mail-pj2-f4.google.com with SMTP id d9443c01a7336-2cc6207127aso5456005ad.1 for ; Tue, 07 Jul 2026 04:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783423537; x=1784028337; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IuAbGJhQVWmvJtc8YY8+MDLZa1n14D/X5ifksvSrOTg=; b=kpY6eKuIInh96QYknc4099UJeL6djFjgQ2Bp1BSkduh1DwVMcdix0p6SvZmkExdPwA 9UrgrX/gXlAjU1YMmwDDEWmh1EVeGU24vhpGmoHM73zsSkkYUAz48zzpxA/LA78PbV1G RW239VKF+T5H1POWUSbeSMmNv1CVipKhGS4qI4XHKaLhisSBCauyWEOsRlZgboyDqfkP 15WjteUpXwS5/a/NvR5pcuO7fQlgGo+1cri96dVph+bk0O96D3GoCewNMbC+/WIOlpNQ vQvl7W7mSePw1y6OnT9zkPkFTVw1oII2jL9xX4GBp/cIwewANONBEVPV+rF1Bl0bLDI3 eiHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783423537; x=1784028337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IuAbGJhQVWmvJtc8YY8+MDLZa1n14D/X5ifksvSrOTg=; b=H+J5OrtTragYip5c9b5hG5doNUQ1J7Ewn0wGkWRSS2lDXu7mHYvwkOCUGp+uUPR3Zx 9F6k7cEOScegBrHPCT5up2wt7sYPDqNbNgue7D0C1Jhm3KfE5X7vv1KUI5ZoJgZfnRBr aP4Gz0vrw4TARvgHK899bbl6eoZIMcKU1ZmPYaX9H5zDH2t9yVk2fcRht6uxYh7Sgewz AOKefxVbeBUYyRvKkG3KRe6TWKwKh7R0l3qT/2Spni2/cWdQBiIecVLachnrquG2csTM LosABBQxxcsImZAlGHA7acFlQ+BR2DqwznAB8lzTS4cNI3dHV1Svat0Y/6SG+5ZkDLAL ROkQ== X-Forwarded-Encrypted: i=1; AHgh+RpY58Dr/qgpXCtsg/LGTGVoYThexImPHJCxqoN6DyCs9/KFM5RVX3QQDtiDG03OQfIT8Clb1gFcyDUKpeM=@vger.kernel.org X-Gm-Message-State: AOJu0YyI+WTd4e72VzCx/tHr4tpcDRQ0Krzpcu8w4w7GXYgbkNcnzE69 rRhU43/VKmDtVCfheZQbJhAqEEySnF7PXeEMQXcz0w35Nng78DUTflY4js/RuxCY X-Gm-Gg: AfdE7clDoIMHgSS7o34T74V99IIg8Zfjynw4/Lvxx1KRBIZN3MpvhKqNrIqyUtAGmVN UP54DcFuxvQWAy/J8rTuTlcxmnhdJSKxFHVhzlLdu5XNXcdU/nQCTW3vi8KacW7PaBScSAFYOCK FK0ez8VpgE53AVLGYzgy3/1ag/LFxQlSgmmgdkWIcV+ozL5USrXTeGeXY6zpGqFFVuS6gVonFPD fFsdZfk1IhwVzWCtS6tjh8aqzAmQL6BD7Y17A0bX+pGkwEiBZSHiAe16f5Nj4oOIXOvwwmHmED4 exBBPq8FIyVaO4ofJ30sW5CIhN3WnBfXtdG64Lo8wJpB5HVQRk8ptazXgthImnEeXAMF2Ktt6NN H5BAuu8BXcInwsHQwQOMOQO96OLH8NAglXD6K/LpG3NGV5PEb6UwOmWu0ocIMMMYMQxc/ioUAYx oiQukTnRd/3k4MiHYGUq1K1tJ2v32zPZ+f3eNQ4Ooh9x06 X-Received: by 2002:a05:6a21:648a:b0:3bf:a9cb:b799 with SMTP id adf61e73a8af0-3c08ef902e9mr6033506637.54.1783423536770; Tue, 07 Jul 2026 04:25:36 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b65960d88sm6548721c88.6.2026.07.07.04.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 04:25:36 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, marcosandrade95963@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v4 4/4] staging: rtl8723bs: convert update_attrib to return errno Date: Tue, 7 Jul 2026 11:25:03 +0000 Message-ID: <20260707112503.612-5-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260707112503.612-1-dennylin0707@gmail.com> References: <20260707112503.612-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert update_attrib() to return 0 on success and a negative errno on failure. Update rtw_xmit() to handle the returned error code. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 066f6e974e4e..4d886a35f4c8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -654,7 +654,7 @@ static int set_qos(struct pkt_file *ppktfile, struct pkt_attrib *pattrib) return 0; } -static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct pkt_attrib *pattrib) +static int update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct pkt_attrib *pattrib) { struct pkt_file pktfile; struct sta_info *psta = NULL; @@ -741,24 +741,24 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p } else { psta = rtw_get_stainfo(pstapriv, pattrib->ra); if (!psta) /* if we cannot get psta => drop the pkt */ - return _FAIL; + return -EINVAL; else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) && !(psta->state & _FW_LINKED)) - return _FAIL; + return -EINVAL; } if (!psta) { /* if we cannot get psta => drop the pkt */ - return _FAIL; + return -EINVAL; } if (!(psta->state & _FW_LINKED)) - return _FAIL; + return -EINVAL; spin_lock_bh(&psta->lock); ret = update_attrib_sec_info(padapter, pattrib, psta); if (ret) { spin_unlock_bh(&psta->lock); - return _FAIL; + return ret; } update_attrib_phy_info(padapter, pattrib, psta); @@ -794,7 +794,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p } /* pattrib->priority = 5; force to used VI queue, for testing */ - return _SUCCESS; + return 0; } static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitframe) @@ -1955,7 +1955,7 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) struct xmit_priv *pxmitpriv = &padapter->xmitpriv; struct xmit_frame *pxmitframe = NULL; - s32 res; + int ret; if (start == 0) start = jiffies; @@ -1968,9 +1968,8 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) if (!pxmitframe) return -1; - res = update_attrib(padapter, *ppkt, &pxmitframe->attrib); - - if (res != _SUCCESS) { + ret = update_attrib(padapter, *ppkt, &pxmitframe->attrib); + if (ret) { rtw_free_xmitframe(pxmitpriv, pxmitframe); return -1; } -- 2.43.0